[PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT

[PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT

[Shradha Gupta]

The current requested response version(V1) for MANA_QUERY_GF_STAT query
results in STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR value being set to
0 always.
In order to get the correct value for this counter we request the response
version to be V2.

Cc: stable@vger.kernel.org
Fixes: e1df5202e879 ("net :mana :Add remaining GDMA stats for MANA to ethtool")
Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
---
 drivers/net/ethernet/microsoft/mana/mana_en.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 57ac732e7707..f73848a4feb3 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -2536,6 +2536,7 @@ void mana_query_gf_stats(struct mana_port_context *apc)
 
 	mana_gd_init_req_hdr(&req.hdr, MANA_QUERY_GF_STAT,
 			     sizeof(req), sizeof(resp));
+	req.hdr.resp.msg_version = GDMA_MESSAGE_V2;
 	req.req_stats = STATISTICS_FLAGS_RX_DISCARDS_NO_WQE |
 			STATISTICS_FLAGS_RX_ERRORS_VPORT_DISABLED |
 			STATISTICS_FLAGS_HC_RX_BYTES |
-- 
2.43.0

RE: [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT

[Haiyang Zhang]

> -----Original Message-----
> From: Shradha Gupta <shradhagupta@linux.microsoft.com>
> Sent: Wednesday, December 4, 2024 12:48 AM
> To: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Shradha Gupta <shradhagupta@linux.microsoft.com>; KY Srinivasan
> <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Wei Liu
> <wei.liu@kernel.org>; Dexuan Cui <decui@microsoft.com>; Andrew Lunn
> <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; Long Li <longli@microsoft.com>; Konstantin
> Taranov <kotaranov@microsoft.com>; Souradeep Chakrabarti
> <schakrabarti@linux.microsoft.com>; Erick Archer
> <erick.archer@outlook.com>; Shradha Gupta <shradhagupta@microsoft.com>;
> stable@vger.kernel.org
> Subject: [PATCH net] net :mana :Request a V2 response version for
> MANA_QUERY_GF_STAT
> 
> The current requested response version(V1) for MANA_QUERY_GF_STAT query
> results in STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR value being set to
> 0 always.
> In order to get the correct value for this counter we request the response
> version to be V2.
> 
> Cc: stable@vger.kernel.org
> Fixes: e1df5202e879 ("net :mana :Add remaining GDMA stats for MANA to
> ethtool")
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>

Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Thanks.

Re: [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue,  3 Dec 2024 21:48:20 -0800 you wrote:
> The current requested response version(V1) for MANA_QUERY_GF_STAT query
> results in STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR value being set to
> 0 always.
> In order to get the correct value for this counter we request the response
> version to be V2.
> 
> Cc: stable@vger.kernel.org
> Fixes: e1df5202e879 ("net :mana :Add remaining GDMA stats for MANA to ethtool")
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> 
> [...]

Here is the summary with links:
  - [net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT
    https://git.kernel.org/netdev/net/c/31f1b55d5d7e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html