Re: ucounts: Move kfree() out of critical zone protected by ucounts_lock

[MengEn Sun <mengensun88@gmail.com>]

Hi Kuan Wei

On Fri, 6 Dec 2024 13:55:51 +0800 visitorckw@gmail.com wrote:
> Hi MengEn,
> 
> On Fri, Dec 06, 2024 at 12:13:47PM +0800, mengensun88@gmail.com wrote:
> > From: MengEn Sun <mengensun@tencent.com>
> > 
> > Although kfree is a non-sleep function, it is possible to enter a
> > long chain of calls probabilistically, so it looks better to move
> > kfree from alloc_ucounts() out of the critical zone of ucounts_lock.
> > 
> > Reviewed-by: YueHong Wu <yuehongwu@tencent.com>
> > Signed-off-by: MengEn Sun <mengensun@tencent.com>
> > ---
> >  kernel/ucount.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> It's a common convention to prefix your subject line with [PATCH] to
> let others know it's a patch. Additionally, when resending a patch
> without changes, consider adding RESEND to the subject line, e.g.,
> [PATCH RESEND] ucounts: Move kfree() out of critical zone protected by
> ucounts_lock.

Thank you very much for your reply. I will make some changes here.

> 
> See: https://www.kernel.org/doc/html/v6.12/process/submitting-patches.html#include-patch-in-the-subject

I will study this document carefully.

> 
> Regards,
> Kuan-Wei

Regards,
Meng En