From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: mengensun88@gmail.com
Cc: akpm@linux-foundation.org, linux@weissschuh.net,
joel.granados@kernel.org, avagin@google.com,
linux-kernel@vger.kernel.org, MengEn Sun <mengensun@tencent.com>
Subject: Re: ucounts: Move kfree() out of critical zone protected by ucounts_lock
Date: Fri, 6 Dec 2024 13:55:51 +0800 [thread overview]
Message-ID: <Z1KR55ggLyTzPys/@visitorckw-System-Product-Name> (raw)
In-Reply-To: <1733458427-11794-1-git-send-email-mengensun@tencent.com>
Hi MengEn,
On Fri, Dec 06, 2024 at 12:13:47PM +0800, mengensun88@gmail.com wrote:
> From: MengEn Sun <mengensun@tencent.com>
>
> Although kfree is a non-sleep function, it is possible to enter a
> long chain of calls probabilistically, so it looks better to move
> kfree from alloc_ucounts() out of the critical zone of ucounts_lock.
>
> Reviewed-by: YueHong Wu <yuehongwu@tencent.com>
> Signed-off-by: MengEn Sun <mengensun@tencent.com>
> ---
> kernel/ucount.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
It's a common convention to prefix your subject line with [PATCH] to
let others know it's a patch. Additionally, when resending a patch
without changes, consider adding RESEND to the subject line, e.g.,
[PATCH RESEND] ucounts: Move kfree() out of critical zone protected by
ucounts_lock.
See: https://www.kernel.org/doc/html/v6.12/process/submitting-patches.html#include-patch-in-the-subject
Regards,
Kuan-Wei
next prev parent reply other threads:[~2024-12-06 5:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 4:13 mengensun88
2024-12-06 5:55 ` Kuan-Wei Chiu [this message]
2024-12-06 7:30 ` MengEn Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1KR55ggLyTzPys/@visitorckw-System-Product-Name \
--to=visitorckw@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@google.com \
--cc=joel.granados@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mengensun88@gmail.com \
--cc=mengensun@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®