* [PATCH v2 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs
@ 2024-12-09 9:44 Krzysztof Kozlowski
2024-12-09 9:44 ` [PATCH v2 2/2] ASoC: dt-bindings: qcom,wcd9335: Drop number of DAIs from the header Krzysztof Kozlowski
2024-12-10 13:00 ` [PATCH v2 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-09 9:44 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Jaroslav Kysela, Takashi Iwai,
linux-arm-msm, linux-sound, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Dzmitry Sankouski
Number of DAIs in the codec is not really a binding, because it could
grow, e.g. when we implement missing features. Add the define to the
driver, which will replace the one in the binding header.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Dzmitry Sankouski <dsankouski@gmail.com>
Changes in v2:
1. Fix 'error: "NUM_CODEC_DAIS" redefined' error (Mark).
---
sound/soc/codecs/wcd9335.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index a2521e16c099..7cef43bb2a88 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -159,6 +159,8 @@
{"AMIC MUX" #id, "ADC5", "ADC5"}, \
{"AMIC MUX" #id, "ADC6", "ADC6"}
+#define NUM_CODEC_DAIS 7
+
enum {
WCD9335_RX0 = 0,
WCD9335_RX1,
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] ASoC: dt-bindings: qcom,wcd9335: Drop number of DAIs from the header
2024-12-09 9:44 [PATCH v2 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs Krzysztof Kozlowski
@ 2024-12-09 9:44 ` Krzysztof Kozlowski
2024-12-10 13:00 ` [PATCH v2 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-09 9:44 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Jaroslav Kysela, Takashi Iwai,
linux-arm-msm, linux-sound, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Dzmitry Sankouski
Number of DAIs in the codec is not really a binding constant, because it
could grow, e.g. when we implement missing features.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Dzmitry Sankouski <dsankouski@gmail.com>
Changes in v2:
1. Use "dt-bindings" in the subject prefix.
---
include/dt-bindings/sound/qcom,wcd9335.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/dt-bindings/sound/qcom,wcd9335.h b/include/dt-bindings/sound/qcom,wcd9335.h
index f5e9f1db091e..4fc68aeb9e04 100644
--- a/include/dt-bindings/sound/qcom,wcd9335.h
+++ b/include/dt-bindings/sound/qcom,wcd9335.h
@@ -10,6 +10,5 @@
#define AIF3_PB 4
#define AIF3_CAP 5
#define AIF4_PB 6
-#define NUM_CODEC_DAIS 7
#endif
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs
2024-12-09 9:44 [PATCH v2 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs Krzysztof Kozlowski
2024-12-09 9:44 ` [PATCH v2 2/2] ASoC: dt-bindings: qcom,wcd9335: Drop number of DAIs from the header Krzysztof Kozlowski
@ 2024-12-10 13:00 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2024-12-10 13:00 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Jaroslav Kysela, Takashi Iwai,
linux-arm-msm, linux-sound, devicetree, linux-kernel,
Krzysztof Kozlowski
Cc: Dzmitry Sankouski
On Mon, 09 Dec 2024 10:44:41 +0100, Krzysztof Kozlowski wrote:
> Number of DAIs in the codec is not really a binding, because it could
> grow, e.g. when we implement missing features. Add the define to the
> driver, which will replace the one in the binding header.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: codecs: wcd9335: Add define for number of DAIs
commit: 76c29db042e4f0fdea75c76cd4ad5f36080cd1c9
[2/2] ASoC: dt-bindings: qcom,wcd9335: Drop number of DAIs from the header
commit: e9705da8472f306b44cbe1992ea2161bb96ece6e
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-10 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-09 9:44 [PATCH v2 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs Krzysztof Kozlowski
2024-12-09 9:44 ` [PATCH v2 2/2] ASoC: dt-bindings: qcom,wcd9335: Drop number of DAIs from the header Krzysztof Kozlowski
2024-12-10 13:00 ` [PATCH v2 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®