[PATCH v2] ASoC: audio-graph-card: Call of_node_put() on correct node

[PATCH v2] ASoC: audio-graph-card: Call of_node_put() on correct node

[Stephen Gordon]

V2: Adjust commit message

Signed-off-by: Stephen Gordon <gordoste@iinet.net.au>
---
 sound/soc/generic/audio-graph-card2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/generic/audio-graph-card2.c b/sound/soc/generic/audio-graph-card2.c
index 5280c1b20..1f5c4e8ff 100644
--- a/sound/soc/generic/audio-graph-card2.c
+++ b/sound/soc/generic/audio-graph-card2.c
@@ -771,7 +771,7 @@ static void graph_link_init(struct simple_util_priv *priv,
 	of_node_get(port_codec);
 	if (graph_lnk_is_multi(port_codec)) {
 		ep_codec = graph_get_next_multi_ep(&port_codec);
-		of_node_put(port_cpu);
+		of_node_put(port_codec);
 		port_codec = ep_to_port(ep_codec);
 	} else {
 		ep_codec = of_graph_get_next_port_endpoint(port_codec, NULL);
-- 
2.39.5

Re: [PATCH v2] ASoC: audio-graph-card: Call of_node_put() on correct node

[Kuninori Morimoto]

Hi Stephen

> V2: Adjust commit message
> 
> Signed-off-by: Stephen Gordon <gordoste@iinet.net.au>
> ---

Thank you for pointing it.

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

But I think git-log comment is strange (you want to indicate it under --- line)


Thank you for your help !!

Best regards
---
Kuninori Morimoto

Re: [PATCH v2] ASoC: audio-graph-card: Call of_node_put() on correct node

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

On Sat, Dec 07, 2024 at 11:22:56PM +1100, Stephen Gordon wrote:
> V2: Adjust commit message
> 
> Signed-off-by: Stephen Gordon <gordoste@iinet.net.au>
> ---

Inter-version changelogs should come after --- so tools can handle them
automatically as covered in submitting-patches.rst.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2] ASoC: audio-graph-card: Call of_node_put() on correct node

[Mark Brown]

On Sat, 07 Dec 2024 23:22:56 +1100, Stephen Gordon wrote:
> V2: Adjust commit message
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: audio-graph-card: Call of_node_put() on correct node
      commit: 687630aa582acf674120c87350beb01d836c837c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark