* [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names
@ 2024-12-10 9:26 Chen-Yu Tsai
2024-12-10 9:26 ` [PATCH 2/2] arm64: dts: mediatek: mt8173-evb: " Chen-Yu Tsai
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chen-Yu Tsai @ 2024-12-10 9:26 UTC (permalink / raw)
To: Matthias Brugger, AngeloGioacchino Del Regno
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The MT6397 PMIC bindings specify exact names for its sub-nodes. The
names used in the current dts don't match, causing a validation error.
Fix up the names. Also drop the label for the regulators node, since
any reference should be against the individual regulator sub-nodes.
Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index b91072f4723f..b5d4b5baf478 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -931,7 +931,7 @@ pmic: pmic {
interrupt-controller;
#interrupt-cells = <2>;
- clock: mt6397clock {
+ clock: clocks {
compatible = "mediatek,mt6397-clk";
#clock-cells = <1>;
};
@@ -942,7 +942,7 @@ pio6397: pinctrl {
#gpio-cells = <2>;
};
- regulator: mt6397regulator {
+ regulators {
compatible = "mediatek,mt6397-regulator";
mt6397_vpca15_reg: buck_vpca15 {
@@ -1108,7 +1108,7 @@ mt6397_vibr_reg: ldo_vibr {
};
};
- rtc: mt6397rtc {
+ rtc: rtc {
compatible = "mediatek,mt6397-rtc";
};
};
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: dts: mediatek: mt8173-evb: Fix MT6397 PMIC sub-node names
2024-12-10 9:26 [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names Chen-Yu Tsai
@ 2024-12-10 9:26 ` Chen-Yu Tsai
2024-12-10 21:42 ` [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: " Rob Herring (Arm)
2024-12-12 10:04 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 5+ messages in thread
From: Chen-Yu Tsai @ 2024-12-10 9:26 UTC (permalink / raw)
To: Matthias Brugger, AngeloGioacchino Del Regno
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The MT6397 PMIC bindings specify exact names for its sub-nodes. The
names used in the current dts don't match, causing a validation error.
Fix up the names. Also drop the label for the regulators node, since
any reference should be against the individual regulator sub-nodes.
Fixes: 16ea61fc5614 ("arm64: dts: mt8173-evb: Add PMIC support")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index 511c16cb1d59..9fffed0ef4bf 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -307,7 +307,7 @@ pmic: pmic {
interrupt-controller;
#interrupt-cells = <2>;
- mt6397regulator: mt6397regulator {
+ regulators {
compatible = "mediatek,mt6397-regulator";
mt6397_vpca15_reg: buck_vpca15 {
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names
2024-12-10 9:26 [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names Chen-Yu Tsai
2024-12-10 9:26 ` [PATCH 2/2] arm64: dts: mediatek: mt8173-evb: " Chen-Yu Tsai
@ 2024-12-10 21:42 ` Rob Herring (Arm)
2024-12-11 5:09 ` Chen-Yu Tsai
2024-12-12 10:04 ` AngeloGioacchino Del Regno
2 siblings, 1 reply; 5+ messages in thread
From: Rob Herring (Arm) @ 2024-12-10 21:42 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: linux-mediatek, devicetree, Matthias Brugger, linux-arm-kernel,
AngeloGioacchino Del Regno, linux-kernel
On Tue, 10 Dec 2024 17:26:12 +0800, Chen-Yu Tsai wrote:
> The MT6397 PMIC bindings specify exact names for its sub-nodes. The
> names used in the current dts don't match, causing a validation error.
>
> Fix up the names. Also drop the label for the regulators node, since
> any reference should be against the individual regulator sub-nodes.
>
> Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y mediatek/mt8173-evb.dtb' for 20241210092614.3951748-1-wenst@chromium.org:
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vpca15: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vpca7: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vsramca15: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vsramca7: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vcore: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vgpu: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vdrm: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vio18: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vtcxo: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_va28: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vio28: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vusb: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vcama: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vmc: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vmch: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vemc3v3: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp1: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp2: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp3: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp4: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp5: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp6: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vibr: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names
2024-12-10 21:42 ` [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: " Rob Herring (Arm)
@ 2024-12-11 5:09 ` Chen-Yu Tsai
0 siblings, 0 replies; 5+ messages in thread
From: Chen-Yu Tsai @ 2024-12-11 5:09 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Chen-Yu Tsai, linux-mediatek, devicetree, Matthias Brugger,
linux-arm-kernel, AngeloGioacchino Del Regno, linux-kernel
On Wed, Dec 11, 2024 at 5:43 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>
>
> On Tue, 10 Dec 2024 17:26:12 +0800, Chen-Yu Tsai wrote:
> > The MT6397 PMIC bindings specify exact names for its sub-nodes. The
> > names used in the current dts don't match, causing a validation error.
> >
> > Fix up the names. Also drop the label for the regulators node, since
> > any reference should be against the individual regulator sub-nodes.
> >
> > Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y mediatek/mt8173-evb.dtb' for 20241210092614.3951748-1-wenst@chromium.org:
>
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vpca15: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vpca7: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vsramca15: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vsramca7: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vcore: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vgpu: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vdrm: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vio18: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vtcxo: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_va28: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vio28: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vusb: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vcama: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vmc: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vmch: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vemc3v3: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp1: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp2: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp3: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp4: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp5: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp6: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vibr: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
Ack. I already prepared another series to address these.
ChenYu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names
2024-12-10 9:26 [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names Chen-Yu Tsai
2024-12-10 9:26 ` [PATCH 2/2] arm64: dts: mediatek: mt8173-evb: " Chen-Yu Tsai
2024-12-10 21:42 ` [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: " Rob Herring (Arm)
@ 2024-12-12 10:04 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-12-12 10:04 UTC (permalink / raw)
To: Matthias Brugger, Chen-Yu Tsai
Cc: devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
On Tue, 10 Dec 2024 17:26:12 +0800, Chen-Yu Tsai wrote:
> The MT6397 PMIC bindings specify exact names for its sub-nodes. The
> names used in the current dts don't match, causing a validation error.
>
> Fix up the names. Also drop the label for the regulators node, since
> any reference should be against the individual regulator sub-nodes.
>
>
> [...]
Applied to v6.13-next/dts64, thanks!
[1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names
commit: beb06b727194f68b0a4b5183e50c88265ce185af
[2/2] arm64: dts: mediatek: mt8173-evb: Fix MT6397 PMIC sub-node names
commit: 9545ba142865b9099d43c972b9ebcf463606499a
Cheers,
Angelo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-12 10:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-10 9:26 [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names Chen-Yu Tsai
2024-12-10 9:26 ` [PATCH 2/2] arm64: dts: mediatek: mt8173-evb: " Chen-Yu Tsai
2024-12-10 21:42 ` [PATCH 1/2] arm64: dts: mediatek: mt8173-elm: " Rob Herring (Arm)
2024-12-11 5:09 ` Chen-Yu Tsai
2024-12-12 10:04 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®