mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mfd: lpc_ich: Add another Gemini Lake ISA bridge PCI device-id
@ 2024-11-14 19:38 Hans de Goede
  2024-11-14 20:18 ` Andy Shevchenko
  2024-12-11 12:25 ` (subset) " Lee Jones
  0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2024-11-14 19:38 UTC (permalink / raw)
  To: Andy Shevchenko, Peter Tyser, Lee Jones
  Cc: Hans de Goede, platform-driver-x86, linux-kernel

On N4100 / N4120 Gemini Lake SoCs the ISA bridge PCI device-id is 31e8
rather the 3197 found on e.g. the N4000 / N4020.

While at fix the existing GLK PCI-id table entry breaking the table
being sorted by device-id.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/mfd/lpc_ich.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index f14901660147..4b7d0cb9340f 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -834,8 +834,9 @@ static const struct pci_device_id lpc_ich_ids[] = {
 	{ PCI_VDEVICE(INTEL, 0x2917), LPC_ICH9ME},
 	{ PCI_VDEVICE(INTEL, 0x2918), LPC_ICH9},
 	{ PCI_VDEVICE(INTEL, 0x2919), LPC_ICH9M},
-	{ PCI_VDEVICE(INTEL, 0x3197), LPC_GLK},
 	{ PCI_VDEVICE(INTEL, 0x2b9c), LPC_COUGARMOUNTAIN},
+	{ PCI_VDEVICE(INTEL, 0x3197), LPC_GLK},
+	{ PCI_VDEVICE(INTEL, 0x31e8), LPC_GLK},
 	{ PCI_VDEVICE(INTEL, 0x3a14), LPC_ICH10DO},
 	{ PCI_VDEVICE(INTEL, 0x3a16), LPC_ICH10R},
 	{ PCI_VDEVICE(INTEL, 0x3a18), LPC_ICH10},
-- 
2.47.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: lpc_ich: Add another Gemini Lake ISA bridge PCI device-id
  2024-11-14 19:38 [PATCH] mfd: lpc_ich: Add another Gemini Lake ISA bridge PCI device-id Hans de Goede
@ 2024-11-14 20:18 ` Andy Shevchenko
  2024-12-11 12:25 ` (subset) " Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-11-14 20:18 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Andy Shevchenko, Peter Tyser, Lee Jones, platform-driver-x86,
	linux-kernel

On Thu, Nov 14, 2024 at 9:38 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> On N4100 / N4120 Gemini Lake SoCs the ISA bridge PCI device-id is 31e8
> rather the 3197 found on e.g. the N4000 / N4020.
>
> While at fix the existing GLK PCI-id table entry breaking the table
> being sorted by device-id.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: (subset) [PATCH] mfd: lpc_ich: Add another Gemini Lake ISA bridge PCI device-id
  2024-11-14 19:38 [PATCH] mfd: lpc_ich: Add another Gemini Lake ISA bridge PCI device-id Hans de Goede
  2024-11-14 20:18 ` Andy Shevchenko
@ 2024-12-11 12:25 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2024-12-11 12:25 UTC (permalink / raw)
  To: Andy Shevchenko, Peter Tyser, Lee Jones, Hans de Goede
  Cc: platform-driver-x86, linux-kernel

On Thu, 14 Nov 2024 20:38:08 +0100, Hans de Goede wrote:
> On N4100 / N4120 Gemini Lake SoCs the ISA bridge PCI device-id is 31e8
> rather the 3197 found on e.g. the N4000 / N4020.
> 
> While at fix the existing GLK PCI-id table entry breaking the table
> being sorted by device-id.
> 
> 
> [...]

Applied, thanks!

[1/1] mfd: lpc_ich: Add another Gemini Lake ISA bridge PCI device-id
      commit: 49339c4af2adcf9e9d080fcf751723d3ba52fe50

--
Lee Jones [李琼斯]


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-12-11 12:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-14 19:38 [PATCH] mfd: lpc_ich: Add another Gemini Lake ISA bridge PCI device-id Hans de Goede
2024-11-14 20:18 ` Andy Shevchenko
2024-12-11 12:25 ` (subset) " Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®