* [PATCH 1/8] regulator: dt-bindings: mt6315: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
@ 2024-12-11 5:24 ` Chen-Yu Tsai
2024-12-12 9:57 ` AngeloGioacchino Del Regno
2024-12-11 5:24 ` [PATCH 2/8] arm64: dts: mediatek: mt8173-evb: " Chen-Yu Tsai
` (9 subsequent siblings)
10 siblings, 1 reply; 13+ messages in thread
From: Chen-Yu Tsai @ 2024-12-11 5:24 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Hsin-Hsiung Wang
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The "regulator-compatible" property has been deprecated since 2012 in
commit 13511def87b9 ("regulator: deprecate regulator-compatible DT
property"), which is so old it's not even mentioned in the converted
regulator bindings YAML file. It should not have been used for new
submissions such as the MT6315.
Drop the property from the MT6315 regulator binding and its examples.
Fixes: 977fb5b58469 ("regulator: document binding for MT6315 regulator")
Fixes: 6d435a94ba5b ("regulator: mt6315: Enforce regulator-compatible, not name")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
.../devicetree/bindings/regulator/mt6315-regulator.yaml | 6 ------
1 file changed, 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
index cd4aa27218a1..fa6743bb269d 100644
--- a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
@@ -35,10 +35,6 @@ properties:
$ref: regulator.yaml#
unevaluatedProperties: false
- properties:
- regulator-compatible:
- pattern: "^vbuck[1-4]$"
-
additionalProperties: false
required:
@@ -56,7 +52,6 @@ examples:
regulators {
vbuck1 {
- regulator-compatible = "vbuck1";
regulator-min-microvolt = <300000>;
regulator-max-microvolt = <1193750>;
regulator-enable-ramp-delay = <256>;
@@ -64,7 +59,6 @@ examples:
};
vbuck3 {
- regulator-compatible = "vbuck3";
regulator-min-microvolt = <300000>;
regulator-max-microvolt = <1193750>;
regulator-enable-ramp-delay = <256>;
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/8] regulator: dt-bindings: mt6315: Drop regulator-compatible property
2024-12-11 5:24 ` [PATCH 1/8] regulator: dt-bindings: mt6315: " Chen-Yu Tsai
@ 2024-12-12 9:57 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-12-12 9:57 UTC (permalink / raw)
To: Chen-Yu Tsai, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, Hsin-Hsiung Wang
Cc: devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
Il 11/12/24 06:24, Chen-Yu Tsai ha scritto:
> The "regulator-compatible" property has been deprecated since 2012 in
> commit 13511def87b9 ("regulator: deprecate regulator-compatible DT
> property"), which is so old it's not even mentioned in the converted
> regulator bindings YAML file. It should not have been used for new
> submissions such as the MT6315.
>
> Drop the property from the MT6315 regulator binding and its examples.
>
> Fixes: 977fb5b58469 ("regulator: document binding for MT6315 regulator")
> Fixes: 6d435a94ba5b ("regulator: mt6315: Enforce regulator-compatible, not name")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/8] arm64: dts: mediatek: mt8173-evb: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
2024-12-11 5:24 ` [PATCH 1/8] regulator: dt-bindings: mt6315: " Chen-Yu Tsai
@ 2024-12-11 5:24 ` Chen-Yu Tsai
2024-12-11 5:24 ` [PATCH 3/8] arm64: dts: mediatek: mt8173-elm: " Chen-Yu Tsai
` (8 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Chen-Yu Tsai @ 2024-12-11 5:24 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Hsin-Hsiung Wang
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The "regulator-compatible" property has been deprecated since 2012 in
commit 13511def87b9 ("regulator: deprecate regulator-compatible DT
property"), which is so old it's not even mentioned in the converted
regulator bindings YAML file. It is also not listed in the MT6397
regulator bindings. Having them present produces a whole bunch of
validation errors:
Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
Drop the "regulator-compatible" property from the board dts. The
property values are the same as the node name, so everything should
continue to work.
Fixes: 16ea61fc5614 ("arm64: dts: mt8173-evb: Add PMIC support")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 23 ---------------------
1 file changed, 23 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index bb4671c18e3b..511c16cb1d59 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -311,7 +311,6 @@ mt6397regulator: mt6397regulator {
compatible = "mediatek,mt6397-regulator";
mt6397_vpca15_reg: buck_vpca15 {
- regulator-compatible = "buck_vpca15";
regulator-name = "vpca15";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -320,7 +319,6 @@ mt6397_vpca15_reg: buck_vpca15 {
};
mt6397_vpca7_reg: buck_vpca7 {
- regulator-compatible = "buck_vpca7";
regulator-name = "vpca7";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -329,7 +327,6 @@ mt6397_vpca7_reg: buck_vpca7 {
};
mt6397_vsramca15_reg: buck_vsramca15 {
- regulator-compatible = "buck_vsramca15";
regulator-name = "vsramca15";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -338,7 +335,6 @@ mt6397_vsramca15_reg: buck_vsramca15 {
};
mt6397_vsramca7_reg: buck_vsramca7 {
- regulator-compatible = "buck_vsramca7";
regulator-name = "vsramca7";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -347,7 +343,6 @@ mt6397_vsramca7_reg: buck_vsramca7 {
};
mt6397_vcore_reg: buck_vcore {
- regulator-compatible = "buck_vcore";
regulator-name = "vcore";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -356,7 +351,6 @@ mt6397_vcore_reg: buck_vcore {
};
mt6397_vgpu_reg: buck_vgpu {
- regulator-compatible = "buck_vgpu";
regulator-name = "vgpu";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -365,7 +359,6 @@ mt6397_vgpu_reg: buck_vgpu {
};
mt6397_vdrm_reg: buck_vdrm {
- regulator-compatible = "buck_vdrm";
regulator-name = "vdrm";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1400000>;
@@ -374,7 +367,6 @@ mt6397_vdrm_reg: buck_vdrm {
};
mt6397_vio18_reg: buck_vio18 {
- regulator-compatible = "buck_vio18";
regulator-name = "vio18";
regulator-min-microvolt = <1620000>;
regulator-max-microvolt = <1980000>;
@@ -383,19 +375,16 @@ mt6397_vio18_reg: buck_vio18 {
};
mt6397_vtcxo_reg: ldo_vtcxo {
- regulator-compatible = "ldo_vtcxo";
regulator-name = "vtcxo";
regulator-always-on;
};
mt6397_va28_reg: ldo_va28 {
- regulator-compatible = "ldo_va28";
regulator-name = "va28";
regulator-always-on;
};
mt6397_vcama_reg: ldo_vcama {
- regulator-compatible = "ldo_vcama";
regulator-name = "vcama";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <2800000>;
@@ -403,18 +392,15 @@ mt6397_vcama_reg: ldo_vcama {
};
mt6397_vio28_reg: ldo_vio28 {
- regulator-compatible = "ldo_vio28";
regulator-name = "vio28";
regulator-always-on;
};
mt6397_vusb_reg: ldo_vusb {
- regulator-compatible = "ldo_vusb";
regulator-name = "vusb";
};
mt6397_vmc_reg: ldo_vmc {
- regulator-compatible = "ldo_vmc";
regulator-name = "vmc";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
@@ -422,7 +408,6 @@ mt6397_vmc_reg: ldo_vmc {
};
mt6397_vmch_reg: ldo_vmch {
- regulator-compatible = "ldo_vmch";
regulator-name = "vmch";
regulator-min-microvolt = <3000000>;
regulator-max-microvolt = <3300000>;
@@ -430,7 +415,6 @@ mt6397_vmch_reg: ldo_vmch {
};
mt6397_vemc_3v3_reg: ldo_vemc3v3 {
- regulator-compatible = "ldo_vemc3v3";
regulator-name = "vemc_3v3";
regulator-min-microvolt = <3000000>;
regulator-max-microvolt = <3300000>;
@@ -438,7 +422,6 @@ mt6397_vemc_3v3_reg: ldo_vemc3v3 {
};
mt6397_vgp1_reg: ldo_vgp1 {
- regulator-compatible = "ldo_vgp1";
regulator-name = "vcamd";
regulator-min-microvolt = <1220000>;
regulator-max-microvolt = <3300000>;
@@ -446,7 +429,6 @@ mt6397_vgp1_reg: ldo_vgp1 {
};
mt6397_vgp2_reg: ldo_vgp2 {
- regulator-compatible = "ldo_vgp2";
regulator-name = "vcamio";
regulator-min-microvolt = <1000000>;
regulator-max-microvolt = <3300000>;
@@ -454,7 +436,6 @@ mt6397_vgp2_reg: ldo_vgp2 {
};
mt6397_vgp3_reg: ldo_vgp3 {
- regulator-compatible = "ldo_vgp3";
regulator-name = "vcamaf";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3300000>;
@@ -462,7 +443,6 @@ mt6397_vgp3_reg: ldo_vgp3 {
};
mt6397_vgp4_reg: ldo_vgp4 {
- regulator-compatible = "ldo_vgp4";
regulator-name = "vgp4";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3300000>;
@@ -470,7 +450,6 @@ mt6397_vgp4_reg: ldo_vgp4 {
};
mt6397_vgp5_reg: ldo_vgp5 {
- regulator-compatible = "ldo_vgp5";
regulator-name = "vgp5";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3000000>;
@@ -478,7 +457,6 @@ mt6397_vgp5_reg: ldo_vgp5 {
};
mt6397_vgp6_reg: ldo_vgp6 {
- regulator-compatible = "ldo_vgp6";
regulator-name = "vgp6";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3300000>;
@@ -486,7 +464,6 @@ mt6397_vgp6_reg: ldo_vgp6 {
};
mt6397_vibr_reg: ldo_vibr {
- regulator-compatible = "ldo_vibr";
regulator-name = "vibr";
regulator-min-microvolt = <1300000>;
regulator-max-microvolt = <3300000>;
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 3/8] arm64: dts: mediatek: mt8173-elm: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
2024-12-11 5:24 ` [PATCH 1/8] regulator: dt-bindings: mt6315: " Chen-Yu Tsai
2024-12-11 5:24 ` [PATCH 2/8] arm64: dts: mediatek: mt8173-evb: " Chen-Yu Tsai
@ 2024-12-11 5:24 ` Chen-Yu Tsai
2024-12-11 5:24 ` [PATCH 4/8] arm64: dts: mediatek: mt8192-asurada: " Chen-Yu Tsai
` (7 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Chen-Yu Tsai @ 2024-12-11 5:24 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Hsin-Hsiung Wang
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The "regulator-compatible" property has been deprecated since 2012 in
commit 13511def87b9 ("regulator: deprecate regulator-compatible DT
property"), which is so old it's not even mentioned in the converted
regulator bindings YAML file. It is also not listed in the MT6397
regulator bindings. Having them present produces a whole bunch of
validation errors:
Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
Drop the "regulator-compatible" property from the board dts. The
property values are the same as the node name, so everything should
continue to work.
Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 23 --------------------
1 file changed, 23 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index eee64461421f..b91072f4723f 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -946,7 +946,6 @@ regulator: mt6397regulator {
compatible = "mediatek,mt6397-regulator";
mt6397_vpca15_reg: buck_vpca15 {
- regulator-compatible = "buck_vpca15";
regulator-name = "vpca15";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -956,7 +955,6 @@ mt6397_vpca15_reg: buck_vpca15 {
};
mt6397_vpca7_reg: buck_vpca7 {
- regulator-compatible = "buck_vpca7";
regulator-name = "vpca7";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -966,7 +964,6 @@ mt6397_vpca7_reg: buck_vpca7 {
};
mt6397_vsramca15_reg: buck_vsramca15 {
- regulator-compatible = "buck_vsramca15";
regulator-name = "vsramca15";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -975,7 +972,6 @@ mt6397_vsramca15_reg: buck_vsramca15 {
};
mt6397_vsramca7_reg: buck_vsramca7 {
- regulator-compatible = "buck_vsramca7";
regulator-name = "vsramca7";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -984,7 +980,6 @@ mt6397_vsramca7_reg: buck_vsramca7 {
};
mt6397_vcore_reg: buck_vcore {
- regulator-compatible = "buck_vcore";
regulator-name = "vcore";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -993,7 +988,6 @@ mt6397_vcore_reg: buck_vcore {
};
mt6397_vgpu_reg: buck_vgpu {
- regulator-compatible = "buck_vgpu";
regulator-name = "vgpu";
regulator-min-microvolt = < 700000>;
regulator-max-microvolt = <1350000>;
@@ -1002,7 +996,6 @@ mt6397_vgpu_reg: buck_vgpu {
};
mt6397_vdrm_reg: buck_vdrm {
- regulator-compatible = "buck_vdrm";
regulator-name = "vdrm";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1400000>;
@@ -1011,7 +1004,6 @@ mt6397_vdrm_reg: buck_vdrm {
};
mt6397_vio18_reg: buck_vio18 {
- regulator-compatible = "buck_vio18";
regulator-name = "vio18";
regulator-min-microvolt = <1620000>;
regulator-max-microvolt = <1980000>;
@@ -1020,18 +1012,15 @@ mt6397_vio18_reg: buck_vio18 {
};
mt6397_vtcxo_reg: ldo_vtcxo {
- regulator-compatible = "ldo_vtcxo";
regulator-name = "vtcxo";
regulator-always-on;
};
mt6397_va28_reg: ldo_va28 {
- regulator-compatible = "ldo_va28";
regulator-name = "va28";
};
mt6397_vcama_reg: ldo_vcama {
- regulator-compatible = "ldo_vcama";
regulator-name = "vcama";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
@@ -1039,18 +1028,15 @@ mt6397_vcama_reg: ldo_vcama {
};
mt6397_vio28_reg: ldo_vio28 {
- regulator-compatible = "ldo_vio28";
regulator-name = "vio28";
regulator-always-on;
};
mt6397_vusb_reg: ldo_vusb {
- regulator-compatible = "ldo_vusb";
regulator-name = "vusb";
};
mt6397_vmc_reg: ldo_vmc {
- regulator-compatible = "ldo_vmc";
regulator-name = "vmc";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
@@ -1058,7 +1044,6 @@ mt6397_vmc_reg: ldo_vmc {
};
mt6397_vmch_reg: ldo_vmch {
- regulator-compatible = "ldo_vmch";
regulator-name = "vmch";
regulator-min-microvolt = <3000000>;
regulator-max-microvolt = <3300000>;
@@ -1066,7 +1051,6 @@ mt6397_vmch_reg: ldo_vmch {
};
mt6397_vemc_3v3_reg: ldo_vemc3v3 {
- regulator-compatible = "ldo_vemc3v3";
regulator-name = "vemc_3v3";
regulator-min-microvolt = <3000000>;
regulator-max-microvolt = <3300000>;
@@ -1074,7 +1058,6 @@ mt6397_vemc_3v3_reg: ldo_vemc3v3 {
};
mt6397_vgp1_reg: ldo_vgp1 {
- regulator-compatible = "ldo_vgp1";
regulator-name = "vcamd";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
@@ -1082,7 +1065,6 @@ mt6397_vgp1_reg: ldo_vgp1 {
};
mt6397_vgp2_reg: ldo_vgp2 {
- regulator-compatible = "ldo_vgp2";
regulator-name = "vcamio";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
@@ -1090,7 +1072,6 @@ mt6397_vgp2_reg: ldo_vgp2 {
};
mt6397_vgp3_reg: ldo_vgp3 {
- regulator-compatible = "ldo_vgp3";
regulator-name = "vcamaf";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
@@ -1098,7 +1079,6 @@ mt6397_vgp3_reg: ldo_vgp3 {
};
mt6397_vgp4_reg: ldo_vgp4 {
- regulator-compatible = "ldo_vgp4";
regulator-name = "vgp4";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3300000>;
@@ -1106,7 +1086,6 @@ mt6397_vgp4_reg: ldo_vgp4 {
};
mt6397_vgp5_reg: ldo_vgp5 {
- regulator-compatible = "ldo_vgp5";
regulator-name = "vgp5";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3000000>;
@@ -1114,7 +1093,6 @@ mt6397_vgp5_reg: ldo_vgp5 {
};
mt6397_vgp6_reg: ldo_vgp6 {
- regulator-compatible = "ldo_vgp6";
regulator-name = "vgp6";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
@@ -1123,7 +1101,6 @@ mt6397_vgp6_reg: ldo_vgp6 {
};
mt6397_vibr_reg: ldo_vibr {
- regulator-compatible = "ldo_vibr";
regulator-name = "vibr";
regulator-min-microvolt = <1300000>;
regulator-max-microvolt = <3300000>;
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 4/8] arm64: dts: mediatek: mt8192-asurada: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
` (2 preceding siblings ...)
2024-12-11 5:24 ` [PATCH 3/8] arm64: dts: mediatek: mt8173-elm: " Chen-Yu Tsai
@ 2024-12-11 5:24 ` Chen-Yu Tsai
2024-12-11 5:24 ` [PATCH 5/8] arm64: dts: mediatek: mt8195-cherry: " Chen-Yu Tsai
` (6 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Chen-Yu Tsai @ 2024-12-11 5:24 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Hsin-Hsiung Wang
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The "regulator-compatible" property has been deprecated since 2012 in
commit 13511def87b9 ("regulator: deprecate regulator-compatible DT
property"), which is so old it's not even mentioned in the converted
regulator bindings YAML file. It should not have been used for new
submissions such as the MT6315.
Drop the "regulator-compatible" property from the board dts. The
property values are the same as the node name, so everything should
continue to work.
Fixes: 3183cb62b033 ("arm64: dts: mediatek: asurada: Add SPMI regulators")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
index 741af6a7f197..516fba9b3c6d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
@@ -1580,7 +1580,6 @@ mt6315_6: pmic@6 {
regulators {
mt6315_6_vbuck1: vbuck1 {
- regulator-compatible = "vbuck1";
regulator-name = "Vbcpu";
regulator-min-microvolt = <400000>;
regulator-max-microvolt = <1193750>;
@@ -1590,7 +1589,6 @@ mt6315_6_vbuck1: vbuck1 {
};
mt6315_6_vbuck3: vbuck3 {
- regulator-compatible = "vbuck3";
regulator-name = "Vlcpu";
regulator-min-microvolt = <400000>;
regulator-max-microvolt = <1193750>;
@@ -1607,7 +1605,6 @@ mt6315_7: pmic@7 {
regulators {
mt6315_7_vbuck1: vbuck1 {
- regulator-compatible = "vbuck1";
regulator-name = "Vgpu";
regulator-min-microvolt = <400000>;
regulator-max-microvolt = <800000>;
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 5/8] arm64: dts: mediatek: mt8195-cherry: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
` (3 preceding siblings ...)
2024-12-11 5:24 ` [PATCH 4/8] arm64: dts: mediatek: mt8192-asurada: " Chen-Yu Tsai
@ 2024-12-11 5:24 ` Chen-Yu Tsai
2024-12-11 5:24 ` [PATCH 6/8] arm64: dts: mediatek: mt8195-demo: " Chen-Yu Tsai
` (5 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Chen-Yu Tsai @ 2024-12-11 5:24 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Hsin-Hsiung Wang
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The "regulator-compatible" property has been deprecated since 2012 in
commit 13511def87b9 ("regulator: deprecate regulator-compatible DT
property"), which is so old it's not even mentioned in the converted
regulator bindings YAML file. It should not have been used for new
submissions such as the MT6315.
Drop the "regulator-compatible" property from the board dts. The
property values are the same as the node name, so everything should
continue to work.
Fixes: 260c04d425eb ("arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
index 2c7b2223ee76..5056e07399e2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
@@ -1285,7 +1285,6 @@ mt6315@6 {
regulators {
mt6315_6_vbuck1: vbuck1 {
- regulator-compatible = "vbuck1";
regulator-name = "Vbcpu";
regulator-min-microvolt = <400000>;
regulator-max-microvolt = <1193750>;
@@ -1303,7 +1302,6 @@ mt6315@7 {
regulators {
mt6315_7_vbuck1: vbuck1 {
- regulator-compatible = "vbuck1";
regulator-name = "Vgpu";
regulator-min-microvolt = <400000>;
regulator-max-microvolt = <1193750>;
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 6/8] arm64: dts: mediatek: mt8195-demo: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
` (4 preceding siblings ...)
2024-12-11 5:24 ` [PATCH 5/8] arm64: dts: mediatek: mt8195-cherry: " Chen-Yu Tsai
@ 2024-12-11 5:24 ` Chen-Yu Tsai
2024-12-11 5:24 ` [PATCH 7/8] arm64: dts: medaitek: mt8395-nio-12l: " Chen-Yu Tsai
` (4 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Chen-Yu Tsai @ 2024-12-11 5:24 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Hsin-Hsiung Wang
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The "regulator-compatible" property has been deprecated since 2012 in
commit 13511def87b9 ("regulator: deprecate regulator-compatible DT
property"), which is so old it's not even mentioned in the converted
regulator bindings YAML file. It is also not listed in the MT6360
regulator and charger bindings.
Drop the "regulator-compatible" property from the board dts. The MT6360
bindings actually require the lowercase name, so with the property
present the regulators were likely not actually working.
Fixes: 6147314aeedc ("arm64: dts: mediatek: Add device-tree for MT8195 Demo board")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
index 31d424b8fc7c..bfb75296795c 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
@@ -137,7 +137,6 @@ charger {
richtek,vinovp-microvolt = <14500000>;
otg_vbus_regulator: usb-otg-vbus-regulator {
- regulator-compatible = "usb-otg-vbus";
regulator-name = "usb-otg-vbus";
regulator-min-microvolt = <4425000>;
regulator-max-microvolt = <5825000>;
@@ -149,7 +148,6 @@ regulator {
LDO_VIN3-supply = <&mt6360_buck2>;
mt6360_buck1: buck1 {
- regulator-compatible = "BUCK1";
regulator-name = "mt6360,buck1";
regulator-min-microvolt = <300000>;
regulator-max-microvolt = <1300000>;
@@ -160,7 +158,6 @@ MT6360_OPMODE_LP
};
mt6360_buck2: buck2 {
- regulator-compatible = "BUCK2";
regulator-name = "mt6360,buck2";
regulator-min-microvolt = <300000>;
regulator-max-microvolt = <1300000>;
@@ -171,7 +168,6 @@ MT6360_OPMODE_LP
};
mt6360_ldo1: ldo1 {
- regulator-compatible = "LDO1";
regulator-name = "mt6360,ldo1";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3600000>;
@@ -180,7 +176,6 @@ mt6360_ldo1: ldo1 {
};
mt6360_ldo2: ldo2 {
- regulator-compatible = "LDO2";
regulator-name = "mt6360,ldo2";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3600000>;
@@ -189,7 +184,6 @@ mt6360_ldo2: ldo2 {
};
mt6360_ldo3: ldo3 {
- regulator-compatible = "LDO3";
regulator-name = "mt6360,ldo3";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3600000>;
@@ -198,7 +192,6 @@ mt6360_ldo3: ldo3 {
};
mt6360_ldo5: ldo5 {
- regulator-compatible = "LDO5";
regulator-name = "mt6360,ldo5";
regulator-min-microvolt = <2700000>;
regulator-max-microvolt = <3600000>;
@@ -207,7 +200,6 @@ mt6360_ldo5: ldo5 {
};
mt6360_ldo6: ldo6 {
- regulator-compatible = "LDO6";
regulator-name = "mt6360,ldo6";
regulator-min-microvolt = <500000>;
regulator-max-microvolt = <2100000>;
@@ -216,7 +208,6 @@ mt6360_ldo6: ldo6 {
};
mt6360_ldo7: ldo7 {
- regulator-compatible = "LDO7";
regulator-name = "mt6360,ldo7";
regulator-min-microvolt = <500000>;
regulator-max-microvolt = <2100000>;
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 7/8] arm64: dts: medaitek: mt8395-nio-12l: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
` (5 preceding siblings ...)
2024-12-11 5:24 ` [PATCH 6/8] arm64: dts: mediatek: mt8195-demo: " Chen-Yu Tsai
@ 2024-12-11 5:24 ` Chen-Yu Tsai
2024-12-11 5:24 ` [PATCH 8/8] arm64: dts: mediatek: mt8395-genio-1200-evk: " Chen-Yu Tsai
` (3 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Chen-Yu Tsai @ 2024-12-11 5:24 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Hsin-Hsiung Wang
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The "regulator-compatible" property has been deprecated since 2012 in
commit 13511def87b9 ("regulator: deprecate regulator-compatible DT
property"), which is so old it's not even mentioned in the converted
regulator bindings YAML file. It should not have been used for new
submissions such as the MT6315.
Drop the "regulator-compatible" property from the board dts. The
property values are the same as the node name, so everything should
continue to work.
Fixes: 96564b1e2ea4 ("arm64: dts: mediatek: Introduce the MT8395 Radxa NIO 12L board")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 14ec970c4e49..41dc34837b02 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -812,7 +812,6 @@ mt6315_6: pmic@6 {
regulators {
mt6315_6_vbuck1: vbuck1 {
- regulator-compatible = "vbuck1";
regulator-name = "Vbcpu";
regulator-min-microvolt = <300000>;
regulator-max-microvolt = <1193750>;
@@ -829,7 +828,6 @@ mt6315_7: pmic@7 {
regulators {
mt6315_7_vbuck1: vbuck1 {
- regulator-compatible = "vbuck1";
regulator-name = "Vgpu";
regulator-min-microvolt = <300000>;
regulator-max-microvolt = <1193750>;
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 8/8] arm64: dts: mediatek: mt8395-genio-1200-evk: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
` (6 preceding siblings ...)
2024-12-11 5:24 ` [PATCH 7/8] arm64: dts: medaitek: mt8395-nio-12l: " Chen-Yu Tsai
@ 2024-12-11 5:24 ` Chen-Yu Tsai
2024-12-12 9:57 ` [PATCH 0/8] arm64: dts: mediatek: " AngeloGioacchino Del Regno
` (2 subsequent siblings)
10 siblings, 0 replies; 13+ messages in thread
From: Chen-Yu Tsai @ 2024-12-11 5:24 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Hsin-Hsiung Wang
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
The "regulator-compatible" property has been deprecated since 2012 in
commit 13511def87b9 ("regulator: deprecate regulator-compatible DT
property"), which is so old it's not even mentioned in the converted
regulator bindings YAML file. It should not have been used for new
submissions such as the MT6315.
Drop the "regulator-compatible" property from the board dts. The
property values are the same as the node name, so everything should
continue to work.
Fixes: f2b543a191b6 ("arm64: dts: mediatek: add device-tree for Genio 1200 EVK board")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
index 5f16fb820580..5950194c9ccb 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
@@ -835,7 +835,6 @@ mt6315_6: pmic@6 {
regulators {
mt6315_6_vbuck1: vbuck1 {
- regulator-compatible = "vbuck1";
regulator-name = "Vbcpu";
regulator-min-microvolt = <300000>;
regulator-max-microvolt = <1193750>;
@@ -852,7 +851,6 @@ mt6315_7: pmic@7 {
regulators {
mt6315_7_vbuck1: vbuck1 {
- regulator-compatible = "vbuck1";
regulator-name = "Vgpu";
regulator-min-microvolt = <546000>;
regulator-max-microvolt = <787000>;
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
` (7 preceding siblings ...)
2024-12-11 5:24 ` [PATCH 8/8] arm64: dts: mediatek: mt8395-genio-1200-evk: " Chen-Yu Tsai
@ 2024-12-12 9:57 ` AngeloGioacchino Del Regno
2024-12-12 10:04 ` (subset) " AngeloGioacchino Del Regno
2024-12-12 12:51 ` Mark Brown
10 siblings, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-12-12 9:57 UTC (permalink / raw)
To: Chen-Yu Tsai, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, Hsin-Hsiung Wang
Cc: devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
Il 11/12/24 06:24, Chen-Yu Tsai ha scritto:
> Hi folks,
>
> This series drops usage of the long deprecated "regulator-compatible"
> property from MediaTek device tree files. The property was introduced
> in 2012, and then subsequently deprecated after two months. It was
> never carried over during the binding YAML conversion.
>
> Drop the property from the MT6315 regulator binding, and all MediaTek
> device tree files. IMO it should never have been used to begin with.
> This also gets rid of any validation errors [1] related to them.
>
> Please have a look.
>
Whole series is
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> Thanks
> ChenYu
>
> [1] https://lore.kernel.org/all/173386568696.497617.3727087837255802552.robh@kernel.org/
>
> Chen-Yu Tsai (8):
> regulator: dt-bindings: mt6315: Drop regulator-compatible property
> arm64: dts: mediatek: mt8173-evb: Drop regulator-compatible property
> arm64: dts: mediatek: mt8173-elm: Drop regulator-compatible property
> arm64: dts: mediatek: mt8192-asurada: Drop regulator-compatible
> property
> arm64: dts: mediatek: mt8195-cherry: Drop regulator-compatible
> property
> arm64: dts: mediatek: mt8195-demo: Drop regulator-compatible property
> arm64: dts: medaitek: mt8395-nio-12l: Drop regulator-compatible
> property
> arm64: dts: mediatek: mt8395-genio-1200-evk: Drop regulator-compatible
> property
>
> .../bindings/regulator/mt6315-regulator.yaml | 6 -----
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 23 -------------------
> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 23 -------------------
> .../boot/dts/mediatek/mt8192-asurada.dtsi | 3 ---
> .../boot/dts/mediatek/mt8195-cherry.dtsi | 2 --
> arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 9 --------
> .../dts/mediatek/mt8395-genio-1200-evk.dts | 2 --
> .../dts/mediatek/mt8395-radxa-nio-12l.dts | 2 --
> 8 files changed, 70 deletions(-)
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: (subset) [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
` (8 preceding siblings ...)
2024-12-12 9:57 ` [PATCH 0/8] arm64: dts: mediatek: " AngeloGioacchino Del Regno
@ 2024-12-12 10:04 ` AngeloGioacchino Del Regno
2024-12-12 12:51 ` Mark Brown
10 siblings, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-12-12 10:04 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, Hsin-Hsiung Wang, Chen-Yu Tsai
Cc: devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
On Wed, 11 Dec 2024 13:24:18 +0800, Chen-Yu Tsai wrote:
> This series drops usage of the long deprecated "regulator-compatible"
> property from MediaTek device tree files. The property was introduced
> in 2012, and then subsequently deprecated after two months. It was
> never carried over during the binding YAML conversion.
>
> Drop the property from the MT6315 regulator binding, and all MediaTek
> device tree files. IMO it should never have been used to begin with.
> This also gets rid of any validation errors [1] related to them.
>
> [...]
Applied to v6.13-next/dts64, thanks!
[2/8] arm64: dts: mediatek: mt8173-evb: Drop regulator-compatible property
commit: a6d5983e40f5d5b219337569cdd269727f5a3e2e
[3/8] arm64: dts: mediatek: mt8173-elm: Drop regulator-compatible property
commit: 4b907b3ea5fba240808136cc5599d14b52230b39
[4/8] arm64: dts: mediatek: mt8192-asurada: Drop regulator-compatible property
commit: d1fb968551c8688652b8b817bb081fdc9c25cd48
[5/8] arm64: dts: mediatek: mt8195-cherry: Drop regulator-compatible property
commit: 4dbaa5d5def2c49e44efaa5e796c23d9b904be09
[6/8] arm64: dts: mediatek: mt8195-demo: Drop regulator-compatible property
commit: 2a8af9b95f504260a6d8200a11f0ae5c90e9f787
[7/8] arm64: dts: medaitek: mt8395-nio-12l: Drop regulator-compatible property
commit: ab60442f26b15ba69b210974722a851ed03188ff
[8/8] arm64: dts: mediatek: mt8395-genio-1200-evk: Drop regulator-compatible property
commit: b99bf07c2c8b3c85c1935ddca2a73bc686f8d847
Cheers,
Angelo
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: (subset) [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property
2024-12-11 5:24 [PATCH 0/8] arm64: dts: mediatek: Drop regulator-compatible property Chen-Yu Tsai
` (9 preceding siblings ...)
2024-12-12 10:04 ` (subset) " AngeloGioacchino Del Regno
@ 2024-12-12 12:51 ` Mark Brown
10 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2024-12-12 12:51 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Hsin-Hsiung Wang, Chen-Yu Tsai
Cc: devicetree, linux-mediatek, linux-arm-kernel, linux-kernel
On Wed, 11 Dec 2024 13:24:18 +0800, Chen-Yu Tsai wrote:
> This series drops usage of the long deprecated "regulator-compatible"
> property from MediaTek device tree files. The property was introduced
> in 2012, and then subsequently deprecated after two months. It was
> never carried over during the binding YAML conversion.
>
> Drop the property from the MT6315 regulator binding, and all MediaTek
> device tree files. IMO it should never have been used to begin with.
> This also gets rid of any validation errors [1] related to them.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/8] regulator: dt-bindings: mt6315: Drop regulator-compatible property
commit: 08242719a8af603db54a2a79234a8fe600680105
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 13+ messages in thread