From: "Rob Herring (Arm)" <robh@kernel.org>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: linux-kernel@vger.kernel.org,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
heiko@sntech.de, linux-rockchip@lists.infradead.org,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Simon Xue" <xxm@rock-chips.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
devicetree@vger.kernel.org,
"Shawn Lin" <shawn.lin@rock-chips.com>,
linux-pci@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>
Subject: Re: [PATCH v2 2/7] dt-bindings: PCI: dwc: rockchip: Add rk3576 support
Date: Fri, 20 Dec 2024 05:43:57 -0600 [thread overview]
Message-ID: <173469503748.2890446.9450914997693920466.robh@kernel.org> (raw)
In-Reply-To: <20241220101551.3505917-3-kever.yang@rock-chips.com>
On Fri, 20 Dec 2024 18:15:46 +0800, Kever Yang wrote:
> rk3576 is using dwc controller, but use msi interrupt instead of its,
> so the msi-map is not required, and need to add a new 'msi' interrupt name.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v2:
> - remove required 'msi-map'
> - add interrupt name 'msi'
>
> .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 1 +
> Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 +---
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: interrupt-names:5: 'msi' was expected
from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: interrupt-names:6: 'dma0' was expected
from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: interrupt-names:7: 'dma1' was expected
from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: interrupt-names:8: 'dma2' was expected
from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: Unevaluated properties are not allowed ('power-domains' was unexpected)
from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241220101551.3505917-3-kever.yang@rock-chips.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-12-20 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 10:15 [PATCH v2 0/7] Rockchip: add Rockchip rk3576 EVB1 board Kever Yang
2024-12-20 10:15 ` [PATCH v2 1/7] dts: arm64: rockchip: Add rk3576 naneng combphy nodes Kever Yang
2024-12-20 10:15 ` [PATCH v2 2/7] dt-bindings: PCI: dwc: rockchip: Add rk3576 support Kever Yang
2024-12-20 11:43 ` Rob Herring (Arm) [this message]
2024-12-22 6:39 ` Krzysztof Kozlowski
2024-12-20 10:15 ` [PATCH v2 3/7] dts: arm64: rockchip: Add rk3576 pcie nodes Kever Yang
2024-12-22 6:38 ` Krzysztof Kozlowski
2024-12-23 10:49 ` Kever Yang
2024-12-23 12:38 ` Heiko Stübner
2024-12-20 10:15 ` [PATCH v2 4/7] arm64: dts: rockchip: add usb related nodes for rk3576 Kever Yang
2024-12-20 10:15 ` [PATCH v2 5/7] dt-bindings: arm: rockchip: Sort for rk3568 evb Kever Yang
2024-12-20 15:08 ` Diederik de Haas
2024-12-20 10:15 ` [PATCH v2 6/7] dt-bindings: arm: rockchip: Add rk3576 evb1 board Kever Yang
2024-12-20 10:15 ` [PATCH v2 7/7] arm64: dts: " Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173469503748.2890446.9450914997693920466.robh@kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®