From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Luiz Sampaio <sampaio.ime@gmail.com>,
Herton Ronaldo Krzesinski <herton@canonical.com>,
Hin-Tak Leung <htl10@users.sourceforge.net>,
Larry Finger <larry.finger@lwfinger.net>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Luiz Sampaio <sampaio.ime@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value
Date: Fri, 21 Jan 2022 17:12:40 +0000 (UTC) [thread overview]
Message-ID: <1735835679.1273895.1642785160493@mail.yahoo.com> (raw)
In-Reply-To: <1735835679.1273895.1642785160493.ref@mail.yahoo.com>
> - if (brightness == LED_FULL) {
> + if (brightness == 255) {
> - if (brightness == LED_OFF) {
> + if (brightness == 0) {
NAKed. I haven't received the other 30 patches in this series so I don't know the full context, but I don't think replacing meaningful enum names with numerical values is an improvement. If the ENUMs are gone from a common include (and why is the ENUM removed, if drivers use them??), and the realtek driver still have such a functionality, it probably should be defined in one of the rtl818*.h as RTL818X_LED_FULL and RTL818X_LED_OFF .
My $0.02, based on this one only of the 31.
Regards,
Hin-Tak
next parent reply other threads:[~2022-01-21 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1735835679.1273895.1642785160493.ref@mail.yahoo.com>
2022-01-21 17:12 ` Hin-Tak Leung [this message]
2022-01-21 18:29 ` Larry Finger
2022-01-21 16:54 [PATCH 00/31] leds: start removing obsolete/useless enum Luiz Sampaio
2022-01-21 16:54 ` [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value Luiz Sampaio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1735835679.1273895.1642785160493@mail.yahoo.com \
--to=htl10@users.sourceforge.net \
--cc=davem@davemloft.net \
--cc=herton@canonical.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sampaio.ime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®