* Re: [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value [not found] <1735835679.1273895.1642785160493.ref@mail.yahoo.com> @ 2022-01-21 17:12 ` Hin-Tak Leung 2022-01-21 18:29 ` Larry Finger 0 siblings, 1 reply; 3+ messages in thread From: Hin-Tak Leung @ 2022-01-21 17:12 UTC (permalink / raw) To: Luiz Sampaio, Herton Ronaldo Krzesinski, Hin-Tak Leung, Larry Finger, Kalle Valo, David S. Miller, Jakub Kicinski Cc: linux-kernel, Luiz Sampaio, linux-wireless, netdev > - if (brightness == LED_FULL) { > + if (brightness == 255) { > - if (brightness == LED_OFF) { > + if (brightness == 0) { NAKed. I haven't received the other 30 patches in this series so I don't know the full context, but I don't think replacing meaningful enum names with numerical values is an improvement. If the ENUMs are gone from a common include (and why is the ENUM removed, if drivers use them??), and the realtek driver still have such a functionality, it probably should be defined in one of the rtl818*.h as RTL818X_LED_FULL and RTL818X_LED_OFF . My $0.02, based on this one only of the 31. Regards, Hin-Tak ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value 2022-01-21 17:12 ` [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value Hin-Tak Leung @ 2022-01-21 18:29 ` Larry Finger 0 siblings, 0 replies; 3+ messages in thread From: Larry Finger @ 2022-01-21 18:29 UTC (permalink / raw) To: htl10, Luiz Sampaio, Herton Ronaldo Krzesinski, Kalle Valo, David S. Miller, Jakub Kicinski Cc: linux-kernel, linux-wireless, netdev On 1/21/22 11:12, Hin-Tak Leung wrote: >> - if (brightness == LED_FULL) { >> + if (brightness == 255) { > >> - if (brightness == LED_OFF) { >> + if (brightness == 0) { > > NAKed. I haven't received the other 30 patches in this series so I don't know the full context, but I don't think replacing meaningful enum names with numerical values is an improvement. If the ENUMs are gone from a common include (and why is the ENUM removed, if drivers use them??), and the realtek driver still have such a functionality, it probably should be defined in one of the rtl818*.h as RTL818X_LED_FULL and RTL818X_LED_OFF . > > My $0.02, based on this one only of the 31. I agree. Substituting magic numbers for enum names should not be done. NACK. Larry ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 00/31] leds: start removing obsolete/useless enum
@ 2022-01-21 16:54 Luiz Sampaio
2022-01-21 16:54 ` [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value Luiz Sampaio
0 siblings, 1 reply; 3+ messages in thread
From: Luiz Sampaio @ 2022-01-21 16:54 UTC (permalink / raw)
Cc: linux-kernel, Luiz Sampaio
This series of patches aims to replace the enum led_brightness in
include/linux/leds.h with unsigned int, as requested in the TODO file in
the drivers/leds folder. The first step is to change the old definitions
LED_OFF, LED_ON, LED_HALF and LED_FULL with the values.
This was done using find/grep/sed and later I did a review of the patch
to check that everything was right. A compilation using allmodconfig was
done to test that nothing broke.
I have more patches coming that will replace all the enum led_brightness
with unsigned int, as the led class now has support for max_brightness.
Please help review this patch.
Best regards,
Signed-off-by: Luiz Sampaio <sampaio.ime@gmail.com>
Luiz Sampaio (31):
gpu: nouveau: nouveau_led: changing LED_FULL to actual value
hid: changing LED_* from enum led_brightness to actual value
hwmon: pmbus: changing LED_* from enum led_brightness to actual value
iio: light: cm3605: changing LED_* from enum led_brightness to actual
value
input: keyboard: changing LED_* from enum led_brightness to actual
value
input: misc: changing LED_* from enum led_brightness to actual value
input: touchscreen: changing LED_* from enum led_brightness to actual
value
leds: changing LED_* from enum led_brightness to actual value
macintosh: changing LED_* from enum led_brightness to actual value
media: radio: changing LED_* from enum led_brightness to actual value
media: rc: changing LED_* from enum led_brightness to actual value
media: v4l2-core: changing LED_* from enum led_brightness to actual
value
mmc: changing LED_* from enum led_brightness to actual value
net: wireless: ath: changing LED_* from enum led_brightness to actual
value
net: wireless: atmel: changing LED_* from enum led_brightness to
actual value
net: broadcom: changing LED_* from enum led_brightness to actual value
net: intersil: changing LED_* from enum led_brightness to actual value
net: wireless: ralink: changing LED_* from enum led_brightness to
actual value
net: realtek: changing LED_* from enum led_brightness to actual value
platform: x86: changing LED_* from enum led_brightness to actual value
power: supply: changing LED_* from enum led_brightness to actual value
tty: vt: changing LED_* from enum led_brightness to actual value
usb: core: changing LED_* from enum led_brightness to actual value
video: backlight: changing LED_* from enum led_brightness to actual
value
include: linux: leds: changing LED_* from enum led_brightness to
actual value
net: bluetooth: changing LED_* from enum led_brightness to actual
value
net: mac80211 : changing LED_* from enum led_brightness to actual
value
net: netfilter: changing LED_* from enum led_brightness to actual
value
net: rfkill: changing LED_* from enum led_brightness to actual value
sound: core: changing LED_* from enum led_brightness to actual value
sound: soc: sof: changing LED_* from enum led_brightness to actual
value
drivers/gpu/drm/nouveau/nouveau_led.c | 4 +--
drivers/hid/hid-bigbenff.c | 10 +++----
drivers/hid/hid-elan.c | 2 +-
drivers/hid/hid-lenovo.c | 2 +-
drivers/hid/hid-lg4ff.c | 10 +++----
drivers/hid/hid-picolcd_leds.c | 6 ++--
drivers/hid/hid-playstation.c | 2 +-
drivers/hid/hid-sony.c | 4 +--
drivers/hid/hid-steelseries.c | 14 ++++-----
drivers/hid/hid-u2fzero.c | 4 +--
drivers/hid/hid-wiimote-modules.c | 4 +--
drivers/hid/wacom_sys.c | 16 +++++-----
drivers/hid/wacom_wac.c | 2 +-
drivers/hwmon/pmbus/ibm-cffps.c | 8 ++---
drivers/iio/light/cm3605.c | 10 +++----
drivers/input/keyboard/cap11xx.c | 2 +-
drivers/input/keyboard/qt2160.c | 6 ++--
drivers/input/keyboard/tm2-touchkey.c | 12 ++++----
drivers/input/misc/apanel.c | 4 +--
drivers/input/misc/ims-pcu.c | 2 +-
drivers/input/misc/wistron_btns.c | 8 ++---
drivers/input/touchscreen/stmfts.c | 4 +--
drivers/leds/blink/leds-lgm-sso.c | 8 ++---
drivers/leds/flash/leds-ktd2692.c | 4 +--
drivers/leds/flash/leds-lm3601x.c | 10 +++----
drivers/leds/flash/leds-mt6360.c | 10 +++----
drivers/leds/flash/leds-rt4505.c | 8 ++---
drivers/leds/flash/leds-rt8515.c | 4 +--
drivers/leds/flash/leds-sgm3140.c | 4 +--
drivers/leds/led-class.c | 6 ++--
drivers/leds/led-core.c | 8 ++---
drivers/leds/led-triggers.c | 4 +--
drivers/leds/leds-adp5520.c | 2 +-
drivers/leds/leds-an30259a.c | 8 ++---
drivers/leds/leds-apu.c | 6 ++--
drivers/leds/leds-ariel.c | 8 ++---
drivers/leds/leds-asic3.c | 2 +-
drivers/leds/leds-aw2013.c | 6 ++--
drivers/leds/leds-bcm6328.c | 14 ++++-----
drivers/leds/leds-bcm6358.c | 14 ++++-----
drivers/leds/leds-bd2802.c | 14 ++++-----
drivers/leds/leds-clevo-mail.c | 6 ++--
drivers/leds/leds-cobalt-qube.c | 2 +-
drivers/leds/leds-cpcap.c | 10 +++----
drivers/leds/leds-da903x.c | 4 +--
drivers/leds/leds-da9052.c | 4 +--
drivers/leds/leds-dac124s085.c | 2 +-
drivers/leds/leds-el15203000.c | 4 +--
drivers/leds/leds-gpio.c | 4 +--
drivers/leds/leds-is31fl319x.c | 2 +-
drivers/leds/leds-lm3530.c | 4 +--
drivers/leds/leds-lm3532.c | 8 ++---
drivers/leds/leds-lm3533.c | 4 +--
drivers/leds/leds-lm3692x.c | 2 +-
drivers/leds/leds-lm3697.c | 6 ++--
drivers/leds/leds-lp3952.c | 4 +--
drivers/leds/leds-lt3593.c | 2 +-
drivers/leds/leds-max77650.c | 4 +--
drivers/leds/leds-menf21bmc.c | 2 +-
drivers/leds/leds-mlxcpld.c | 22 +++++++-------
drivers/leds/leds-mlxreg.c | 10 +++----
drivers/leds/leds-mt6323.c | 2 +-
drivers/leds/leds-netxbig.c | 4 +--
drivers/leds/leds-nic78bx.c | 2 +-
drivers/leds/leds-ns2.c | 4 +--
drivers/leds/leds-ot200.c | 2 +-
drivers/leds/leds-pca9532.c | 6 ++--
drivers/leds/leds-pca955x.c | 30 +++++++++----------
drivers/leds/leds-pca963x.c | 4 +--
drivers/leds/leds-pm8058.c | 8 ++---
drivers/leds/leds-powernv.c | 12 ++++----
drivers/leds/leds-pwm.c | 2 +-
drivers/leds/leds-rb532.c | 2 +-
drivers/leds/leds-regulator.c | 2 +-
drivers/leds/leds-sc27xx-bltc.c | 6 ++--
drivers/leds/leds-spi-byte.c | 2 +-
drivers/leds/leds-ss4200.c | 12 ++++----
drivers/leds/leds-sunfire.c | 2 +-
drivers/leds/leds-syscon.c | 2 +-
drivers/leds/leds-tca6507.c | 8 ++---
drivers/leds/leds-wm831x-status.c | 8 ++---
drivers/leds/leds-wm8350.c | 8 ++---
drivers/leds/simple/simatic-ipc-leds.c | 10 +++----
drivers/leds/trigger/ledtrig-activity.c | 2 +-
drivers/leds/trigger/ledtrig-backlight.c | 4 +--
drivers/leds/trigger/ledtrig-camera.c | 4 +--
drivers/leds/trigger/ledtrig-cpu.c | 4 +--
drivers/leds/trigger/ledtrig-gpio.c | 4 +--
drivers/leds/trigger/ledtrig-heartbeat.c | 4 +--
drivers/leds/trigger/ledtrig-netdev.c | 6 ++--
drivers/leds/trigger/ledtrig-oneshot.c | 6 ++--
drivers/leds/trigger/ledtrig-panic.c | 2 +-
drivers/leds/trigger/ledtrig-pattern.c | 2 +-
drivers/leds/trigger/ledtrig-timer.c | 2 +-
drivers/leds/trigger/ledtrig-transient.c | 6 ++--
drivers/leds/trigger/ledtrig-tty.c | 4 +--
drivers/macintosh/via-pmu-led.c | 2 +-
drivers/media/radio/radio-shark.c | 6 ++--
drivers/media/radio/radio-shark2.c | 4 +--
drivers/media/rc/rc-main.c | 4 +--
drivers/media/rc/redrat3.c | 4 +--
drivers/media/rc/ttusbir.c | 4 +--
drivers/media/rc/winbond-cir.c | 6 ++--
.../media/v4l2-core/v4l2-flash-led-class.c | 4 +--
drivers/mmc/core/core.c | 4 +--
drivers/mmc/host/rtsx_usb_sdmmc.c | 4 +--
drivers/mmc/host/sdhci.c | 4 +--
drivers/net/wireless/ath/ath5k/led.c | 2 +-
drivers/net/wireless/ath/ath9k/gpio.c | 4 +--
drivers/net/wireless/ath/ath9k/htc_drv_gpio.c | 4 +--
drivers/net/wireless/atmel/at76c50x-usb.c | 4 +--
drivers/net/wireless/broadcom/b43/leds.c | 2 +-
.../net/wireless/broadcom/b43legacy/leds.c | 2 +-
drivers/net/wireless/intersil/p54/led.c | 2 +-
.../net/wireless/ralink/rt2x00/rt2400pci.c | 2 +-
.../net/wireless/ralink/rt2x00/rt2500pci.c | 2 +-
.../net/wireless/ralink/rt2x00/rt2500usb.c | 2 +-
.../net/wireless/ralink/rt2x00/rt2800lib.c | 4 +--
.../net/wireless/ralink/rt2x00/rt2x00leds.c | 16 +++++-----
drivers/net/wireless/ralink/rt2x00/rt61pci.c | 4 +--
drivers/net/wireless/ralink/rt2x00/rt73usb.c | 4 +--
.../wireless/realtek/rtl818x/rtl8187/leds.c | 4 +--
drivers/platform/x86/acer-wmi.c | 6 ++--
drivers/platform/x86/asus-wireless.c | 6 ++--
drivers/platform/x86/dell/dell-laptop.c | 2 +-
drivers/platform/x86/dell/dell-wmi-led.c | 4 +--
drivers/platform/x86/fujitsu-laptop.c | 28 ++++++++---------
drivers/platform/x86/lg-laptop.c | 18 +++++------
drivers/platform/x86/system76_acpi.c | 4 +--
drivers/platform/x86/thinkpad_acpi.c | 14 ++++-----
drivers/platform/x86/topstar-laptop.c | 4 +--
drivers/platform/x86/toshiba_acpi.c | 24 +++++++--------
drivers/power/supply/power_supply_leds.c | 26 ++++++++--------
drivers/tty/vt/keyboard.c | 4 +--
drivers/usb/core/ledtrig-usbport.c | 6 ++--
drivers/video/backlight/adp8860_bl.c | 4 +--
drivers/video/backlight/adp8870_bl.c | 4 +--
drivers/video/backlight/led_bl.c | 2 +-
include/linux/leds.h | 2 +-
net/bluetooth/leds.c | 6 ++--
net/mac80211/led.c | 10 +++----
net/netfilter/xt_LED.c | 6 ++--
net/rfkill/core.c | 8 ++---
sound/core/control_led.c | 2 +-
sound/soc/sof/control.c | 4 +--
145 files changed, 434 insertions(+), 434 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value 2022-01-21 16:54 [PATCH 00/31] leds: start removing obsolete/useless enum Luiz Sampaio @ 2022-01-21 16:54 ` Luiz Sampaio 0 siblings, 0 replies; 3+ messages in thread From: Luiz Sampaio @ 2022-01-21 16:54 UTC (permalink / raw) To: Herton Ronaldo Krzesinski, Hin-Tak Leung, Larry Finger, Kalle Valo, David S. Miller, Jakub Kicinski Cc: linux-kernel, Luiz Sampaio, linux-wireless, netdev The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c index 49421d10e22b..6ddbdb5e3fa5 100644 --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c @@ -109,7 +109,7 @@ static void rtl8187_led_brightness_set(struct led_classdev *led_dev, return; priv = hw->priv; if (led->is_radio) { - if (brightness == LED_FULL) { + if (brightness == 255) { ieee80211_queue_delayed_work(hw, &priv->led_on, 0); radio_on = true; } else if (radio_on) { @@ -118,7 +118,7 @@ static void rtl8187_led_brightness_set(struct led_classdev *led_dev, ieee80211_queue_delayed_work(hw, &priv->led_off, 0); } } else if (radio_on) { - if (brightness == LED_OFF) { + if (brightness == 0) { ieee80211_queue_delayed_work(hw, &priv->led_off, 0); /* The LED is off for 1/20 sec - it just blinks. */ ieee80211_queue_delayed_work(hw, &priv->led_on, -- 2.34.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-21 18:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1735835679.1273895.1642785160493.ref@mail.yahoo.com>
2022-01-21 17:12 ` [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value Hin-Tak Leung
2022-01-21 18:29 ` Larry Finger
2022-01-21 16:54 [PATCH 00/31] leds: start removing obsolete/useless enum Luiz Sampaio
2022-01-21 16:54 ` [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value Luiz Sampaio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®