[PATCH] Bluetooth: btbcm: Fix NULL deref in btbcm_get_board_name()

[PATCH] Bluetooth: btbcm: Fix NULL deref in btbcm_get_board_name()

[Charles Han]

devm_kstrdup() can return a NULL pointer on failure,but this
returned value in btbcm_get_board_name() is not checked.
Add NULL check in btbcm_get_board_name(), to handle kernel NULL
pointer dereference error.

Fixes: f9183eaad915 ("Bluetooth: btbcm: Use devm_kstrdup()")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
 drivers/bluetooth/btbcm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index a1153ada74d2..d7f3ccf5f594 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -553,6 +553,9 @@ static const char *btbcm_get_board_name(struct device *dev)
 
 	/* get rid of any '/' in the compatible string */
 	board_type = devm_kstrdup(dev, tmp, GFP_KERNEL);
+	if (!board_type)
+		return -ENOMEM;
+
 	strreplace(board_type, '/', '-');
 
 	return board_type;
-- 
2.31.1

Re: [PATCH] Bluetooth: btbcm: Fix NULL deref in btbcm_get_board_name()

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 27 Dec 2024 17:20:46 +0800 you wrote:
> devm_kstrdup() can return a NULL pointer on failure,but this
> returned value in btbcm_get_board_name() is not checked.
> Add NULL check in btbcm_get_board_name(), to handle kernel NULL
> pointer dereference error.
> 
> Fixes: f9183eaad915 ("Bluetooth: btbcm: Use devm_kstrdup()")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> 
> [...]

Here is the summary with links:
  - Bluetooth: btbcm: Fix NULL deref in btbcm_get_board_name()
    https://git.kernel.org/bluetooth/bluetooth-next/c/52d2af107592

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html