From: "tip-bot2 for Yafang Shao" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Yafang Shao <laoar.shao@gmail.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
mkoutny@suse.com, Johannes Weiner <hannes@cmpxchg.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched, psi: Don't account irq time if sched_clock_irqtime is disabled
Date: Wed, 15 Jan 2025 09:17:13 -0000 [thread overview]
Message-ID: <173693263378.31546.928096545861627460.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250103022409.2544-4-laoar.shao@gmail.com>
The following commit has been merged into the sched/core branch of tip:
Commit-ID: a6fd16148fdd7e9da143037106956a3447c247a8
Gitweb: https://git.kernel.org/tip/a6fd16148fdd7e9da143037106956a3447c247a8
Author: Yafang Shao <laoar.shao@gmail.com>
AuthorDate: Fri, 03 Jan 2025 10:24:08 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 13 Jan 2025 14:10:26 +01:00
sched, psi: Don't account irq time if sched_clock_irqtime is disabled
sched_clock_irqtime may be disabled due to the clock source. When disabled,
irq_time_read() won't change over time, so there is nothing to account. We
can save iterating the whole hierarchy on every tick and context switch.
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Michal Koutný <mkoutny@suse.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Link: https://lore.kernel.org/r/20250103022409.2544-4-laoar.shao@gmail.com
---
kernel/sched/psi.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 84dad15..bb56805 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -998,7 +998,7 @@ void psi_account_irqtime(struct rq *rq, struct task_struct *curr, struct task_st
s64 delta;
u64 irq;
- if (static_branch_likely(&psi_disabled))
+ if (static_branch_likely(&psi_disabled) || !irqtime_enabled())
return;
if (!curr->pid)
@@ -1240,6 +1240,11 @@ int psi_show(struct seq_file *m, struct psi_group *group, enum psi_res res)
if (static_branch_likely(&psi_disabled))
return -EOPNOTSUPP;
+#ifdef CONFIG_IRQ_TIME_ACCOUNTING
+ if (!irqtime_enabled() && res == PSI_IRQ)
+ return -EOPNOTSUPP;
+#endif
+
/* Update averages before reporting them */
mutex_lock(&group->avgs_lock);
now = sched_clock();
next prev parent reply other threads:[~2025-01-15 9:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 2:24 [PATCH v8 resend 0/4] sched: Fix missing irq time when CONFIG_IRQ_TIME_ACCOUNTING is enabled Yafang Shao
2025-01-03 2:24 ` [PATCH v8 1/4] sched: Define sched_clock_irqtime as static key Yafang Shao
2025-01-03 13:32 ` Vincent Guittot
2025-01-15 9:17 ` [tip: sched/core] " tip-bot2 for Yafang Shao
2025-01-03 2:24 ` [PATCH v8 2/4] sched: Don't account irq time if sched_clock_irqtime is disabled Yafang Shao
2025-01-03 13:32 ` Vincent Guittot
2025-01-15 9:17 ` [tip: sched/core] " tip-bot2 for Yafang Shao
2025-01-03 2:24 ` [PATCH v8 3/4] sched, psi: " Yafang Shao
2025-01-15 9:17 ` tip-bot2 for Yafang Shao [this message]
2025-01-03 2:24 ` [PATCH v8 4/4] sched: Fix cgroup irq time for CONFIG_IRQ_TIME_ACCOUNTING Yafang Shao
2025-01-09 10:46 ` Michal Koutný
2025-01-09 13:46 ` Yafang Shao
2025-01-14 15:48 ` Michal Koutný
2025-01-15 2:58 ` Yafang Shao
2025-01-10 3:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173693263378.31546.928096545861627460.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®