mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH ethtool] netlink: settings: Fix PHYAD printing
@ 2025-01-17 22:50 Florian Fainelli
  2025-01-20 11:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2025-01-17 22:50 UTC (permalink / raw)
  To: netdev
  Cc: f.pfitzner, Florian Fainelli, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Simon Horman, Edward Cree,
	Andrew Lunn, Maxime Chevallier, Danielle Ratson, Kory Maincent,
	open list

The PHY address was printed in hexadecimal rather than decimal as it
used to be and is expected.

Fixes: bd1341cd2146 ("add json support for base command")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 netlink/settings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/settings.c b/netlink/settings.c
index b9b3ba9ed836..300825839e4e 100644
--- a/netlink/settings.c
+++ b/netlink/settings.c
@@ -605,7 +605,7 @@ int linkinfo_reply_cb(const struct nlmsghdr *nlhdr, void *data)
 		uint8_t val = mnl_attr_get_u8(tb[ETHTOOL_A_LINKINFO_PHYADDR]);
 
 		print_banner(nlctx);
-		print_uint(PRINT_ANY, "phyad", "\tPHYAD: %x\n", val);
+		print_uint(PRINT_ANY, "phyad", "\tPHYAD: %u\n", val);
 	}
 	if (tb[ETHTOOL_A_LINKINFO_TRANSCEIVER]) {
 		uint8_t val;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH ethtool] netlink: settings: Fix PHYAD printing
  2025-01-17 22:50 [PATCH ethtool] netlink: settings: Fix PHYAD printing Florian Fainelli
@ 2025-01-20 11:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-01-20 11:50 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: netdev, f.pfitzner, davem, edumazet, kuba, pabeni, horms,
	ecree.xilinx, andrew, maxime.chevallier, danieller,
	kory.maincent, linux-kernel

Hello:

This patch was applied to ethtool/ethtool.git (master)
by Michal Kubecek <mkubecek@suse.cz>:

On Fri, 17 Jan 2025 14:50:19 -0800 you wrote:
> The PHY address was printed in hexadecimal rather than decimal as it
> used to be and is expected.
> 
> Fixes: bd1341cd2146 ("add json support for base command")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  netlink/settings.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [ethtool] netlink: settings: Fix PHYAD printing
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=c6ea3bc04c73

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-20 11:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-17 22:50 [PATCH ethtool] netlink: settings: Fix PHYAD printing Florian Fainelli
2025-01-20 11:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome