[PATCH v2 net-next] sysctl net: Remove macro checks for CONFIG_SYSCTL

[PATCH v2 net-next] sysctl net: Remove macro checks for CONFIG_SYSCTL

[Denis Kirjanov]

Since dccp and llc makefiles already check sysctl code
compilation with xxx-$(CONFIG_SYSCTL)
we can drop the checks

Signed-off-by: Denis Kirjanov <kirjanov@gmail.com>
---
changelog:
v2: fix the spelling mistake "witn" -> "with" 

 net/dccp/sysctl.c        | 4 ----
 net/llc/sysctl_net_llc.c | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c
index 3fc474d6e57d..b15845fd6300 100644
--- a/net/dccp/sysctl.c
+++ b/net/dccp/sysctl.c
@@ -11,10 +11,6 @@
 #include "dccp.h"
 #include "feat.h"
 
-#ifndef CONFIG_SYSCTL
-#error This file should not be compiled without CONFIG_SYSCTL defined
-#endif
-
 /* Boundary values */
 static int		u8_max   = 0xFF;
 static unsigned long	seqw_min = DCCPF_SEQ_WMIN,
diff --git a/net/llc/sysctl_net_llc.c b/net/llc/sysctl_net_llc.c
index 72e101135f8c..c8d88e2508fc 100644
--- a/net/llc/sysctl_net_llc.c
+++ b/net/llc/sysctl_net_llc.c
@@ -11,10 +11,6 @@
 #include <net/net_namespace.h>
 #include <net/llc.h>
 
-#ifndef CONFIG_SYSCTL
-#error This file should not be compiled without CONFIG_SYSCTL defined
-#endif
-
 static struct ctl_table llc2_timeout_table[] = {
 	{
 		.procname	= "ack",
-- 
2.43.0

Re: [PATCH v2 net-next] sysctl net: Remove macro checks for CONFIG_SYSCTL

[Jason Xing]

On Sun, Jan 19, 2025 at 9:44 PM Denis Kirjanov <kirjanov@gmail.com> wrote:
>
> Since dccp and llc makefiles already check sysctl code
> compilation with xxx-$(CONFIG_SYSCTL)
> we can drop the checks
>
> Signed-off-by: Denis Kirjanov <kirjanov@gmail.com>
> ---
> changelog:
> v2: fix the spelling mistake "witn" -> "with"
>
>  net/dccp/sysctl.c        | 4 ----
>  net/llc/sysctl_net_llc.c | 4 ----
>  2 files changed, 8 deletions(-)
>
> diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c
> index 3fc474d6e57d..b15845fd6300 100644
> --- a/net/dccp/sysctl.c
> +++ b/net/dccp/sysctl.c
> @@ -11,10 +11,6 @@
>  #include "dccp.h"
>  #include "feat.h"
>
> -#ifndef CONFIG_SYSCTL
> -#error This file should not be compiled without CONFIG_SYSCTL defined
> -#endif
> -

I'd like to know if you're still using DCCP since as far as I know it
will soon be deprecated... If not, the whole code will be removed.

Please take a look at the commit:
commit b144fcaf46d43b1471ad6e4de66235b8cebb3c87
Author: Kuniyuki Iwashima <kuniyu@amazon.com>
Date:   Wed Jun 14 12:47:05 2023 -0700

    dccp: Print deprecation notice.

    DCCP was marked as Orphan in the MAINTAINERS entry 2 years ago in commit
    054c4610bd05 ("MAINTAINERS: dccp: move Gerrit Renker to CREDITS").  It says
    we haven't heard from the maintainer for five years, so DCCP is not well
    maintained for 7 years now.

    Recently DCCP only receives updates for bugs, and major distros disable it
    by default.

    Removing DCCP would allow for better organisation of TCP fields to reduce
    the number of cache lines hit in the fast path.

    Let's add a deprecation notice when DCCP socket is created and schedule its
    removal to 2025.

Thanks,
Jason

Re: [PATCH v2 net-next] sysctl net: Remove macro checks for CONFIG_SYSCTL

[Denis Kirjanov]

> Please take a look at the commit:
> commit b144fcaf46d43b1471ad6e4de66235b8cebb3c87
> Author: Kuniyuki Iwashima <kuniyu@amazon.com>
> Date:   Wed Jun 14 12:47:05 2023 -0700
>
>     dccp: Print deprecation notice.
>
>     DCCP was marked as Orphan in the MAINTAINERS entry 2 years ago in commit
>     054c4610bd05 ("MAINTAINERS: dccp: move Gerrit Renker to CREDITS").  It says
>     we haven't heard from the maintainer for five years, so DCCP is not well
>     maintained for 7 years now.

Yes, but on another hand I see that it's evolving, like MP-DCCP and
the according ietf draft
here: https://datatracker.ietf.org/doc/draft-ietf-tsvwg-multipath-dccp/20/

Also there is a out-of-the tree repo available with the implementation
of mp-dccp:
https://github.com/telekom/mp-dccp

>
>     Recently DCCP only receives updates for bugs, and major distros disable it
>     by default.
>
>     Removing DCCP would allow for better organisation of TCP fields to reduce
>     the number of cache lines hit in the fast path.
>
>     Let's add a deprecation notice when DCCP socket is created and schedule its
>     removal to 2025.
>
> Thanks,
> Jason



-- 
Regards / Mit besten Grüßen,
Denis

Re: [PATCH v2 net-next] sysctl net: Remove macro checks for CONFIG_SYSCTL

[Jason Xing]

On Tue, Jan 21, 2025 at 5:17 PM Denis Kirjanov <kirjanov@gmail.com> wrote:
>
> > Please take a look at the commit:
> > commit b144fcaf46d43b1471ad6e4de66235b8cebb3c87
> > Author: Kuniyuki Iwashima <kuniyu@amazon.com>
> > Date:   Wed Jun 14 12:47:05 2023 -0700
> >
> >     dccp: Print deprecation notice.
> >
> >     DCCP was marked as Orphan in the MAINTAINERS entry 2 years ago in commit
> >     054c4610bd05 ("MAINTAINERS: dccp: move Gerrit Renker to CREDITS").  It says
> >     we haven't heard from the maintainer for five years, so DCCP is not well
> >     maintained for 7 years now.
>
> Yes, but on another hand I see that it's evolving, like MP-DCCP and
> the according ietf draft
> here: https://datatracker.ietf.org/doc/draft-ietf-tsvwg-multipath-dccp/20/
>
> Also there is a out-of-the tree repo available with the implementation
> of mp-dccp:
> https://github.com/telekom/mp-dccp

Interesting. Thanks for letting me know. It seems that we have to
remove the deprecation warning...

Thanks,
Jason

Re: [PATCH v2 net-next] sysctl net: Remove macro checks for CONFIG_SYSCTL

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 19 Jan 2025 16:42:53 +0300 you wrote:
> Since dccp and llc makefiles already check sysctl code
> compilation with xxx-$(CONFIG_SYSCTL)
> we can drop the checks
> 
> Signed-off-by: Denis Kirjanov <kirjanov@gmail.com>
> ---
> changelog:
> v2: fix the spelling mistake "witn" -> "with"
> 
> [...]

Here is the summary with links:
  - [v2,net-next] sysctl net: Remove macro checks for CONFIG_SYSCTL
    https://git.kernel.org/netdev/net-next/c/19d7750a06bb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html