mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Wenhua Lin <Wenhua.Lin@unisoc.com>
Cc: linux-kernel@vger.kernel.org,
	Xiongpeng Wu <xiongpeng.wu@unisoc.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Jiri Slaby <jirislaby@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Cixi Geng <cixi.geng@linux.dev>,
	devicetree@vger.kernel.org,
	 wenhua lin <wenhua.lin1994@gmail.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	 Zhirong Qiu <Zhirong.Qiu@unisoc.com>,
	Zhaochen Su <Zhaochen.Su@unisoc.com>,
	 Orson Zhai <orsonzhai@gmail.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Baolin Wang <baolin.wang@linux.alibaba.com>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH V3] dt-bindings: serial: Add a new compatible string for UMS9632
Date: Tue, 21 Jan 2025 07:44:24 -0600	[thread overview]
Message-ID: <173746706432.2493664.199542333902610683.robh@kernel.org> (raw)
In-Reply-To: <20250121115404.3612588-1-Wenhua.Lin@unisoc.com>


On Tue, 21 Jan 2025 19:54:04 +0800, Wenhua Lin wrote:
> The UART IP version of the ums9632 SoC project has been upgraded.
> UART controller registers have added valid bits to support new features.
> In order to distinguish different UART IP versions, we use sc9632-uart
> to represent upgraded IP and sc9836-uart to represent old IP.
> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
> V2->V3 changes:
> * Lists are ordered by fallback.
> * Combine two const items into enum.
> * Change commit message.
> 
> V1->V2 changes:
> * Modify the compatible string of enum.
> * Change commit message.
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/serial/sprd-uart.yaml:30:10: [warning] wrong indentation: expected 10 but found 9 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250121115404.3612588-1-Wenhua.Lin@unisoc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      reply	other threads:[~2025-01-21 13:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 11:54 Wenhua Lin
2025-01-21 13:44 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173746706432.2493664.199542333902610683.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Wenhua.Lin@unisoc.com \
    --cc=Zhaochen.Su@unisoc.com \
    --cc=Zhirong.Qiu@unisoc.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=cixi.geng@linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=wenhua.lin1994@gmail.com \
    --cc=xiongpeng.wu@unisoc.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®