[PATCH V3] dt-bindings: serial: Add a new compatible string for UMS9632

[PATCH V3] dt-bindings: serial: Add a new compatible string for UMS9632

[Wenhua Lin]

The UART IP version of the ums9632 SoC project has been upgraded.
UART controller registers have added valid bits to support new features.
In order to distinguish different UART IP versions, we use sc9632-uart
to represent upgraded IP and sc9836-uart to represent old IP.

Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
---
V2->V3 changes:
* Lists are ordered by fallback.
* Combine two const items into enum.
* Change commit message.

V1->V2 changes:
* Modify the compatible string of enum.
* Change commit message.
---
 Documentation/devicetree/bindings/serial/sprd-uart.yaml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
index a2a5056eba04..ad968fc2493b 100644
--- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
@@ -17,13 +17,18 @@ properties:
     oneOf:
       - items:
           - enum:
-              - sprd,sc9632-uart
+              - sprd,ums9632-uart
+          - const: sprd,sc9632-uart
+      - items:
+          - enum:
               - sprd,sc9860-uart
               - sprd,sc9863a-uart
               - sprd,ums512-uart
               - sprd,ums9620-uart
           - const: sprd,sc9836-uart
-      - const: sprd,sc9836-uart
+      - enum:
+         - sprd,sc9632-uart
+         - sprd,sc9836-uart
 
   reg:
     maxItems: 1
-- 
2.34.1

Re: [PATCH V3] dt-bindings: serial: Add a new compatible string for UMS9632

[Rob Herring (Arm)]

On Tue, 21 Jan 2025 19:54:04 +0800, Wenhua Lin wrote:
> The UART IP version of the ums9632 SoC project has been upgraded.
> UART controller registers have added valid bits to support new features.
> In order to distinguish different UART IP versions, we use sc9632-uart
> to represent upgraded IP and sc9836-uart to represent old IP.
> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
> V2->V3 changes:
> * Lists are ordered by fallback.
> * Combine two const items into enum.
> * Change commit message.
> 
> V1->V2 changes:
> * Modify the compatible string of enum.
> * Change commit message.
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/serial/sprd-uart.yaml:30:10: [warning] wrong indentation: expected 10 but found 9 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250121115404.3612588-1-Wenhua.Lin@unisoc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.