[PATCH v1] Bluetooth: btnxpuart: Fix glitches seen in dual A2DP streaming

[PATCH v1] Bluetooth: btnxpuart: Fix glitches seen in dual A2DP streaming

[Neeraj Sanjay Kale]

This fixes a regression caused by previous commit for fixing truncated
ACL data, which is causing some intermittent glitches when running two
A2DP streams.

serdev_device_write_buf() is the root cause of the glitch, which is
reverted, and the TX work will continue to write until the queue is empty.

This change fixes both issues. No A2DP streaming glitches or truncated
ACL data issue observed.

Fixes: 8023dd220425 ("Bluetooth: btnxpuart: Fix driver sending truncated data")
Fixes: 689ca16e5232 ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets")
Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
 drivers/bluetooth/btnxpuart.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 1230045d78a5..aa5ec1d444a9 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -1381,13 +1381,12 @@ static void btnxpuart_tx_work(struct work_struct *work)
 
 	while ((skb = nxp_dequeue(nxpdev))) {
 		len = serdev_device_write_buf(serdev, skb->data, skb->len);
-		serdev_device_wait_until_sent(serdev, 0);
 		hdev->stat.byte_tx += len;
 
 		skb_pull(skb, len);
 		if (skb->len > 0) {
 			skb_queue_head(&nxpdev->txq, skb);
-			break;
+			continue;
 		}
 
 		switch (hci_skb_pkt_type(skb)) {
-- 
2.25.1

Re: [PATCH v1] Bluetooth: btnxpuart: Fix glitches seen in dual A2DP streaming

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 20 Jan 2025 19:49:46 +0530 you wrote:
> This fixes a regression caused by previous commit for fixing truncated
> ACL data, which is causing some intermittent glitches when running two
> A2DP streams.
> 
> serdev_device_write_buf() is the root cause of the glitch, which is
> reverted, and the TX work will continue to write until the queue is empty.
> 
> [...]

Here is the summary with links:
  - [v1] Bluetooth: btnxpuart: Fix glitches seen in dual A2DP streaming
    https://git.kernel.org/bluetooth/bluetooth-next/c/52f17be9931e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html