* [PATCH v2] xfs: Add error handling for xfs_reflink_cancel_cow_range
@ 2025-01-24 3:45 Wentao Liang
2025-01-28 10:57 ` Carlos Maiolino
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2025-01-24 3:45 UTC (permalink / raw)
To: Carlos Maiolino, Darrick J . Wong
Cc: linux-xfs, linux-kernel, Wentao Liang, stable
In xfs_inactive(), xfs_reflink_cancel_cow_range() is called
without error handling, risking unnoticed failures and
inconsistent behavior compared to other parts of the code.
Fix this issue by adding an error handling for the
xfs_reflink_cancel_cow_range(), improving code robustness.
Fixes: 6231848c3aa5 ("xfs: check for cow blocks before trying to clear them")
Cc: <stable@vger.kernel.org> # v4.17
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
fs/xfs/xfs_inode.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index c8ad2606f928..1ff514b6c035 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1404,8 +1404,11 @@ xfs_inactive(
goto out;
/* Try to clean out the cow blocks if there are any. */
- if (xfs_inode_has_cow_data(ip))
- xfs_reflink_cancel_cow_range(ip, 0, NULLFILEOFF, true);
+ if (xfs_inode_has_cow_data(ip)) {
+ error = xfs_reflink_cancel_cow_range(ip, 0, NULLFILEOFF, true);
+ if (error)
+ goto out;
+ }
if (VFS_I(ip)->i_nlink != 0) {
/*
--
2.42.0.windows.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] xfs: Add error handling for xfs_reflink_cancel_cow_range
2025-01-24 3:45 [PATCH v2] xfs: Add error handling for xfs_reflink_cancel_cow_range Wentao Liang
@ 2025-01-28 10:57 ` Carlos Maiolino
0 siblings, 0 replies; 2+ messages in thread
From: Carlos Maiolino @ 2025-01-28 10:57 UTC (permalink / raw)
To: Darrick J . Wong, Wentao Liang; +Cc: linux-xfs, linux-kernel, stable
On Fri, 24 Jan 2025 11:45:09 +0800, Wentao Liang wrote:
> In xfs_inactive(), xfs_reflink_cancel_cow_range() is called
> without error handling, risking unnoticed failures and
> inconsistent behavior compared to other parts of the code.
>
> Fix this issue by adding an error handling for the
> xfs_reflink_cancel_cow_range(), improving code robustness.
>
> [...]
Applied to for-next, thanks!
[1/1] xfs: Add error handling for xfs_reflink_cancel_cow_range
commit: 26b63bee2f6e711c5a169997fd126fddcfb90848
Best regards,
--
Carlos Maiolino <cem@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-28 10:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-24 3:45 [PATCH v2] xfs: Add error handling for xfs_reflink_cancel_cow_range Wentao Liang
2025-01-28 10:57 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®