* [PATCH 0/2] dt-bindings: display: qcom,sm8[56]50-mdss: only document the mdp0-mem interconnect path
@ 2025-02-07 10:50 Neil Armstrong
2025-02-07 10:50 ` [PATCH 1/2] dt-bindings: display: qcom,sm8550-mdss: " Neil Armstrong
2025-02-07 10:50 ` [PATCH 2/2] dt-bindings: display: qcom,sm8650-mdss: " Neil Armstrong
0 siblings, 2 replies; 6+ messages in thread
From: Neil Armstrong @ 2025-02-07 10:50 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Simona Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Neil Armstrong
The mdp1-mem is not supported on the SM8550 & SM8650 SoCs, so only support a single
mdp0-mem interconnect entry.
This fixes the following errors:
display-subsystem@ae00000: interconnects: [[200, 3, 7, 32, 1, 7]] is too short
from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8650-mdss.yaml#
display-subsystem@ae00000: interconnect-names: ['mdp0-mem'] is too short
from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8650-mdss.yaml#
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Neil Armstrong (2):
dt-bindings: display: qcom,sm8550-mdss: only document the mdp0-mem interconnect path
dt-bindings: display: qcom,sm8650-mdss: only document the mdp0-mem interconnect path
Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 4 ++--
Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
---
base-commit: 808eb958781e4ebb6e9c0962af2e856767e20f45
change-id: 20250207-topic-sm8x50-mdss-interconnect-bindings-fix-dd975f223d05
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: display: qcom,sm8550-mdss: only document the mdp0-mem interconnect path
2025-02-07 10:50 [PATCH 0/2] dt-bindings: display: qcom,sm8[56]50-mdss: only document the mdp0-mem interconnect path Neil Armstrong
@ 2025-02-07 10:50 ` Neil Armstrong
2025-02-07 12:41 ` Rob Herring (Arm)
2025-02-07 10:50 ` [PATCH 2/2] dt-bindings: display: qcom,sm8650-mdss: " Neil Armstrong
1 sibling, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2025-02-07 10:50 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Simona Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Neil Armstrong
The mdp1-mem is not supported on the SM8550 SoCs, so only support a single
mdp0-mem interconnect entry.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
index 1ea50a2c7c8e9f420125ad30a80b4ebd05c9367a..bc95ea33682e494ee498b3b049c4966f010aa2df 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
@@ -30,10 +30,10 @@ properties:
maxItems: 1
interconnects:
- maxItems: 2
+ maxItems: 1
interconnect-names:
- maxItems: 2
+ maxItems: 1
patternProperties:
"^display-controller@[0-9a-f]+$":
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] dt-bindings: display: qcom,sm8650-mdss: only document the mdp0-mem interconnect path
2025-02-07 10:50 [PATCH 0/2] dt-bindings: display: qcom,sm8[56]50-mdss: only document the mdp0-mem interconnect path Neil Armstrong
2025-02-07 10:50 ` [PATCH 1/2] dt-bindings: display: qcom,sm8550-mdss: " Neil Armstrong
@ 2025-02-07 10:50 ` Neil Armstrong
2025-02-07 16:58 ` Dmitry Baryshkov
1 sibling, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2025-02-07 10:50 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Simona Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Neil Armstrong
The mdp1-mem is not supported on the SM8650 SoCs, so only support a single
mdp0-mem interconnect entry.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
index 24cece1e888bd35f169dc3764966685de4b6da1d..cee581513c519924712c7e0fc055099f886d0a99 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
@@ -29,10 +29,10 @@ properties:
maxItems: 1
interconnects:
- maxItems: 2
+ maxItems: 1
interconnect-names:
- maxItems: 2
+ maxItems: 1
patternProperties:
"^display-controller@[0-9a-f]+$":
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: qcom,sm8550-mdss: only document the mdp0-mem interconnect path
2025-02-07 10:50 ` [PATCH 1/2] dt-bindings: display: qcom,sm8550-mdss: " Neil Armstrong
@ 2025-02-07 12:41 ` Rob Herring (Arm)
2025-02-07 13:59 ` Neil Armstrong
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-02-07 12:41 UTC (permalink / raw)
To: Neil Armstrong
Cc: Simona Vetter, Rob Clark, Maarten Lankhorst, Abhinav Kumar,
devicetree, linux-arm-msm, Dmitry Baryshkov, Maxime Ripard,
Conor Dooley, dri-devel, freedreno, Marijn Suijten, David Airlie,
Sean Paul, Thomas Zimmermann, linux-kernel, Krzysztof Kozlowski
On Fri, 07 Feb 2025 11:50:37 +0100, Neil Armstrong wrote:
> The mdp1-mem is not supported on the SM8550 SoCs, so only support a single
> mdp0-mem interconnect entry.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.example.dtb: display-subsystem@ae00000: interconnects: [[4294967295, 3, 0, 4294967295, 13, 0], [4294967295, 0, 0, 4294967295, 1, 0]] is too long
from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8550-mdss.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.example.dtb: display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem'] is too long
from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8550-mdss.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207-topic-sm8x50-mdss-interconnect-bindings-fix-v1-1-852b1d6aee46@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: qcom,sm8550-mdss: only document the mdp0-mem interconnect path
2025-02-07 12:41 ` Rob Herring (Arm)
@ 2025-02-07 13:59 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2025-02-07 13:59 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Simona Vetter, Rob Clark, Maarten Lankhorst, Abhinav Kumar,
devicetree, linux-arm-msm, Dmitry Baryshkov, Maxime Ripard,
Conor Dooley, dri-devel, freedreno, Marijn Suijten, David Airlie,
Sean Paul, Thomas Zimmermann, linux-kernel, Krzysztof Kozlowski
On 07/02/2025 13:41, Rob Herring (Arm) wrote:
>
> On Fri, 07 Feb 2025 11:50:37 +0100, Neil Armstrong wrote:
>> The mdp1-mem is not supported on the SM8550 SoCs, so only support a single
>> mdp0-mem interconnect entry.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.example.dtb: display-subsystem@ae00000: interconnects: [[4294967295, 3, 0, 4294967295, 13, 0], [4294967295, 0, 0, 4294967295, 1, 0]] is too long
> from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8550-mdss.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.example.dtb: display-subsystem@ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem'] is too long
> from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8550-mdss.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207-topic-sm8x50-mdss-interconnect-bindings-fix-v1-1-852b1d6aee46@linaro.org
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Damn example, went too fast...
Thanks,
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] dt-bindings: display: qcom,sm8650-mdss: only document the mdp0-mem interconnect path
2025-02-07 10:50 ` [PATCH 2/2] dt-bindings: display: qcom,sm8650-mdss: " Neil Armstrong
@ 2025-02-07 16:58 ` Dmitry Baryshkov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2025-02-07 16:58 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, dri-devel, freedreno, devicetree,
linux-kernel
On Fri, 7 Feb 2025 at 12:50, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> The mdp1-mem is not supported on the SM8650 SoCs, so only support a single
> mdp0-mem interconnect entry.
No, please add cpu-cfg interconnect instead.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
> index 24cece1e888bd35f169dc3764966685de4b6da1d..cee581513c519924712c7e0fc055099f886d0a99 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml
> @@ -29,10 +29,10 @@ properties:
> maxItems: 1
>
> interconnects:
> - maxItems: 2
> + maxItems: 1
>
> interconnect-names:
> - maxItems: 2
> + maxItems: 1
>
> patternProperties:
> "^display-controller@[0-9a-f]+$":
>
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-02-07 16:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-07 10:50 [PATCH 0/2] dt-bindings: display: qcom,sm8[56]50-mdss: only document the mdp0-mem interconnect path Neil Armstrong
2025-02-07 10:50 ` [PATCH 1/2] dt-bindings: display: qcom,sm8550-mdss: " Neil Armstrong
2025-02-07 12:41 ` Rob Herring (Arm)
2025-02-07 13:59 ` Neil Armstrong
2025-02-07 10:50 ` [PATCH 2/2] dt-bindings: display: qcom,sm8650-mdss: " Neil Armstrong
2025-02-07 16:58 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®