From: Paul Mackerras <paulus@samba.org>
To: Andrew Morton <akpm@osdl.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, johnstul@us.ibm.com
Subject: Re: [PATCH] Provide an interface for getting the current tick length
Date: Thu, 16 Feb 2006 12:55:06 +1100 [thread overview]
Message-ID: <17395.56186.238204.312647@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20060215173545.43a7412d.akpm@osdl.org>
Andrew Morton writes:
> > + if ((time_adjust_step = time_adjust) != 0 ) {
>
> <mutters something about coding style>
Seems perfectly plain to me, but if you don't like it I can change it.
>
> > + /*
> > + * Limit the amount of the step to be in the range
> > + * -tickadj .. +tickadj
> > + */
> > + time_adjust_step = min(time_adjust_step, (long)tickadj);
> > + time_adjust_step = max(time_adjust_step, (long)-tickadj);
> > + }
> > + delta_nsec = tick_nsec + time_adjust_step * 1000;
>
> Is that going to overflow if sizeof(long) == 4?
No. time_adjust_step is in microseconds and is restricted to the
range -tickadj .. tickadj, and tickadj is between 1 and 10 (assuming
HZ >= 50). tick_nsec is around 1e9 / HZ. There's no way delta_nsec
could end up less than 0 or larger than around 20 million for any
reasonable HZ value (i.e. >= 50).
Paul.
next prev parent reply other threads:[~2006-02-16 1:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-16 1:17 Paul Mackerras
2006-02-16 1:35 ` Andrew Morton
2006-02-16 1:55 ` Paul Mackerras [this message]
2006-02-16 2:08 ` Andrew Morton
2006-02-16 2:54 ` Paul Mackerras
2006-02-16 3:11 ` Andrew Morton
2006-02-16 3:18 ` Paul Mackerras
2006-02-16 3:30 ` Linus Torvalds
2006-02-16 3:43 ` Paul Mackerras
2006-02-16 3:51 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17395.56186.238204.312647@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®