mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, johnstul@us.ibm.com
Subject: Re: [PATCH] Provide an interface for getting the current tick length
Date: Thu, 16 Feb 2006 14:43:07 +1100	[thread overview]
Message-ID: <17395.62667.675949.112899@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0602151926590.916@g5.osdl.org>

Linus Torvalds writes:

> And while at it, please make it much more readable by writing it as
> 
> 	time_adjust_step = time_adjust;
> 	if (time_adjust_step) {
> 		..
> 
> which is even less to type (no "!= 0", no extra parenthesis, just a 
> ";<nl><tab>", and you've saved a whopping three bytes of source code while 

... you've forgotten that now I've had to type "time_adjust_step"
twice. :P  Anyway, I don't mind changing it, if you think it's worth
pulling that little bit of code out into its own function.

Paul.

  reply	other threads:[~2006-02-16  3:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-16  1:17 Paul Mackerras
2006-02-16  1:35 ` Andrew Morton
2006-02-16  1:55   ` Paul Mackerras
2006-02-16  2:08     ` Andrew Morton
2006-02-16  2:54       ` Paul Mackerras
2006-02-16  3:11         ` Andrew Morton
2006-02-16  3:18           ` Paul Mackerras
2006-02-16  3:30         ` Linus Torvalds
2006-02-16  3:43           ` Paul Mackerras [this message]
2006-02-16  3:51             ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17395.62667.675949.112899@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=akpm@osdl.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®