mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()
@ 2025-01-28  6:56 oushixiong1025
  2025-02-10 15:16 ` Robert Foss
  2025-02-18  8:14 ` Robert Foss
  0 siblings, 2 replies; 3+ messages in thread
From: oushixiong1025 @ 2025-01-28  6:56 UTC (permalink / raw)
  To: Andrzej Hajda
  Cc: Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman,
	Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
	linux-kernel, Shixiong Ou

From: Shixiong Ou <oushixiong@kylinos.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_ioremap_resource().

Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index bfa88409a7ff..f6e4bdc05ba0 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1553,7 +1553,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
 {
 	struct platform_device *pdev = to_platform_device(dev);
 	struct analogix_dp_device *dp;
-	struct resource *res;
 	unsigned int irq_flags;
 	int ret;
 
@@ -1605,9 +1604,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
 		return ERR_CAST(dp->clock);
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
-	dp->reg_base = devm_ioremap_resource(&pdev->dev, res);
+	dp->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(dp->reg_base)) {
 		ret = PTR_ERR(dp->reg_base);
 		goto err_disable_clk;
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()
  2025-01-28  6:56 [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource() oushixiong1025
@ 2025-02-10 15:16 ` Robert Foss
  2025-02-18  8:14 ` Robert Foss
  1 sibling, 0 replies; 3+ messages in thread
From: Robert Foss @ 2025-02-10 15:16 UTC (permalink / raw)
  To: oushixiong1025
  Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
	Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
	linux-kernel, Shixiong Ou

On Tue, Jan 28, 2025 at 7:57 AM <oushixiong1025@163.com> wrote:
>
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource().
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index bfa88409a7ff..f6e4bdc05ba0 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1553,7 +1553,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
>  {
>         struct platform_device *pdev = to_platform_device(dev);
>         struct analogix_dp_device *dp;
> -       struct resource *res;
>         unsigned int irq_flags;
>         int ret;
>
> @@ -1605,9 +1604,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
>                 return ERR_CAST(dp->clock);
>         }
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -       dp->reg_base = devm_ioremap_resource(&pdev->dev, res);
> +       dp->reg_base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(dp->reg_base)) {
>                 ret = PTR_ERR(dp->reg_base);
>                 goto err_disable_clk;
> --
> 2.43.0
>

Reviewed-by: Robert Foss <rfoss@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()
  2025-01-28  6:56 [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource() oushixiong1025
  2025-02-10 15:16 ` Robert Foss
@ 2025-02-18  8:14 ` Robert Foss
  1 sibling, 0 replies; 3+ messages in thread
From: Robert Foss @ 2025-02-18  8:14 UTC (permalink / raw)
  To: Andrzej Hajda, oushixiong1025
  Cc: Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, dri-devel, linux-kernel,
	Shixiong Ou

On Tue, 28 Jan 2025 14:56:45 +0800, oushixiong1025@163.com wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource().
> 
> 

Applied, thanks!

[1/1] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()
      (no commit info)



Rob



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-18  8:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-28  6:56 [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource() oushixiong1025
2025-02-10 15:16 ` Robert Foss
2025-02-18  8:14 ` Robert Foss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®