* [PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header
@ 2025-02-12 17:04 Uwe Kleine-König
2025-02-20 14:38 ` (subset) " Lee Jones
2025-02-20 14:39 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2025-02-12 17:04 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel
The header doesn't make use of any symbols declared in <linux/pwm.h>.
There are tree files that #include <mfd/lp3943.h>. Two of them
(i.e. drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c) also don't
use any and the third (drivers/pwm/pwm-lp3943.c) has an explicit include
of <linux/pwm.h> itself.
So drop the unused include. The intended side effect is that
drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c stop importing the
"PWM" module namespace.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
include/linux/mfd/lp3943.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/mfd/lp3943.h b/include/linux/mfd/lp3943.h
index 020a339f96e8..402f01078fcc 100644
--- a/include/linux/mfd/lp3943.h
+++ b/include/linux/mfd/lp3943.h
@@ -11,7 +11,6 @@
#define __MFD_LP3943_H__
#include <linux/gpio.h>
-#include <linux/pwm.h>
#include <linux/regmap.h>
/* Registers */
base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3
--
2.47.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header
2025-02-12 17:04 [PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header Uwe Kleine-König
@ 2025-02-20 14:38 ` Lee Jones
2025-02-20 14:39 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2025-02-20 14:38 UTC (permalink / raw)
To: Lee Jones, Uwe Kleine-König; +Cc: linux-kernel
On Wed, 12 Feb 2025 18:04:03 +0100, Uwe Kleine-König wrote:
> The header doesn't make use of any symbols declared in <linux/pwm.h>.
> There are tree files that #include <mfd/lp3943.h>. Two of them
> (i.e. drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c) also don't
> use any and the third (drivers/pwm/pwm-lp3943.c) has an explicit include
> of <linux/pwm.h> itself.
>
> So drop the unused include. The intended side effect is that
> drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c stop importing the
> "PWM" module namespace.
>
> [...]
Applied, thanks!
[1/1] mfd: lp3943: Drop #include <linux/pwm.h> from header
commit: 3a7db8a6dee5a2c1858678ddf2d7d38128a9caf3
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header
2025-02-12 17:04 [PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header Uwe Kleine-König
2025-02-20 14:38 ` (subset) " Lee Jones
@ 2025-02-20 14:39 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2025-02-20 14:39 UTC (permalink / raw)
To: Lee Jones, Uwe Kleine-König; +Cc: linux-kernel
On Wed, 12 Feb 2025 18:04:03 +0100, Uwe Kleine-König wrote:
> The header doesn't make use of any symbols declared in <linux/pwm.h>.
> There are tree files that #include <mfd/lp3943.h>. Two of them
> (i.e. drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c) also don't
> use any and the third (drivers/pwm/pwm-lp3943.c) has an explicit include
> of <linux/pwm.h> itself.
>
> So drop the unused include. The intended side effect is that
> drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c stop importing the
> "PWM" module namespace.
>
> [...]
Applied, thanks!
[1/1] mfd: lp3943: Drop #include <linux/pwm.h> from header
commit: 5a917e808b56319d977b3062331293136ee1c34c
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-20 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-12 17:04 [PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header Uwe Kleine-König
2025-02-20 14:38 ` (subset) " Lee Jones
2025-02-20 14:39 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®