From: "Rob Herring (Arm)" <robh@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Peter Griffin <peter.griffin@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Will McVicker <willmcvicker@google.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: reset: syscon-reboot: support reset modes
Date: Wed, 26 Feb 2025 09:29:19 -0600 [thread overview]
Message-ID: <174058375994.2463209.9948592153423144239.robh@kernel.org> (raw)
In-Reply-To: <20250226-syscon-reboot-reset-mode-v1-1-91c1b62166ae@linaro.org>
On Wed, 26 Feb 2025 14:08:20 +0000, André Draszik wrote:
> Add support for specifying different register/mask/value combinations
> for different types of reset.
>
> In particular, update the binding to allow platforms to specify the
> following reset modes: soft, warm, cold, hard.
>
> Linux can perform different types of reset using its reboot= kernel
> command line argument, and some platforms also wish to reset
> differently based on whether or not e.g. contents of RAM should be
> retained across the reboot.
>
> The new properties match the existing properties, just prefixed with
> one of the reset modes mentioned above.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> .../bindings/power/reset/syscon-reboot.yaml | 74 ++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml:113:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml:115:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml:123:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml:125:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml:133:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml:135:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml:143:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml:145:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250226-syscon-reboot-reset-mode-v1-1-91c1b62166ae@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-02-26 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 14:08 [PATCH 0/2] support Linux reboot modes in syscon-reboot André Draszik
2025-02-26 14:08 ` [PATCH 1/2] dt-bindings: reset: syscon-reboot: support reset modes André Draszik
2025-02-26 15:29 ` Rob Herring (Arm) [this message]
2025-02-26 15:42 ` André Draszik
2025-02-26 16:20 ` André Draszik
2025-02-26 14:08 ` [PATCH 2/2] power: reset: syscon-reboot: support different " André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174058375994.2463209.9948592153423144239.robh@kernel.org \
--to=robh@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=sre@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®