mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Draszik" <andre.draszik@linaro.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	devicetree@vger.kernel.org,  linux-pm@vger.kernel.org,
	Peter Griffin <peter.griffin@linaro.org>,
	Conor Dooley	 <conor+dt@kernel.org>,
	Will McVicker <willmcvicker@google.com>,
	 linux-kernel@vger.kernel.org, kernel-team@android.com,
	Krzysztof Kozlowski	 <krzk+dt@kernel.org>,
	Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: reset: syscon-reboot: support reset modes
Date: Wed, 26 Feb 2025 16:20:27 +0000	[thread overview]
Message-ID: <9c013c053b8677ee6bb2a37bc48e90a25fa16d7e.camel@linaro.org> (raw)
In-Reply-To: <ba98106d00038a9b2a2bfb27dd49a5915cb93b81.camel@linaro.org>

On Wed, 2025-02-26 at 15:42 +0000, André Draszik wrote:
> On Wed, 2025-02-26 at 09:29 -0600, Rob Herring (Arm) wrote:
> > 
> > On Wed, 26 Feb 2025 14:08:20 +0000, André Draszik wrote:
> > > Add support for specifying different register/mask/value combinations
> > > for different types of reset.
> > > 
> > > In particular, update the binding to allow platforms to specify the
> > > following reset modes: soft, warm, cold, hard.
> > > 
> > > Linux can perform different types of reset using its reboot= kernel
> > > command line argument, and some platforms also wish to reset
> > > differently based on whether or not e.g. contents of RAM should be
> > > retained across the reboot.
> > > 
> > > The new properties match the existing properties, just prefixed with
> > > one of the reset modes mentioned above.
> > > 
> > > Signed-off-by: André Draszik <andre.draszik@linaro.org>
> > > ---
> > >  .../bindings/power/reset/syscon-reboot.yaml        | 74 ++++++++++++++++++++++
> > >  1 file changed, 74 insertions(+)
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> 
> oops, sorry - the script we usually run didn't cover this binding,

BTW, we did that, because it's easy to miss warnings due to
the amount of bindings and text scrolling past. Ideally make
would exit with != 0 in case of binding errors.

I can see in commit 3e95dfb315de ("dt-bindings: Don't error
out on yamllint and dt-doc-validate errors"), warnings are
never treated as errors.

Is that still relevant, can that commit be revert? Don't we
want the build to fail loudly on binding errors, so that people
don't even submit erroneous bindings in the first place?

Cheers,
Andre'


  reply	other threads:[~2025-02-26 16:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 14:08 [PATCH 0/2] support Linux reboot modes in syscon-reboot André Draszik
2025-02-26 14:08 ` [PATCH 1/2] dt-bindings: reset: syscon-reboot: support reset modes André Draszik
2025-02-26 15:29   ` Rob Herring (Arm)
2025-02-26 15:42     ` André Draszik
2025-02-26 16:20       ` André Draszik [this message]
2025-02-26 14:08 ` [PATCH 2/2] power: reset: syscon-reboot: support different " André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c013c053b8677ee6bb2a37bc48e90a25fa16d7e.camel@linaro.org \
    --to=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel-team@android.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®