[PATCH] platform/x86: thinkpad_acpi: Add battery quirk for ThinkPad X131e

[PATCH] platform/x86: thinkpad_acpi: Add battery quirk for ThinkPad X131e

[Mingcong Bai]

Based on the dmesg messages from the original reporter:

[    4.964073] ACPI: \_SB_.PCI0.LPCB.EC__.HKEY: BCTG evaluated but flagged as error
[    4.964083] thinkpad_acpi: Error probing battery 2

Lenovo ThinkPad X131e also needs this battery quirk.

Reported-by: Fan Yang <804284660@qq.com>
Tested-by: Fan Yang <804284660@qq.com>
Co-developed-by: Xi Ruoyao <xry111@xry111.site>
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
---
 drivers/platform/x86/thinkpad_acpi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 1fcb0f99695a7..64765c6939a50 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -9960,6 +9960,7 @@ static const struct tpacpi_quirk battery_quirk_table[] __initconst = {
 	 * Individual addressing is broken on models that expose the
 	 * primary battery as BAT1.
 	 */
+	TPACPI_Q_LNV('G', '8', true),       /* ThinkPad X131e */
 	TPACPI_Q_LNV('8', 'F', true),       /* Thinkpad X120e */
 	TPACPI_Q_LNV('J', '7', true),       /* B5400 */
 	TPACPI_Q_LNV('J', 'I', true),       /* Thinkpad 11e */
-- 
2.48.1

Re: [PATCH] platform/x86: thinkpad_acpi: Add battery quirk for ThinkPad X131e

[Mingcong Bai]

Hi all,

在 2025/2/22 00:48, Mingcong Bai 写道:
> Based on the dmesg messages from the original reporter:
> 
> [    4.964073] ACPI: \_SB_.PCI0.LPCB.EC__.HKEY: BCTG evaluated but flagged as error
> [    4.964083] thinkpad_acpi: Error probing battery 2
> 
> Lenovo ThinkPad X131e also needs this battery quirk.
> 
> Reported-by: Fan Yang <804284660@qq.com>
> Tested-by: Fan Yang <804284660@qq.com>
> Co-developed-by: Xi Ruoyao <xry111@xry111.site>
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
> ---
>   drivers/platform/x86/thinkpad_acpi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 1fcb0f99695a7..64765c6939a50 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -9960,6 +9960,7 @@ static const struct tpacpi_quirk battery_quirk_table[] __initconst = {
>   	 * Individual addressing is broken on models that expose the
>   	 * primary battery as BAT1.
>   	 */
> +	TPACPI_Q_LNV('G', '8', true),       /* ThinkPad X131e */
>   	TPACPI_Q_LNV('8', 'F', true),       /* Thinkpad X120e */
>   	TPACPI_Q_LNV('J', '7', true),       /* B5400 */
>   	TPACPI_Q_LNV('J', 'I', true),       /* Thinkpad 11e */

I forgot to include a Cc to stable. This issue dates back to as far as 
5.19 (the oldest version available in our distro repository).

Cc: stable@vger.kernel.org

Best Regards,
Mingcong Bai

Re: [PATCH] platform/x86: thinkpad_acpi: Add battery quirk for ThinkPad X131e

[Ilpo Järvinen]

On Sat, 22 Feb 2025 00:48:24 +0800, Mingcong Bai wrote:

> Based on the dmesg messages from the original reporter:
> 
> [    4.964073] ACPI: \_SB_.PCI0.LPCB.EC__.HKEY: BCTG evaluated but flagged as error
> [    4.964083] thinkpad_acpi: Error probing battery 2
> 
> Lenovo ThinkPad X131e also needs this battery quirk.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: Add battery quirk for ThinkPad X131e
      commit: d0d10eaedcb53740883d7e5d53c5e15c879b48fb

--
 i.