mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Josh Poimboeuf" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Brian Gerst <brgerst@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org
Subject: [tip: x86/asm] x86/asm: Make ASM_CALL_CONSTRAINT conditional on frame pointers
Date: Tue, 04 Mar 2025 10:36:24 -0000	[thread overview]
Message-ID: <174108458405.14745.4864877018394987266.tip-bot2@tip-bot2> (raw)

The following commit has been merged into the x86/asm branch of tip:

Commit-ID:     05844663b4fcf22bb3a1494615ae3f25852c9abc
Gitweb:        https://git.kernel.org/tip/05844663b4fcf22bb3a1494615ae3f25852c9abc
Author:        Josh Poimboeuf <jpoimboe@kernel.org>
AuthorDate:    Sun, 02 Mar 2025 17:21:03 -08:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 04 Mar 2025 11:21:40 +01:00

x86/asm: Make ASM_CALL_CONSTRAINT conditional on frame pointers

With frame pointers enabled, ASM_CALL_CONSTRAINT is used in an inline
asm statement with a call instruction to force the compiler to set up
the frame pointer before doing the call.

Without frame pointers, no such constraint is needed.  Make it
conditional on frame pointers.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
---
 arch/x86/include/asm/asm.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h
index 0d268e6..f1db9e8 100644
--- a/arch/x86/include/asm/asm.h
+++ b/arch/x86/include/asm/asm.h
@@ -232,7 +232,11 @@ register unsigned long current_stack_pointer asm(_ASM_SP);
  * gets set up by the containing function.  If you forget to do this, objtool
  * may print a "call without frame pointer save/setup" warning.
  */
+#ifdef CONFIG_UNWINDER_FRAME_POINTER
 #define ASM_CALL_CONSTRAINT "r" (__builtin_frame_address(0))
+#else
+#define ASM_CALL_CONSTRAINT
+#endif
 
 #endif /* __ASSEMBLY__ */
 

             reply	other threads:[~2025-03-04 10:36 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 10:36 tip-bot2 for Josh Poimboeuf [this message]
2025-03-07 22:04 ` H. Peter Anvin
2025-03-07 23:05   ` Ingo Molnar
2025-03-07 23:21     ` Josh Poimboeuf
2025-03-07 23:29       ` H. Peter Anvin
2025-03-08  1:38         ` Josh Poimboeuf
2025-03-08  8:15           ` David Laight
2025-03-08 17:06             ` Josh Poimboeuf
2025-03-10 14:49           ` H. Peter Anvin
2025-03-13 23:33             ` Josh Poimboeuf
  -- strict thread matches above, loose matches on Subject: below --
2025-03-03 11:02 tip-bot2 for Josh Poimboeuf
2025-03-03 18:28 ` Linus Torvalds
2025-03-03 22:37   ` Josh Poimboeuf
2025-03-04  8:33   ` Ingo Molnar
2025-03-04 17:51     ` Linus Torvalds
2025-03-04 18:01       ` Linus Torvalds
2025-03-04 18:21         ` Josh Poimboeuf
2025-03-04 18:48           ` Linus Torvalds
2025-03-04 18:57             ` Linus Torvalds
2025-03-04 19:56               ` Josh Poimboeuf
2025-03-04 20:09                 ` Josh Poimboeuf
2025-03-04 20:13                 ` Linus Torvalds
2025-03-04 20:25                   ` Linus Torvalds
2025-03-04 20:41                   ` Linus Torvalds
2025-03-04 22:45                     ` Josh Poimboeuf
2025-03-04 19:47             ` Josh Poimboeuf
2025-03-04 20:00               ` Josh Poimboeuf
2025-03-04 19:15           ` Ingo Molnar
2025-03-03 22:31 ` H. Peter Anvin
2025-03-03 22:45   ` Josh Poimboeuf
2025-03-03 22:47     ` Josh Poimboeuf
2025-03-04  0:35       ` H. Peter Anvin
2025-03-04  0:57         ` Andrew Cooper
2025-03-04  2:05           ` H. Peter Anvin
2025-03-04 17:45             ` Josh Poimboeuf
2025-03-04 15:35         ` Uros Bizjak
2025-03-04 22:08           ` H. Peter Anvin
2025-03-03 23:59     ` H. Peter Anvin
2025-03-04 15:28       ` Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174108458405.14745.4864877018394987266.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=brgerst@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®