* [PATCH 2/2] platform/x86: dell-uart-backlight: Make dell_uart_bl_serdev_driver static
2025-03-04 16:06 [PATCH 1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static Ilpo Järvinen
@ 2025-03-04 16:06 ` Ilpo Järvinen
2025-03-04 17:22 ` Mario Limonciello
2025-03-05 11:22 ` Hans de Goede
2025-03-04 17:21 ` [PATCH 1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static Mario Limonciello
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: Ilpo Järvinen @ 2025-03-04 16:06 UTC (permalink / raw)
To: Hans de Goede, Ilpo Järvinen, platform-driver-x86, linux-kernel
Sparse reports:
dell-uart-backlight.c:328:29: warning: symbol
'dell_uart_bl_serdev_driver' was not declared. Should it be static?
Fix it by making the symbol static.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/platform/x86/dell/dell-uart-backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/dell/dell-uart-backlight.c b/drivers/platform/x86/dell/dell-uart-backlight.c
index 50002ef13d5d..8f868f845350 100644
--- a/drivers/platform/x86/dell/dell-uart-backlight.c
+++ b/drivers/platform/x86/dell/dell-uart-backlight.c
@@ -325,7 +325,7 @@ static int dell_uart_bl_serdev_probe(struct serdev_device *serdev)
return PTR_ERR_OR_ZERO(dell_bl->bl);
}
-struct serdev_device_driver dell_uart_bl_serdev_driver = {
+static struct serdev_device_driver dell_uart_bl_serdev_driver = {
.probe = dell_uart_bl_serdev_probe,
.driver = {
.name = KBUILD_MODNAME,
--
2.39.5
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] platform/x86: dell-uart-backlight: Make dell_uart_bl_serdev_driver static
2025-03-04 16:06 ` [PATCH 2/2] platform/x86: dell-uart-backlight: Make dell_uart_bl_serdev_driver static Ilpo Järvinen
@ 2025-03-04 17:22 ` Mario Limonciello
2025-03-05 11:22 ` Hans de Goede
1 sibling, 0 replies; 7+ messages in thread
From: Mario Limonciello @ 2025-03-04 17:22 UTC (permalink / raw)
To: Ilpo Järvinen, Hans de Goede, platform-driver-x86, linux-kernel
On 3/4/2025 10:06, Ilpo Järvinen wrote:
> Sparse reports:
>
> dell-uart-backlight.c:328:29: warning: symbol
> 'dell_uart_bl_serdev_driver' was not declared. Should it be static?
>
> Fix it by making the symbol static.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fixes: 484bae9e4d6ac ("platform/x86: Add new Dell UART backlight driver")
Reviewed-by: Mario Limonciello <maroi.limonciello@amd.com>
> ---
> drivers/platform/x86/dell/dell-uart-backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell/dell-uart-backlight.c b/drivers/platform/x86/dell/dell-uart-backlight.c
> index 50002ef13d5d..8f868f845350 100644
> --- a/drivers/platform/x86/dell/dell-uart-backlight.c
> +++ b/drivers/platform/x86/dell/dell-uart-backlight.c
> @@ -325,7 +325,7 @@ static int dell_uart_bl_serdev_probe(struct serdev_device *serdev)
> return PTR_ERR_OR_ZERO(dell_bl->bl);
> }
>
> -struct serdev_device_driver dell_uart_bl_serdev_driver = {
> +static struct serdev_device_driver dell_uart_bl_serdev_driver = {
> .probe = dell_uart_bl_serdev_probe,
> .driver = {
> .name = KBUILD_MODNAME,
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] platform/x86: dell-uart-backlight: Make dell_uart_bl_serdev_driver static
2025-03-04 16:06 ` [PATCH 2/2] platform/x86: dell-uart-backlight: Make dell_uart_bl_serdev_driver static Ilpo Järvinen
2025-03-04 17:22 ` Mario Limonciello
@ 2025-03-05 11:22 ` Hans de Goede
1 sibling, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2025-03-05 11:22 UTC (permalink / raw)
To: Ilpo Järvinen, platform-driver-x86, linux-kernel
Hi Ilpo,
On 4-Mar-25 5:06 PM, Ilpo Järvinen wrote:
> Sparse reports:
>
> dell-uart-backlight.c:328:29: warning: symbol
> 'dell_uart_bl_serdev_driver' was not declared. Should it be static?
>
> Fix it by making the symbol static.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/dell/dell-uart-backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell/dell-uart-backlight.c b/drivers/platform/x86/dell/dell-uart-backlight.c
> index 50002ef13d5d..8f868f845350 100644
> --- a/drivers/platform/x86/dell/dell-uart-backlight.c
> +++ b/drivers/platform/x86/dell/dell-uart-backlight.c
> @@ -325,7 +325,7 @@ static int dell_uart_bl_serdev_probe(struct serdev_device *serdev)
> return PTR_ERR_OR_ZERO(dell_bl->bl);
> }
>
> -struct serdev_device_driver dell_uart_bl_serdev_driver = {
> +static struct serdev_device_driver dell_uart_bl_serdev_driver = {
> .probe = dell_uart_bl_serdev_probe,
> .driver = {
> .name = KBUILD_MODNAME,
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static
2025-03-04 16:06 [PATCH 1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static Ilpo Järvinen
2025-03-04 16:06 ` [PATCH 2/2] platform/x86: dell-uart-backlight: Make dell_uart_bl_serdev_driver static Ilpo Järvinen
@ 2025-03-04 17:21 ` Mario Limonciello
2025-03-05 11:22 ` Hans de Goede
2025-03-05 13:09 ` Ilpo Järvinen
3 siblings, 0 replies; 7+ messages in thread
From: Mario Limonciello @ 2025-03-04 17:21 UTC (permalink / raw)
To: Ilpo Järvinen, Hans de Goede, platform-driver-x86, linux-kernel
On 3/4/2025 10:06, Ilpo Järvinen wrote:
> Sparse reports:
>
> lenovo-yoga-tab2-pro-1380-fastcharger.c:222:29: warning: symbol
> 'yt2_1380_fc_serdev_driver' was not declared. Should it be static?
>
> Fix that by making the symbol static.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fixes: b2ed33e8d486a ("platform/x86: Add
lenovo-yoga-tab2-pro-1380-fastcharger driver")
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c b/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c
> index a96b215cd2c5..25933cd018d1 100644
> --- a/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c
> +++ b/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c
> @@ -219,7 +219,7 @@ static int yt2_1380_fc_serdev_probe(struct serdev_device *serdev)
> return 0;
> }
>
> -struct serdev_device_driver yt2_1380_fc_serdev_driver = {
> +static struct serdev_device_driver yt2_1380_fc_serdev_driver = {
> .probe = yt2_1380_fc_serdev_probe,
> .driver = {
> .name = KBUILD_MODNAME,
>
> base-commit: 432c2adb9e2f84f81c4b218acb07a2cd3dce64a9
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static
2025-03-04 16:06 [PATCH 1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static Ilpo Järvinen
2025-03-04 16:06 ` [PATCH 2/2] platform/x86: dell-uart-backlight: Make dell_uart_bl_serdev_driver static Ilpo Järvinen
2025-03-04 17:21 ` [PATCH 1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static Mario Limonciello
@ 2025-03-05 11:22 ` Hans de Goede
2025-03-05 13:09 ` Ilpo Järvinen
3 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2025-03-05 11:22 UTC (permalink / raw)
To: Ilpo Järvinen, platform-driver-x86, linux-kernel
Hi Ilpo,
On 4-Mar-25 5:06 PM, Ilpo Järvinen wrote:
> Sparse reports:
>
> lenovo-yoga-tab2-pro-1380-fastcharger.c:222:29: warning: symbol
> 'yt2_1380_fc_serdev_driver' was not declared. Should it be static?
>
> Fix that by making the symbol static.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c b/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c
> index a96b215cd2c5..25933cd018d1 100644
> --- a/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c
> +++ b/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c
> @@ -219,7 +219,7 @@ static int yt2_1380_fc_serdev_probe(struct serdev_device *serdev)
> return 0;
> }
>
> -struct serdev_device_driver yt2_1380_fc_serdev_driver = {
> +static struct serdev_device_driver yt2_1380_fc_serdev_driver = {
> .probe = yt2_1380_fc_serdev_probe,
> .driver = {
> .name = KBUILD_MODNAME,
>
> base-commit: 432c2adb9e2f84f81c4b218acb07a2cd3dce64a9
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static
2025-03-04 16:06 [PATCH 1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static Ilpo Järvinen
` (2 preceding siblings ...)
2025-03-05 11:22 ` Hans de Goede
@ 2025-03-05 13:09 ` Ilpo Järvinen
3 siblings, 0 replies; 7+ messages in thread
From: Ilpo Järvinen @ 2025-03-05 13:09 UTC (permalink / raw)
To: Hans de Goede, platform-driver-x86, linux-kernel, Ilpo Järvinen
On Tue, 04 Mar 2025 18:06:38 +0200, Ilpo Järvinen wrote:
> Sparse reports:
>
> lenovo-yoga-tab2-pro-1380-fastcharger.c:222:29: warning: symbol
> 'yt2_1380_fc_serdev_driver' was not declared. Should it be static?
>
> Fix that by making the symbol static.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/2] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static
commit: 886ca11a0c70efe5627a18557062e8a44370d78f
[2/2] platform/x86: dell-uart-backlight: Make dell_uart_bl_serdev_driver static
commit: 4878e0b14c3e31a87ab147bd2dae443394cb5a2c
--
i.
^ permalink raw reply [flat|nested] 7+ messages in thread