[PATCH 0/2] ASoC: dmic: add regulator support

[PATCH 0/2] ASoC: dmic: add regulator support

[Olivier Moysan]

Digital microphones may be supplied by a regulator. Add regulator
support in dmic codec, to allow power management of the regulator
through the ASoC DAPM widgets.

Olivier Moysan (2):
  ASoC: dt-bindings: add regulator support to dmic codec
  ASoC: dmic: add regulator support

 .../devicetree/bindings/sound/dmic-codec.yaml |  3 +++
 sound/soc/codecs/dmic.c                       | 19 ++++++++++++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)


base-commit: 989180be7182f518e3cc7c8057c6c23ffd6ddf47
-- 
2.25.1

[PATCH 1/2] ASoC: dt-bindings: add regulator support to dmic codec

[Olivier Moysan]

Add optional vref-supply property to describe the regulator supplying
the digital microphones.

Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
 Documentation/devicetree/bindings/sound/dmic-codec.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/dmic-codec.yaml b/Documentation/devicetree/bindings/sound/dmic-codec.yaml
index 59ef0cf6b6e5..cc3c84dd4c26 100644
--- a/Documentation/devicetree/bindings/sound/dmic-codec.yaml
+++ b/Documentation/devicetree/bindings/sound/dmic-codec.yaml
@@ -19,6 +19,9 @@ properties:
   '#sound-dai-cells':
     const: 0
 
+  vref-supply:
+    description: Phandle to the digital microphone reference supply
+
   dmicen-gpios:
     description: GPIO specifier for DMIC to control start and stop
     maxItems: 1
-- 
2.25.1

Re: [PATCH 1/2] ASoC: dt-bindings: add regulator support to dmic codec

[Rob Herring (Arm)]

On Thu, 06 Mar 2025 18:18:39 +0100, Olivier Moysan wrote:
> Add optional vref-supply property to describe the regulator supplying
> the digital microphones.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
>  Documentation/devicetree/bindings/sound/dmic-codec.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH 2/2] ASoC: dmic: add regulator support

[Olivier Moysan]

Allow management of the regulator that may be used to supply the
digital microphone.

Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
 sound/soc/codecs/dmic.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c
index 0388f115470c..5d3c3f17c6d8 100644
--- a/sound/soc/codecs/dmic.c
+++ b/sound/soc/codecs/dmic.c
@@ -9,6 +9,7 @@
 #include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/platform_device.h>
+#include <linux/regulator/consumer.h>
 #include <linux/slab.h>
 #include <linux/module.h>
 #include <sound/core.h>
@@ -25,6 +26,7 @@ module_param(wakeup_delay, uint, 0644);
 
 struct dmic {
 	struct gpio_desc *gpio_en;
+	struct regulator *vref;
 	int wakeup_delay;
 	/* Delay after DMIC mode switch */
 	int modeswitch_delay;
@@ -55,22 +57,33 @@ static int dmic_aif_event(struct snd_soc_dapm_widget *w,
 			  struct snd_kcontrol *kcontrol, int event) {
 	struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
 	struct dmic *dmic = snd_soc_component_get_drvdata(component);
+	int ret = 0;
 
 	switch (event) {
 	case SND_SOC_DAPM_POST_PMU:
 		if (dmic->gpio_en)
 			gpiod_set_value_cansleep(dmic->gpio_en, 1);
 
+		if (dmic->vref) {
+			ret = regulator_enable(dmic->vref);
+			if (ret)
+				return ret;
+		}
+
 		if (dmic->wakeup_delay)
 			msleep(dmic->wakeup_delay);
 		break;
 	case SND_SOC_DAPM_POST_PMD:
 		if (dmic->gpio_en)
 			gpiod_set_value_cansleep(dmic->gpio_en, 0);
+
+		if (dmic->vref)
+			ret = regulator_disable(dmic->vref);
+
 		break;
 	}
 
-	return 0;
+	return ret;
 }
 
 static struct snd_soc_dai_driver dmic_dai = {
@@ -100,6 +113,10 @@ static int dmic_component_probe(struct snd_soc_component *component)
 	if (!dmic)
 		return -ENOMEM;
 
+	dmic->vref = devm_regulator_get_optional(component->dev, "vref");
+	if (IS_ERR(dmic->vref) && PTR_ERR(dmic->vref) != -ENODEV)
+		return dev_err_probe(component->dev, PTR_ERR(dmic->vref), "Failed to get vref\n");
+
 	dmic->gpio_en = devm_gpiod_get_optional(component->dev,
 						"dmicen", GPIOD_OUT_LOW);
 	if (IS_ERR(dmic->gpio_en))
-- 
2.25.1

Re: [PATCH 0/2] ASoC: dmic: add regulator support

[Mark Brown]

On Thu, 06 Mar 2025 18:18:38 +0100, Olivier Moysan wrote:
> Digital microphones may be supplied by a regulator. Add regulator
> support in dmic codec, to allow power management of the regulator
> through the ASoC DAPM widgets.
> 
> Olivier Moysan (2):
>   ASoC: dt-bindings: add regulator support to dmic codec
>   ASoC: dmic: add regulator support
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: add regulator support to dmic codec
      commit: a8fed0bddf8fa239fc71dc5c035d2e078c597369
[2/2] ASoC: dmic: add regulator support
      commit: 1ec3f1dc215d4b3d3679ecdc4a549d4e82b3a609

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark