mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Juri Lelli" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Jon Hunter <jonathanh@nvidia.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Valentin Schneider <vschneid@redhat.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Waiman Long <longman@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/deadline: Ignore special tasks when rebuilding domains
Date: Mon, 17 Mar 2025 10:34:43 -0000	[thread overview]
Message-ID: <174220768337.14745.8898635689115136336.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250313170011.357208-2-juri.lelli@redhat.com>

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     f6147af176eaa4027b692fdbb1a0a60dfaa1e9b6
Gitweb:        https://git.kernel.org/tip/f6147af176eaa4027b692fdbb1a0a60dfaa1e9b6
Author:        Juri Lelli <juri.lelli@redhat.com>
AuthorDate:    Thu, 13 Mar 2025 18:00:04 +01:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 17 Mar 2025 11:23:41 +01:00

sched/deadline: Ignore special tasks when rebuilding domains

SCHED_DEADLINE special tasks get a fake bandwidth that is only used to
make sure sleeping and priority inheritance 'work', but it is ignored
for runtime enforcement and admission control.

Be consistent with it also when rebuilding root domains.

Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for hotplug")
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Tested-by: Waiman Long <longman@redhat.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lore.kernel.org/r/20250313170011.357208-2-juri.lelli@redhat.com
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index ff4df16..1a041c1 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2956,7 +2956,7 @@ void dl_add_task_root_domain(struct task_struct *p)
 	struct dl_bw *dl_b;
 
 	raw_spin_lock_irqsave(&p->pi_lock, rf.flags);
-	if (!dl_task(p)) {
+	if (!dl_task(p) || dl_entity_is_special(&p->dl)) {
 		raw_spin_unlock_irqrestore(&p->pi_lock, rf.flags);
 		return;
 	}

  reply	other threads:[~2025-03-17 10:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 17:00 [PATCH v4 0/8] Fix SCHED_DEADLINE bandwidth accounting during suspend Juri Lelli
2025-03-13 17:00 ` [PATCH v4 1/8] sched/deadline: Ignore special tasks when rebuilding domains Juri Lelli
2025-03-17 10:34   ` tip-bot2 for Juri Lelli [this message]
2025-03-13 17:03 ` [PATCH v4 2/8] sched/topology: Wrappers for sched_domains_mutex Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:05 ` [PATCH v4 3/8] sched/deadline: Generalize unique visiting of root domains Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:10 ` [PATCH v4 4/8] sched/deadline: Rebuild root domain accounting after every update Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:11 ` [PATCH v4 5/8] sched/topology: Remove redundant dl_clear_root_domain call Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:12 ` [PATCH v4 6/8] cgroup/cpuset: Remove partition_and_rebuild_sched_domains Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:12 ` [PATCH v4 7/8] sched/topology: Stop exposing partition_sched_domains_locked Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:13 ` [PATCH v4 8/8] include/{topology,cpuset}: Move dl_rebuild_rd_accounting to cpuset.h Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-17  8:39 ` [PATCH v4 0/8] Fix SCHED_DEADLINE bandwidth accounting during suspend Dietmar Eggemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174220768337.14745.8898635689115136336.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=dietmar.eggemann@arm.com \
    --cc=jonathanh@nvidia.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=peterz@infradead.org \
    --cc=vschneid@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®