mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Juri Lelli <juri.lelli@redhat.com>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Cc: "Ingo Molnar" <mingo@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
	"Valentin Schneider" <vschneid@redhat.com>,
	"Waiman Long" <longman@redhat.com>, "Tejun Heo" <tj@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Qais Yousef" <qyousef@layalina.io>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Swapnil Sapkal" <swapnil.sapkal@amd.com>,
	"Shrikanth Hegde" <sshegde@linux.ibm.com>,
	"Phil Auld" <pauld@redhat.com>,
	luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it,
	"Jon Hunter" <jonathanh@nvidia.com>
Subject: Re: [PATCH v4 0/8] Fix SCHED_DEADLINE bandwidth accounting during suspend
Date: Mon, 17 Mar 2025 09:39:04 +0100	[thread overview]
Message-ID: <92a9cb8f-761a-4cc6-82f9-ea66aeecddfe@arm.com> (raw)
In-Reply-To: <20250313170011.357208-1-juri.lelli@redhat.com>

On 13/03/2025 18:00, Juri Lelli wrote:
> Hello!
> 
> Jon reported [1] a suspend regression on a Tegra board configured to
> boot with isolcpus and bisected it to commit 53916d5fd3c0
> ("sched/deadline: Check bandwidth overflow earlier for hotplug").
> 
> Root cause analysis pointed out that we are currently failing to
> correctly clear and restore bandwidth accounting on root domains after
> changes that initiate from partition_sched_domains(), as it is the case
> for suspend operations on that board.
> 
> This is v4 [2] of the proposed approach to fix the issue. With respect
> to v3 only patch 04 has changed as I have added the wrappers Waiman
> created to make sure we always call partition_sched_domains() while
> holding cpuset_mutex (issue pointed out by Dietmar on v3).
> 
> Dietmar also pointed out that the issue at hand is not fixed by this set
> for !CONFIG_CPUSETS configuration. But, given the fact that bandwidth
> accounting has been broken for such configuration so far (sigh) and that
> the vast majority (if not all) distributions have CPUSETS enabled, we
> decided to leave fixing the remaining issue for later. I will soon try
> to find time to keep looking into it.

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>

Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>

Testcase: suspend/resume

on Arm64 big.LITTLE cpumask=[LITTLE][big]=[0,3-5][1-2]
plus cmd line option 'isolcpus=3,4'.

      parent reply	other threads:[~2025-03-17  8:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 17:00 Juri Lelli
2025-03-13 17:00 ` [PATCH v4 1/8] sched/deadline: Ignore special tasks when rebuilding domains Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:03 ` [PATCH v4 2/8] sched/topology: Wrappers for sched_domains_mutex Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:05 ` [PATCH v4 3/8] sched/deadline: Generalize unique visiting of root domains Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:10 ` [PATCH v4 4/8] sched/deadline: Rebuild root domain accounting after every update Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:11 ` [PATCH v4 5/8] sched/topology: Remove redundant dl_clear_root_domain call Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:12 ` [PATCH v4 6/8] cgroup/cpuset: Remove partition_and_rebuild_sched_domains Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:12 ` [PATCH v4 7/8] sched/topology: Stop exposing partition_sched_domains_locked Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-13 17:13 ` [PATCH v4 8/8] include/{topology,cpuset}: Move dl_rebuild_rd_accounting to cpuset.h Juri Lelli
2025-03-17 10:34   ` [tip: sched/core] " tip-bot2 for Juri Lelli
2025-03-17  8:39 ` Dietmar Eggemann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92a9cb8f-761a-4cc6-82f9-ea66aeecddfe@arm.com \
    --to=dietmar.eggemann@arm.com \
    --cc=bigeasy@linutronix.de \
    --cc=bsegall@google.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=jonathanh@nvidia.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=luca.abeni@santannapisa.it \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=swapnil.sapkal@amd.com \
    --cc=tj@kernel.org \
    --cc=tommaso.cucinotta@santannapisa.it \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®