mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] block: remove unused nseg parameter
       [not found] <CGME20250401045256epcas5p47d761c5029394f165bf39e84e1cbbbc9@epcas5p4.samsung.com>
@ 2025-04-01  4:43 ` Nitesh Shetty
  2025-04-01 13:22   ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Nitesh Shetty @ 2025-04-01  4:43 UTC (permalink / raw)
  To: Jens Axboe
  Cc: gost.dev, nitheshshetty, Nitesh Shetty, linux-block, linux-kernel

We are no longer using nr_segs, after blk_mq_attempt_bio_merge was moved
out of blk_mq_get_new_request.

Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
---
 block/blk-mq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index ae8494d88897..0cfd1a149f64 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2965,8 +2965,7 @@ static bool blk_mq_attempt_bio_merge(struct request_queue *q,
 
 static struct request *blk_mq_get_new_requests(struct request_queue *q,
 					       struct blk_plug *plug,
-					       struct bio *bio,
-					       unsigned int nsegs)
+					       struct bio *bio)
 {
 	struct blk_mq_alloc_data data = {
 		.q		= q,
@@ -3125,7 +3124,7 @@ void blk_mq_submit_bio(struct bio *bio)
 	if (rq) {
 		blk_mq_use_cached_rq(rq, plug, bio);
 	} else {
-		rq = blk_mq_get_new_requests(q, plug, bio, nr_segs);
+		rq = blk_mq_get_new_requests(q, plug, bio);
 		if (unlikely(!rq)) {
 			if (bio->bi_opf & REQ_NOWAIT)
 				bio_wouldblock_error(bio);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] block: remove unused nseg parameter
  2025-04-01  4:43 ` [PATCH] block: remove unused nseg parameter Nitesh Shetty
@ 2025-04-01 13:22   ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2025-04-01 13:22 UTC (permalink / raw)
  To: Nitesh Shetty; +Cc: gost.dev, nitheshshetty, linux-block, linux-kernel


On Tue, 01 Apr 2025 10:13:47 +0530, Nitesh Shetty wrote:
> We are no longer using nr_segs, after blk_mq_attempt_bio_merge was moved
> out of blk_mq_get_new_request.
> 
> 

Applied, thanks!

[1/1] block: remove unused nseg parameter
      commit: e3e68311ead15d8be61e8e1a8d2f0d1773a7ba9c

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-01 13:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20250401045256epcas5p47d761c5029394f165bf39e84e1cbbbc9@epcas5p4.samsung.com>
2025-04-01  4:43 ` [PATCH] block: remove unused nseg parameter Nitesh Shetty
2025-04-01 13:22   ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®