* [PATCH] hwrandom / exynos / PM: Use CONFIG_PM in #ifdef
@ 2014-12-03 1:40 Rafael J. Wysocki
2014-12-03 4:14 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2014-12-03 1:40 UTC (permalink / raw)
To: Kukjin Kim
Cc: Linux Kernel Mailing List, Linux PM list, Herbert Xu,
Paul Gortmaker, linux-samsung-soc
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
CONFIG_PM is defined as the alternative of CONFIG_PM_RUNTIME and
CONFIG_PM_SLEEP, so it can be used instead of that.
Besides, after commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if
PM_SLEEP is selected) PM_RUNTIME is always set if PM is set, so
using the alternative isn't even necessary.
Use CONFIG_PM instead of it in drivers/char/hw_random/exynos-rng.c.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
Please let me know if it is OK to take this one into linux-pm.
---
drivers/char/hw_random/exynos-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-pm/drivers/char/hw_random/exynos-rng.c
===================================================================
--- linux-pm.orig/drivers/char/hw_random/exynos-rng.c
+++ linux-pm/drivers/char/hw_random/exynos-rng.c
@@ -143,7 +143,7 @@ static int exynos_rng_remove(struct plat
return 0;
}
-#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
+#ifdef CONFIG_PM
static int exynos_rng_runtime_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] hwrandom / exynos / PM: Use CONFIG_PM in #ifdef
2014-12-03 1:40 [PATCH] hwrandom / exynos / PM: Use CONFIG_PM in #ifdef Rafael J. Wysocki
@ 2014-12-03 4:14 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2014-12-03 4:14 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Kukjin Kim, Linux Kernel Mailing List, Linux PM list,
Paul Gortmaker, linux-samsung-soc
On Wed, Dec 03, 2014 at 02:40:35AM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> CONFIG_PM is defined as the alternative of CONFIG_PM_RUNTIME and
> CONFIG_PM_SLEEP, so it can be used instead of that.
>
> Besides, after commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if
> PM_SLEEP is selected) PM_RUNTIME is always set if PM is set, so
> using the alternative isn't even necessary.
>
> Use CONFIG_PM instead of it in drivers/char/hw_random/exynos-rng.c.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
> Please let me know if it is OK to take this one into linux-pm.
Sure.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-03 4:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-03 1:40 [PATCH] hwrandom / exynos / PM: Use CONFIG_PM in #ifdef Rafael J. Wysocki
2014-12-03 4:14 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®