* [PATCH] irqchip/irq-bcm2712-mip: Set EOI/ACK flags in msi_parent_ops
@ 2025-04-07 12:59 Stanimir Varbanov
2025-04-07 14:31 ` [tip: irq/urgent] " tip-bot2 for Stanimir Varbanov
0 siblings, 1 reply; 2+ messages in thread
From: Stanimir Varbanov @ 2025-04-07 12:59 UTC (permalink / raw)
To: linux-kernel; +Cc: Thomas Gleixner, Stanimir Varbanov
The recently introduced msi_parent_ops::chip_flags sets irq_eoi()/irq_ack()
conditionally, but MIP driver has not been updated. Populate chip_flags
with EOI | ACK flags.
Signed-off-by: Stanimir Varbanov <svarbanov@suse.de>
---
drivers/irqchip/irq-bcm2712-mip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-bcm2712-mip.c b/drivers/irqchip/irq-bcm2712-mip.c
index 49a19db2d1e1..4cce24233f0f 100644
--- a/drivers/irqchip/irq-bcm2712-mip.c
+++ b/drivers/irqchip/irq-bcm2712-mip.c
@@ -163,6 +163,7 @@ static const struct irq_domain_ops mip_middle_domain_ops = {
static const struct msi_parent_ops mip_msi_parent_ops = {
.supported_flags = MIP_MSI_FLAGS_SUPPORTED,
.required_flags = MIP_MSI_FLAGS_REQUIRED,
+ .chip_flags = MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,
.bus_select_token = DOMAIN_BUS_GENERIC_MSI,
.bus_select_mask = MATCH_PCI_MSI,
.prefix = "MIP-MSI-",
--
2.47.0
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip: irq/urgent] irqchip/irq-bcm2712-mip: Set EOI/ACK flags in msi_parent_ops
2025-04-07 12:59 [PATCH] irqchip/irq-bcm2712-mip: Set EOI/ACK flags in msi_parent_ops Stanimir Varbanov
@ 2025-04-07 14:31 ` tip-bot2 for Stanimir Varbanov
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Stanimir Varbanov @ 2025-04-07 14:31 UTC (permalink / raw)
To: linux-tip-commits
Cc: Stanimir Varbanov, Thomas Gleixner, x86, linux-kernel, maz
The following commit has been merged into the irq/urgent branch of tip:
Commit-ID: f35508b93a2fc127a8d185da2e5beade2f789977
Gitweb: https://git.kernel.org/tip/f35508b93a2fc127a8d185da2e5beade2f789977
Author: Stanimir Varbanov <svarbanov@suse.de>
AuthorDate: Mon, 07 Apr 2025 15:59:18 +03:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Mon, 07 Apr 2025 16:27:48 +02:00
irqchip/irq-bcm2712-mip: Set EOI/ACK flags in msi_parent_ops
The recently introduced msi_parent_ops::chip_flags sets irq_eoi()/irq_ack()
conditionally, but MIP driver has not been updated. Populate chip_flags
with EOI | ACK flags.
Fixes: 32c6c054661a ("irqchip: Add Broadcom BCM2712 MSI-X interrupt controller")
Signed-off-by: Stanimir Varbanov <svarbanov@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250407125918.3021454-1-svarbanov@suse.de
---
drivers/irqchip/irq-bcm2712-mip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-bcm2712-mip.c b/drivers/irqchip/irq-bcm2712-mip.c
index 49a19db..4cce242 100644
--- a/drivers/irqchip/irq-bcm2712-mip.c
+++ b/drivers/irqchip/irq-bcm2712-mip.c
@@ -163,6 +163,7 @@ static const struct irq_domain_ops mip_middle_domain_ops = {
static const struct msi_parent_ops mip_msi_parent_ops = {
.supported_flags = MIP_MSI_FLAGS_SUPPORTED,
.required_flags = MIP_MSI_FLAGS_REQUIRED,
+ .chip_flags = MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,
.bus_select_token = DOMAIN_BUS_GENERIC_MSI,
.bus_select_mask = MATCH_PCI_MSI,
.prefix = "MIP-MSI-",
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-07 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-07 12:59 [PATCH] irqchip/irq-bcm2712-mip: Set EOI/ACK flags in msi_parent_ops Stanimir Varbanov
2025-04-07 14:31 ` [tip: irq/urgent] " tip-bot2 for Stanimir Varbanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®