* [PATCH v2 1/2] dt-bindings: net: wireless: Add Realtek RTL8188ETV USB WiFi
2025-04-08 19:13 [PATCH v2 0/2] Onboard USB device support for RTL8188ETV 2.4GHz USB WiFi module J. Neuschäfer via B4 Relay
@ 2025-04-08 19:13 ` J. Neuschäfer via B4 Relay
2025-04-11 15:24 ` Rob Herring (Arm)
2025-04-08 19:13 ` [PATCH v2 2/2] usb: misc: onboard_dev: Add Realtek RTL8188ETV WiFi (0bda:0179) J. Neuschäfer via B4 Relay
1 sibling, 1 reply; 4+ messages in thread
From: J. Neuschäfer via B4 Relay @ 2025-04-08 19:13 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Kaehlcke, Greg Kroah-Hartman
Cc: Martin Blumenstingl, Jes Sorensen, linux-wireless, devicetree,
linux-kernel, linux-usb, Bitterblue Smith, J. Neuschäfer
From: "J. Neuschäfer" <j.ne@posteo.net>
This is an on-board USB device that requires a 3.3V supply.
Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
---
V2:
- Use my current email address
- Remove TODO comment
- Rename schema file to realtek,rtl8188e.yaml. This is the same
granularity at which the rtl8xxxu driver is split into files, making
it unnecessary to rename the schema file if another similar chip is added
in the future.
- Change license identifier from (GPL-2.0 OR BSD-2-Clause) to (GPL-2.0-only
OR BSD-2-Clause) because GPL-2.0 is ambiguous
---
.../bindings/net/wireless/realtek,rtl8188e.yaml | 50 ++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188e.yaml b/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188e.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..2769731e07083b14e2f7388858dcded92c442018
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188e.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/realtek,rtl8188e.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek RTL8188E USB WiFi
+
+maintainers:
+ - J. Neuschäfer <j.ne@posteo.net>
+
+description:
+ Realtek RTL8188E is a family of USB-connected 2.4 GHz WiFi modules.
+
+allOf:
+ - $ref: /schemas/usb/usb-device.yaml#
+
+properties:
+ compatible:
+ const: usbbda,179 # RTL8188ETV
+
+ reg: true
+
+ vdd-supply:
+ description:
+ Regulator for the 3V3 supply.
+
+required:
+ - compatible
+ - reg
+ - vdd-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ usb {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ wifi: wifi@1 {
+ compatible = "usbbda,179";
+ reg = <1>;
+ vdd-supply = <&vcc3v3>;
+ };
+ };
+
+...
--
2.48.0.rc1.219.gb6b6757d772
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 2/2] usb: misc: onboard_dev: Add Realtek RTL8188ETV WiFi (0bda:0179)
2025-04-08 19:13 [PATCH v2 0/2] Onboard USB device support for RTL8188ETV 2.4GHz USB WiFi module J. Neuschäfer via B4 Relay
2025-04-08 19:13 ` [PATCH v2 1/2] dt-bindings: net: wireless: Add Realtek RTL8188ETV USB WiFi J. Neuschäfer via B4 Relay
@ 2025-04-08 19:13 ` J. Neuschäfer via B4 Relay
1 sibling, 0 replies; 4+ messages in thread
From: J. Neuschäfer via B4 Relay @ 2025-04-08 19:13 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Kaehlcke, Greg Kroah-Hartman
Cc: Martin Blumenstingl, Jes Sorensen, linux-wireless, devicetree,
linux-kernel, linux-usb, Bitterblue Smith, J. Neuschäfer
From: "J. Neuschäfer" <j.ne@posteo.net>
Realtek RTL8188ETV 2.4 GHz WiFi modules (detected as RTL8188EU by the
RTL8XXXXU driver) are found soldered into some embedded devices, such as
the Fernsehfee 3.0 set-top box.
They require a 3.3V power supply.
Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
---
checkpatch.pl flags the "usbbda" prefix as undocumented because it isn't
in vendor-prefixes.yaml. It is, however, an established pattern:
$ git grep -E 'usb[0-9a-f]{1,4},[0-9a-f]{1,4}' | wc -l
213
V2:
- Refer to RTL8188ETV in the title and description
---
drivers/usb/misc/onboard_usb_dev.c | 1 +
drivers/usb/misc/onboard_usb_dev.h | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c
index 75ac3c6aa92d0d925bb9488d1e6295548446bf98..2f9e8f8108d8c36403b02f3e66db55757d4808ef 100644
--- a/drivers/usb/misc/onboard_usb_dev.c
+++ b/drivers/usb/misc/onboard_usb_dev.c
@@ -584,6 +584,7 @@ static const struct usb_device_id onboard_dev_id_table[] = {
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 HUB */
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 HUB */
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 HUB */
+ { USB_DEVICE(VENDOR_ID_REALTEK, 0x0179) }, /* RTL8188ETV 2.4GHz WiFi */
{ USB_DEVICE(VENDOR_ID_TI, 0x8025) }, /* TI USB8020B 3.0 HUB */
{ USB_DEVICE(VENDOR_ID_TI, 0x8027) }, /* TI USB8020B 2.0 HUB */
{ USB_DEVICE(VENDOR_ID_TI, 0x8140) }, /* TI USB8041 3.0 HUB */
diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h
index 933797a7e0841ceee655b80ee1c8d21bc2eaaa04..4b023ddfbdd61efbc41c039cafbd0c85971563ee 100644
--- a/drivers/usb/misc/onboard_usb_dev.h
+++ b/drivers/usb/misc/onboard_usb_dev.h
@@ -45,6 +45,13 @@ static const struct onboard_dev_pdata realtek_rts5411_data = {
.is_hub = true,
};
+static const struct onboard_dev_pdata realtek_rtl8188etv_data = {
+ .reset_us = 0,
+ .num_supplies = 1,
+ .supply_names = { "vdd" },
+ .is_hub = false,
+};
+
static const struct onboard_dev_pdata ti_tusb8020b_data = {
.reset_us = 3000,
.num_supplies = 1,
@@ -118,6 +125,7 @@ static const struct of_device_id onboard_dev_match[] = {
{ .compatible = "usb5e3,610", .data = &genesys_gl852g_data, },
{ .compatible = "usb5e3,620", .data = &genesys_gl852g_data, },
{ .compatible = "usb5e3,626", .data = &genesys_gl852g_data, },
+ { .compatible = "usbbda,179", .data = &realtek_rtl8188etv_data, },
{ .compatible = "usbbda,411", .data = &realtek_rts5411_data, },
{ .compatible = "usbbda,5411", .data = &realtek_rts5411_data, },
{ .compatible = "usbbda,414", .data = &realtek_rts5411_data, },
--
2.48.0.rc1.219.gb6b6757d772
^ permalink raw reply [flat|nested] 4+ messages in thread