mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net v2] selftests/tc-testing: Add test for echo of big TC filters
@ 2025-04-10 10:43 Toke Høiland-Jørgensen
  2025-04-11 11:07 ` Victor Nogueira
  2025-04-11 23:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2025-04-10 10:43 UTC (permalink / raw)
  To: linux-kernel
  Cc: Toke Høiland-Jørgensen, Jamal Hadi Salim, Cong Wang,
	Jiri Pirko, Shuah Khan, netdev

Add a selftest that checks whether the kernel can successfully echo a
big tc filter, to test the fix introduced in commit:

369609fc6272 ("tc: Ensure we have enough buffer space when sending filter netlink notifications")

Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
v2:
- Move to infra/actions.json

 .../tc-testing/tc-tests/infra/actions.json    | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tools/testing/selftests/tc-testing/tc-tests/infra/actions.json b/tools/testing/selftests/tc-testing/tc-tests/infra/actions.json
index 1ba96c467754..d9fc62ab476c 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/infra/actions.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/infra/actions.json
@@ -412,5 +412,27 @@
         "teardown": [
             "$TC qdisc del dev $DUMMY ingress"
         ]
+    },
+    {
+        "id": "33f4",
+        "name": "Check echo of big filter command",
+        "category": [
+            "infra",
+            "u32"
+        ],
+        "plugins": {
+            "requires": "nsPlugin"
+        },
+        "setup": [
+            "$TC qdisc add dev $DUMMY parent root handle 10: fq_codel"
+        ],
+        "cmdUnderTest": "bash -c '$TC -echo filter add dev $DUMMY parent 10: u32 match u32 0 0 $(for i in $(seq 32); do echo action pedit munge ip dport set 22; done) | grep \"added filter\"'",
+        "verifyCmd": "",
+        "expExitCode": "0",
+        "matchCount": "0",
+        "matchPattern": "",
+        "teardown": [
+            "$TC qdisc del dev $DUMMY parent root fq_codel"
+        ]
     }
 ]
-- 
2.49.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net v2] selftests/tc-testing: Add test for echo of big TC filters
  2025-04-10 10:43 [PATCH net v2] selftests/tc-testing: Add test for echo of big TC filters Toke Høiland-Jørgensen
@ 2025-04-11 11:07 ` Victor Nogueira
  2025-04-11 23:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Victor Nogueira @ 2025-04-11 11:07 UTC (permalink / raw)
  To: Toke Høiland-Jørgensen, linux-kernel
  Cc: Jamal Hadi Salim, Cong Wang, Jiri Pirko, Shuah Khan, netdev

On 4/10/25 07:43, Toke Høiland-Jørgensen wrote:
> Add a selftest that checks whether the kernel can successfully echo a
> big tc filter, to test the fix introduced in commit:
> 
> 369609fc6272 ("tc: Ensure we have enough buffer space when sending filter netlink notifications")
> 
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> ---
> v2:
> - Move to infra/actions.json
> 
>   .../tc-testing/tc-tests/infra/actions.json    | 22 +++++++++++++++++++
>   1 file changed, 22 insertions(+)

Tested-by: Victor Nogueira <victor@mojatatu.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net v2] selftests/tc-testing: Add test for echo of big TC filters
  2025-04-10 10:43 [PATCH net v2] selftests/tc-testing: Add test for echo of big TC filters Toke Høiland-Jørgensen
  2025-04-11 11:07 ` Victor Nogueira
@ 2025-04-11 23:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-11 23:40 UTC (permalink / raw)
  To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=
  Cc: linux-kernel, jhs, xiyou.wangcong, jiri, shuah, netdev

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 10 Apr 2025 12:43:21 +0200 you wrote:
> Add a selftest that checks whether the kernel can successfully echo a
> big tc filter, to test the fix introduced in commit:
> 
> 369609fc6272 ("tc: Ensure we have enough buffer space when sending filter netlink notifications")
> 
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> 
> [...]

Here is the summary with links:
  - [net,v2] selftests/tc-testing: Add test for echo of big TC filters
    https://git.kernel.org/netdev/net/c/18c889a9a419

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-11 23:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-10 10:43 [PATCH net v2] selftests/tc-testing: Add test for echo of big TC filters Toke Høiland-Jørgensen
2025-04-11 11:07 ` Victor Nogueira
2025-04-11 23:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®