* [PATCH RFC v3 1/3] arm64: dts: qcom: sm8750: Add Modem / MPSS
2025-02-21 16:33 [PATCH RFC v3 0/3] arm64: dts: qcom: sm8750: Add modem Krzysztof Kozlowski
@ 2025-02-21 16:33 ` Krzysztof Kozlowski
2025-02-21 18:42 ` Konrad Dybcio
2025-02-21 16:33 ` [PATCH RFC v3 2/3] arm64: dts: qcom: sm8750-mtp: Enable modem Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-21 16:33 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Dmitry Baryshkov,
Krzysztof Kozlowski
Add nodes for the MPSS and its SMP2P. These are compatible with earlier
SM8650 with difference in lack of fifth memory region for Qlink Logging.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8750.dtsi | 92 ++++++++++++++++++++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index 033e8153aa73cea00d1d4394c572bf8e19231305..a0316514d8aaa3a3ec3599c1fb2f9b2ba948145f 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -571,6 +571,45 @@ smp2p_cdsp_in: slave-kernel {
};
};
+ smp2p-modem {
+ compatible = "qcom,smp2p";
+
+ interrupts-extended = <&ipcc IPCC_CLIENT_MPSS
+ IPCC_MPROC_SIGNAL_SMP2P
+ IRQ_TYPE_EDGE_RISING>;
+
+ mboxes = <&ipcc IPCC_CLIENT_MPSS
+ IPCC_MPROC_SIGNAL_SMP2P>;
+
+ qcom,smem = <435>, <428>;
+ qcom,local-pid = <0>;
+ qcom,remote-pid = <1>;
+
+ smp2p_modem_out: master-kernel {
+ qcom,entry-name = "master-kernel";
+ #qcom,smem-state-cells = <1>;
+ };
+
+ smp2p_modem_in: slave-kernel {
+ qcom,entry-name = "slave-kernel";
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ ipa_smp2p_out: ipa-ap-to-modem {
+ qcom,entry-name = "ipa";
+ #qcom,smem-state-cells = <1>;
+ };
+
+ ipa_smp2p_in: ipa-modem-to-ap {
+ qcom,entry-name = "ipa";
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ /* TODO: smem mailbox in and out */
+ };
+
soc: soc@0 {
compatible = "simple-bus";
@@ -2011,6 +2050,59 @@ tcsr_mutex: hwlock@1f40000 {
#hwlock-cells = <1>;
};
+ remoteproc_mpss: remoteproc@4080000 {
+ compatible = "qcom,sm8750-mpss-pas";
+ reg = <0x0 0x04080000 0x0 0x10000>;
+
+ interrupts-extended = <&intc GIC_SPI 264 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_modem_in 0 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_modem_in 1 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_modem_in 2 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_modem_in 3 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_modem_in 7 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "wdog",
+ "fatal",
+ "ready",
+ "handover",
+ "stop-ack",
+ "shutdown-ack";
+
+ clocks = <&rpmhcc RPMH_CXO_CLK>;
+ clock-names = "xo";
+
+ interconnects = <&mc_virt MASTER_LLCC QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+
+ power-domains = <&rpmhpd RPMHPD_CX>,
+ <&rpmhpd RPMHPD_MSS>;
+ power-domain-names = "cx",
+ "mss";
+
+ memory-region = <&mpss_mem>, <&q6_mpss_dtb_mem>,
+ <&dsm_partition_1_mem>,
+ <&dsm_partition_2_mem>;
+
+ qcom,qmp = <&aoss_qmp>;
+
+ qcom,smem-states = <&smp2p_modem_out 0>;
+ qcom,smem-state-names = "stop";
+
+ status = "disabled";
+
+ glink-edge {
+ interrupts-extended = <&ipcc IPCC_CLIENT_MPSS
+ IPCC_MPROC_SIGNAL_GLINK_QMP
+ IRQ_TYPE_EDGE_RISING>;
+
+ mboxes = <&ipcc IPCC_CLIENT_MPSS
+ IPCC_MPROC_SIGNAL_GLINK_QMP>;
+
+ qcom,remote-pid = <1>;
+
+ label = "mpss";
+ };
+ };
+
remoteproc_adsp: remoteproc@6800000 {
compatible = "qcom,sm8750-adsp-pas", "qcom,sm8550-adsp-pas";
reg = <0x0 0x06800000 0x0 0x10000>;
--
2.43.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH RFC v3 2/3] arm64: dts: qcom: sm8750-mtp: Enable modem
2025-02-21 16:33 [PATCH RFC v3 0/3] arm64: dts: qcom: sm8750: Add modem Krzysztof Kozlowski
2025-02-21 16:33 ` [PATCH RFC v3 1/3] arm64: dts: qcom: sm8750: Add Modem / MPSS Krzysztof Kozlowski
@ 2025-02-21 16:33 ` Krzysztof Kozlowski
2025-02-21 18:42 ` Konrad Dybcio
2025-02-21 16:33 ` [PATCH RFC v3 3/3] arm64: dts: qcom: sm8750-qrd: " Krzysztof Kozlowski
2025-04-16 18:10 ` [PATCH RFC v3 0/3] arm64: dts: qcom: sm8750: Add modem Bjorn Andersson
3 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-21 16:33 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
Enable the modem (MPSS) on MPT8750 board.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 5d0decd2aa2d0e0849414534cdd504714402458e..72f081a890dfe49bfbee5e91b9e51da53b9d8baf 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -798,6 +798,14 @@ &remoteproc_cdsp {
status = "okay";
};
+&remoteproc_mpss {
+ firmware-name = "qcom/sm8750/modem.mbn",
+ "qcom/sm8750/modem_dtb.mbn";
+
+ /* Modem crashes after some time with "DOG detects stalled initialization" */
+ status = "fail";
+};
+
&tlmm {
/* reserved for secure world */
gpio-reserved-ranges = <36 4>, <74 1>;
--
2.43.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH RFC v3 3/3] arm64: dts: qcom: sm8750-qrd: Enable modem
2025-02-21 16:33 [PATCH RFC v3 0/3] arm64: dts: qcom: sm8750: Add modem Krzysztof Kozlowski
2025-02-21 16:33 ` [PATCH RFC v3 1/3] arm64: dts: qcom: sm8750: Add Modem / MPSS Krzysztof Kozlowski
2025-02-21 16:33 ` [PATCH RFC v3 2/3] arm64: dts: qcom: sm8750-mtp: Enable modem Krzysztof Kozlowski
@ 2025-02-21 16:33 ` Krzysztof Kozlowski
2025-02-21 18:42 ` Konrad Dybcio
2025-04-16 18:10 ` [PATCH RFC v3 0/3] arm64: dts: qcom: sm8750: Add modem Bjorn Andersson
3 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-21 16:33 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
Enable the modem (MPSS) on QRD8750 board.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 7f1d5d4e5b2813c59ea9dba2c57bee824f967481..840a6d8f8a24670a01376f8fce511da222159016 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -796,6 +796,13 @@ &remoteproc_cdsp {
status = "okay";
};
+&remoteproc_mpss {
+ firmware-name = "qcom/sm8750/modem.mbn",
+ "qcom/sm8750/modem_dtb.mbn";
+
+ status = "okay";
+};
+
&tlmm {
/* reserved for secure world */
gpio-reserved-ranges = <36 4>, <74 1>;
--
2.43.0
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH RFC v3 0/3] arm64: dts: qcom: sm8750: Add modem
2025-02-21 16:33 [PATCH RFC v3 0/3] arm64: dts: qcom: sm8750: Add modem Krzysztof Kozlowski
` (2 preceding siblings ...)
2025-02-21 16:33 ` [PATCH RFC v3 3/3] arm64: dts: qcom: sm8750-qrd: " Krzysztof Kozlowski
@ 2025-04-16 18:10 ` Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2025-04-16 18:10 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, Dmitry Baryshkov
On Fri, 21 Feb 2025 17:33:04 +0100, Krzysztof Kozlowski wrote:
> RFC because modem on MTP8750 crashes after booting for unknown reasons.
>
> Changes in v3:
> - Split modem to separate patchset and series
> - Link to v2: https://lore.kernel.org/r/20250220-b4-sm8750-cdsp-v2-0-a70dd2d04419@linaro.org
>
> Changes in v2 (from previous patchset - combined CDSP and modem):
> - Fix CDSP and MPSS PAS address space range.
> - Re-order nodes for correct placement.
> - Rb tags.
> - Link to v1: https://lore.kernel.org/r/20241122-b4-sm8750-cdsp-v1-0-9a69a889d1b7@linaro.org
>
> [...]
Applied, thanks!
[1/3] arm64: dts: qcom: sm8750: Add Modem / MPSS
commit: 104790b0699462dcf208a7d0290fc7a7fe44cc54
[2/3] arm64: dts: qcom: sm8750-mtp: Enable modem
commit: 9facd1c15b9362f280dd2c27e08cc1942eacd1cf
[3/3] arm64: dts: qcom: sm8750-qrd: Enable modem
commit: ddf4c3840a3cfea3a037f778ad9223b9337e0bc5
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread