[PATCH] lib: Ensure prime numbers tests are included in KUnit test runs

[PATCH] lib: Ensure prime numbers tests are included in KUnit test runs

[Mark Brown]

When the select of PRIME_MUMBERS was removed from it's KUnit test
Kconfig nothing was added to the KUnit configs, meaning that when run
via the KUnit runner the tests are neither built nor run.  Add
PRIME_NUMBERS to all_tests.config so they are enabled when the KUnit
runner builds the kernel.

Fixes: 3f2925174f8b ("lib/prime_numbers: KUnit test should not select PRIME_NUMBERS")
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/testing/kunit/configs/all_tests.config | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
index cdd9782f9646..7bb885b0c32d 100644
--- a/tools/testing/kunit/configs/all_tests.config
+++ b/tools/testing/kunit/configs/all_tests.config
@@ -43,6 +43,8 @@ CONFIG_REGMAP_BUILD=y
 
 CONFIG_AUDIT=y
 
+CONFIG_PRIME_NUMBERS=y
+
 CONFIG_SECURITY=y
 CONFIG_SECURITY_APPARMOR=y
 CONFIG_SECURITY_LANDLOCK=y

---
base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b
change-id: 20250422-lib-fix-prime-numbers-kunit-323659c2cfe2

Best regards,
-- 
Mark Brown <broonie@kernel.org>

Re: [PATCH] lib: Ensure prime numbers tests are included in KUnit test runs

[Kees Cook]

On Tue, 22 Apr 2025 16:43:29 +0100, Mark Brown wrote:
> When the select of PRIME_MUMBERS was removed from it's KUnit test
> Kconfig nothing was added to the KUnit configs, meaning that when run
> via the KUnit runner the tests are neither built nor run.  Add
> PRIME_NUMBERS to all_tests.config so they are enabled when the KUnit
> runner builds the kernel.
> 
> 
> [...]

Applied to for-linus/hardening, thanks!

[1/1] lib: Ensure prime numbers tests are included in KUnit test runs
      https://git.kernel.org/kees/c/4ea404fdbc39

Take care,

-- 
Kees Cook

Re: [PATCH] lib: Ensure prime numbers tests are included in KUnit test runs

[Geert Uytterhoeven]

Hi Mark,

Thanks for your patch!

On Tue, 22 Apr 2025 at 17:43, Mark Brown <broonie@kernel.org> wrote:
> When the select of PRIME_MUMBERS was removed from it's KUnit test
> Kconfig nothing was added to the KUnit configs, meaning that when run
> via the KUnit runner the tests are neither built nor run.  Add
> PRIME_NUMBERS to all_tests.config so they are enabled when the KUnit
> runner builds the kernel.
>
> Fixes: 3f2925174f8b ("lib/prime_numbers: KUnit test should not select PRIME_NUMBERS")

Sorry, I wasn't aware there was yet another config file that needed
an update...

> Signed-off-by: Mark Brown <broonie@kernel.org>

> --- a/tools/testing/kunit/configs/all_tests.config
> +++ b/tools/testing/kunit/configs/all_tests.config

Given this is the sole file that contains CONFIG_REGMAP_BUILD=y,
it must be the right one ;-)

> @@ -43,6 +43,8 @@ CONFIG_REGMAP_BUILD=y
>
>  CONFIG_AUDIT=y
>
> +CONFIG_PRIME_NUMBERS=y
> +
>  CONFIG_SECURITY=y
>  CONFIG_SECURITY_APPARMOR=y
>  CONFIG_SECURITY_LANDLOCK=y

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds