From: "Rob Herring (Arm)" <robh@kernel.org>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: devicetree@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Charles Hsu" <ythsu0511@gmail.com>,
linux-hwmon@vger.kernel.org,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org,
"Peter Zijlstra" <peterz@infradead.org>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-doc@vger.kernel.org, "Guenter Roeck" <linux@roeck-us.net>,
"Shen Lichuan" <shenlichuan@vivo.com>
Subject: Re: [PATCH 5/5] dt-bindings: hwmon: Add bindings for mpq8785 driver
Date: Mon, 28 Apr 2025 18:26:53 -0500 [thread overview]
Message-ID: <174588281340.1841112.12342859635067816713.robh@kernel.org> (raw)
In-Reply-To: <20250428221420.2077697-6-paweldembicki@gmail.com>
On Tue, 29 Apr 2025 00:13:35 +0200, Pawel Dembicki wrote:
> Add device tree bindings for Monolithic Power Systems MPQ8785, MPM82504
> and MPM3695 PMBus-compliant voltage regulators.
>
> These bindings also documents the optional "voltage-scale-loop" property.
>
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
> ---
> .../bindings/hwmon/pmbus/mps,mpq8785.yaml | 54 +++++++++++++++++++
> 1 file changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Warning: Duplicate compatible "mps,mpq8785" found in schemas matching "$id":
http://devicetree.org/schemas/hwmon/pmbus/mps,mpq8785.yaml#
http://devicetree.org/schemas/trivial-devices.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.example.dtb: pmic@30 (mps,mpm82504): False schema does not allow {'compatible': ['mps,mpm82504'], 'reg': [[48]], 'voltage-scale-loop': 600, '$nodename': ['pmic@30']}
from schema $id: http://devicetree.org/schemas/hwmon/pmbus/mps,mpq8785.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250428221420.2077697-6-paweldembicki@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-04-28 23:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 22:13 [PATCH 0/5] hwmon: pmbus: Add support for MPM82504 and MPM3695-10 Pawel Dembicki
2025-04-28 22:13 ` [PATCH 1/5] hwmon: pmbus: mpq8785: Prepare driver for multiple device support Pawel Dembicki
2025-04-28 22:13 ` [PATCH 2/5] hwmon: pmbus: mpq8785: Add support for MPM82504 Pawel Dembicki
2025-04-30 4:07 ` Guenter Roeck
2025-04-28 22:13 ` [PATCH 3/5] hwmon: pmbus: mpq8785: Add support for MPM3695 Pawel Dembicki
2025-04-30 4:10 ` Guenter Roeck
2025-04-28 22:13 ` [PATCH 4/5] hwmon: pmbus: mpq8785: Implement voltage scale loop configuration Pawel Dembicki
2025-04-29 0:27 ` Guenter Roeck
2025-04-28 22:13 ` [PATCH 5/5] dt-bindings: hwmon: Add bindings for mpq8785 driver Pawel Dembicki
2025-04-28 23:26 ` Rob Herring (Arm) [this message]
2025-04-29 7:30 ` Krzysztof Kozlowski
2025-04-29 13:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174588281340.1841112.12342859635067816713.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=paweldembicki@gmail.com \
--cc=peterz@infradead.org \
--cc=shenlichuan@vivo.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ythsu0511@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®