From: Guenter Roeck <linux@roeck-us.net>
To: Pawel Dembicki <paweldembicki@gmail.com>, linux-hwmon@vger.kernel.org
Cc: "Jean Delvare" <jdelvare@suse.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Peter Zijlstra" <peterz@infradead.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Shen Lichuan" <shenlichuan@vivo.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Charles Hsu" <ythsu0511@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 3/5] hwmon: pmbus: mpq8785: Add support for MPM3695
Date: Tue, 29 Apr 2025 21:10:35 -0700 [thread overview]
Message-ID: <544a9f3d-1262-4668-90df-c767d3fe85ed@roeck-us.net> (raw)
In-Reply-To: <20250428221420.2077697-4-paweldembicki@gmail.com>
On 4/28/25 15:13, Pawel Dembicki wrote:
> Add support for the Monolithic Power Systems MPM3695 device.
> The device is PMBus compliant and shares characteristics with the
> MPM82504.
>
> Tested with device tree based matching.
>
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
> ---
> Documentation/hwmon/mpq8785.rst | 13 +++++++++++--
> drivers/hwmon/pmbus/mpq8785.c | 5 ++++-
> 2 files changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/hwmon/mpq8785.rst b/Documentation/hwmon/mpq8785.rst
> index be228ee58ce2..20d43b8bba97 100644
> --- a/Documentation/hwmon/mpq8785.rst
> +++ b/Documentation/hwmon/mpq8785.rst
> @@ -7,6 +7,7 @@ Supported chips:
>
> * MPS MPQ8785
> * MPS MPM82504
> + * MPS MPM3695-10
Why the restriction to the -10 variant ? I found four variante (-10, -20, -25, and -100).
Unless I am missing something they all use the same parameters.
Unless you have evidence that the chips are different enough to warrant separate entries,
just refer to the chip as MPM3695 and explain in the documentation that there are four
different variants.
Thanks,
Guenter
>
> Prefix: 'mpq8785'
>
> @@ -29,6 +30,13 @@ The device can also operate in parallel with the MPM3695-100 and additional
> MPM82504 devices to provide a higher output current. The MPM82504 operates
> at high efficiency across a wide load range.
>
> +The MPM3695-10 is a scalable, ultra-thin, fully integrated power module with
> +a PMBus interface. It offers a complete power solution that achieves up to
> +10A of output current with excellent load and line regulation across a wide
> +input voltage range. The device’s 2mm height enables it to be placed on the
> +backside of a PCB for space optimization. It operates at high efficiency over
> +a wide load range, and can be paralleled to deliver higher current.
> +
> The PMBus interface provides converter configurations and key parameters
> monitoring.
>
> @@ -43,8 +51,9 @@ over-voltage protection (OVP), under-voltage protection (UVP), and
> over-temperature protection (OTP).
>
> All supported modules require a minimal number of readily available, standard
> -external components. The MPQ8785 is available in a TLGA (5mmx6mm) package
> -and the MPM82504 is available in a BGA (15mmx30mmx5.18mm) package.
> +external components. The MPQ8785 is available in a TLGA (5mmx6mm) package,
> +the MPM82504 is available in a BGA (15mmx30mmx5.18mm) package and the MPM3695-10
> +is available in an LGA-45 (8mmx8mmx2mm) package.
>
> Device compliant with:
>
> diff --git a/drivers/hwmon/pmbus/mpq8785.c b/drivers/hwmon/pmbus/mpq8785.c
> index 7ee201550554..e6a643856f08 100644
> --- a/drivers/hwmon/pmbus/mpq8785.c
> +++ b/drivers/hwmon/pmbus/mpq8785.c
> @@ -8,7 +8,7 @@
> #include <linux/of_device.h>
> #include "pmbus.h"
>
> -enum chips { mpq8785, mpm82504 };
> +enum chips { mpq8785, mpm82504, mpm3695_10 };
>
> static int mpq8785_identify(struct i2c_client *client,
> struct pmbus_driver_info *info)
> @@ -60,6 +60,7 @@ static struct pmbus_driver_info mpq8785_info = {
> static const struct i2c_device_id mpq8785_id[] = {
> { "mpq8785", mpq8785 },
> { "mpm82504", mpm82504 },
> + { "mpm3695-10", mpm3695_10 },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, mpq8785_id);
> @@ -67,6 +68,7 @@ MODULE_DEVICE_TABLE(i2c, mpq8785_id);
> static const struct of_device_id __maybe_unused mpq8785_of_match[] = {
> { .compatible = "mps,mpq8785", .data = (void *)mpq8785 },
> { .compatible = "mps,mpm82504", .data = (void *)mpm82504 },
> + { .compatible = "mps,mpm3695-10", .data = (void *)mpm3695_10 },
> {}
> };
> MODULE_DEVICE_TABLE(of, mpq8785_of_match);
> @@ -92,6 +94,7 @@ static int mpq8785_probe(struct i2c_client *client)
>
> break;
> case mpm82504:
> + case mpm3695_10:
> info->format[PSC_VOLTAGE_OUT] = direct;
> info->m[PSC_VOLTAGE_OUT] = 8;
> info->b[PSC_VOLTAGE_OUT] = 0;
next prev parent reply other threads:[~2025-04-30 4:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 22:13 [PATCH 0/5] hwmon: pmbus: Add support for MPM82504 and MPM3695-10 Pawel Dembicki
2025-04-28 22:13 ` [PATCH 1/5] hwmon: pmbus: mpq8785: Prepare driver for multiple device support Pawel Dembicki
2025-04-28 22:13 ` [PATCH 2/5] hwmon: pmbus: mpq8785: Add support for MPM82504 Pawel Dembicki
2025-04-30 4:07 ` Guenter Roeck
2025-04-28 22:13 ` [PATCH 3/5] hwmon: pmbus: mpq8785: Add support for MPM3695 Pawel Dembicki
2025-04-30 4:10 ` Guenter Roeck [this message]
2025-04-28 22:13 ` [PATCH 4/5] hwmon: pmbus: mpq8785: Implement voltage scale loop configuration Pawel Dembicki
2025-04-29 0:27 ` Guenter Roeck
2025-04-28 22:13 ` [PATCH 5/5] dt-bindings: hwmon: Add bindings for mpq8785 driver Pawel Dembicki
2025-04-28 23:26 ` Rob Herring (Arm)
2025-04-29 7:30 ` Krzysztof Kozlowski
2025-04-29 13:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544a9f3d-1262-4668-90df-c767d3fe85ed@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paweldembicki@gmail.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=shenlichuan@vivo.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ythsu0511@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®