From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: media: i2c: imx335: Fix frame size enumeration
Date: Wed, 30 Apr 2025 09:54:50 +0100 [thread overview]
Message-ID: <174600329094.1586992.9902010088598676539@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <aBHjFcbjR_oPiINu@valkosipuli.retiisi.eu>
Quoting Sakari Ailus (2025-04-30 09:45:09)
> Hi Kieran,
>
> On Wed, Apr 30, 2025 at 08:36:49AM +0100, Kieran Bingham wrote:
> > In commit cfa49ff0558a ("media: i2c: imx335: Support 2592x1940 10-bit
> > mode") the IMX335 driver was extended to support multiple output
> > bitdepth modes.
> >
> > This incorrectly extended the frame size enumeration to check against
> > the supported mbus_codes array instead of the supported mode/frame
> > array. This has the unwanted side effect of reporting the currently
> > supported frame size 2592x1944 three times.
> >
> > Fix the check accordingly to report a frame size for each supported
> > size, which is presently only a single entry.
> >
> > Fixes: cfa49ff0558a ("media: i2c: imx335: Support 2592x1940 10-bit mode")
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> Thanks for the patch.
>
> Cc: stable is required these days with Fixes: tag, I've added it this time.
I didn't know that. I thought stable tree picked up from the fixes tags.
(Or I remember there was some AI system that was picking them out too?)
I'll see if I can automate/add that to my fixes helper.
Does it need to be in this format?
Cc: stable@vger.kernel.org # 6.8
--
Kieran
>
> --
> Sakari Ailus
prev parent reply other threads:[~2025-04-30 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 7:36 Kieran Bingham
2025-04-30 8:45 ` Sakari Ailus
2025-04-30 8:54 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174600329094.1586992.9902010088598676539@ping.linuxembedded.co.uk \
--to=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®