mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: media: i2c: imx335: Fix frame size enumeration
Date: Wed, 30 Apr 2025 08:45:09 +0000	[thread overview]
Message-ID: <aBHjFcbjR_oPiINu@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20250430073649.1986018-1-kieran.bingham@ideasonboard.com>

Hi Kieran,

On Wed, Apr 30, 2025 at 08:36:49AM +0100, Kieran Bingham wrote:
> In commit cfa49ff0558a ("media: i2c: imx335: Support 2592x1940 10-bit
> mode") the IMX335 driver was extended to support multiple output
> bitdepth modes.
> 
> This incorrectly extended the frame size enumeration to check against
> the supported mbus_codes array instead of the supported mode/frame
> array. This has the unwanted side effect of reporting the currently
> supported frame size 2592x1944 three times.
> 
> Fix the check accordingly to report a frame size for each supported
> size, which is presently only a single entry.
> 
> Fixes: cfa49ff0558a ("media: i2c: imx335: Support 2592x1940 10-bit mode")
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Thanks for the patch.

Cc: stable is required these days with Fixes: tag, I've added it this time.

-- 
Sakari Ailus

  reply	other threads:[~2025-04-30  8:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30  7:36 Kieran Bingham
2025-04-30  8:45 ` Sakari Ailus [this message]
2025-04-30  8:54   ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBHjFcbjR_oPiINu@valkosipuli.retiisi.eu \
    --to=sakari.ailus@iki.fi \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®