* [net] octeontx2-af: Fix CGX Receive counters
@ 2025-05-13 7:15 Hariprasad Kelam
2025-05-15 2:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2025-05-13 7:15 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: Hariprasad Kelam, Sunil Goutham, Linu Cherian, Geetha sowjanya,
Jerin Jacob, Subbaraya Sundeep, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Christina Jacob
Each CGX block supports 4 logical MACs (LMACS). Receive
counters CGX_CMR_RX_STAT0-8 are per LMAC and CGX_CMR_RX_STAT9-12
are per CGX.
Due a bug in previous patch, stale Per CGX counters values observed.
Fixes: 66208910e57a ("octeontx2-af: Support to retrieve CGX LMAC stats")
Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
index 0b27a695008b..971993586fb4 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
@@ -717,6 +717,11 @@ int cgx_get_rx_stats(void *cgxd, int lmac_id, int idx, u64 *rx_stat)
if (!is_lmac_valid(cgx, lmac_id))
return -ENODEV;
+
+ /* pass lmac as 0 for CGX_CMR_RX_STAT9-12 */
+ if (idx >= CGX_RX_STAT_GLOBAL_INDEX)
+ lmac_id = 0;
+
*rx_stat = cgx_read(cgx, lmac_id, CGXX_CMRX_RX_STAT0 + (idx * 8));
return 0;
}
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [net] octeontx2-af: Fix CGX Receive counters
2025-05-13 7:15 [net] octeontx2-af: Fix CGX Receive counters Hariprasad Kelam
@ 2025-05-15 2:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-05-15 2:40 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: netdev, linux-kernel, sgoutham, lcherian, gakula, jerinj,
sbhatta, andrew+netdev, davem, edumazet, kuba, pabeni, cjacob
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 13 May 2025 12:45:54 +0530 you wrote:
> Each CGX block supports 4 logical MACs (LMACS). Receive
> counters CGX_CMR_RX_STAT0-8 are per LMAC and CGX_CMR_RX_STAT9-12
> are per CGX.
>
> Due a bug in previous patch, stale Per CGX counters values observed.
>
> Fixes: 66208910e57a ("octeontx2-af: Support to retrieve CGX LMAC stats")
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
>
> [...]
Here is the summary with links:
- [net] octeontx2-af: Fix CGX Receive counters
https://git.kernel.org/netdev/net/c/bf449f35e77f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-15 2:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-13 7:15 [net] octeontx2-af: Fix CGX Receive counters Hariprasad Kelam
2025-05-15 2:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®