* [PATCH 0/3] media: qcom: camss: Add qcs615 support
@ 2025-05-18 6:33 Wenmeng Liu
2025-05-18 6:33 ` [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding Wenmeng Liu
` (2 more replies)
0 siblings, 3 replies; 24+ messages in thread
From: Wenmeng Liu @ 2025-05-18 6:33 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Wenmeng Liu
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel
QCS615 is a Qualcomm flagship SoC. This series adds support to
bring up the CSIPHY, CSID, VFE/RDI interfaces in QCS615.
QCS615 provides
- 2 x VFE, 3 RDI per VFE
- 1 x VFE Lite, 4 RDI per VFE
- 2 x CSID
- 1 x CSID Lite
- 3 x CSI PHY
Tested this on QCS615 ADP AIR board with CSID TPG.
Tested with following commands:
media-ctl --reset
v4l2-ctl -d /dev/v4l-subdev3 -c test_pattern=0
media-ctl -V '"msm_csid0":0[fmt:SRGGB10/1920x1080 field:none]'
media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/1920x1080 field:none]'
media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
v4l2-ctl -d /dev/v4l-subdev3 -c test_pattern=9
yavta -B capture-mplane -n 5 -f SRGGB10P -s 1920x1080 /dev/video0 --capture=7
---
This patch series depends on patch series:
https://lore.kernel.org/all/20250424-qcs615-mm-v7-clock-controllers-v8-0-bacad5b3659a@quicinc.com
---
Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
---
Wenmeng Liu (3):
dt-bindings: media: Add qcom,qcs615-camss binding
media: qcom: camss: csiphy: Add 14nm CSIPHY 2ph DPHY v2.0.0 init sequence
media: qcom: camss: Add qcs615 camss support
.../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
.../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 85 +++++
drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
drivers/media/platform/qcom/camss/camss.c | 196 ++++++++++++
drivers/media/platform/qcom/camss/camss.h | 1 +
5 files changed, 640 insertions(+)
---
base-commit: 3e324f3a60a8b7c484c46275be0897a0f5d7fc31
change-id: 20250518-qcs615_camss-f33d85f29e6f
Best regards,
--
Wenmeng Liu <quic_wenmliu@quicinc.com>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 6:33 [PATCH 0/3] media: qcom: camss: Add qcs615 support Wenmeng Liu
@ 2025-05-18 6:33 ` Wenmeng Liu
2025-05-18 7:25 ` Rob Herring (Arm)
2025-05-18 7:53 ` Dmitry Baryshkov
2025-05-18 6:33 ` [PATCH 2/3] media: qcom: camss: csiphy: Add 14nm CSIPHY 2ph DPHY v2.0.0 init sequence Wenmeng Liu
2025-05-18 6:33 ` [PATCH 3/3] media: qcom: camss: Add qcs615 camss support Wenmeng Liu
2 siblings, 2 replies; 24+ messages in thread
From: Wenmeng Liu @ 2025-05-18 6:33 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Wenmeng Liu
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel
Add bindings for qcom,qcs615-camss in order to support the camera
subsystem for qcs615.
Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
---
.../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
1 file changed, 356 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/qcom,qcs615-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcs615-camss.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..9a87243f88d4b739cc29033509878ae706d3017f
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/qcom,qcs615-camss.yaml
@@ -0,0 +1,356 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/qcom,qcs615-camss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm QCS615 Camera Subsystem (CAMSS)
+
+maintainers:
+ - Wenmeng Liu <quic_wenmliu@quicinc.com>
+
+description:
+ The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms.
+
+properties:
+ compatible:
+ const: qcom,qcs615-camss
+
+ clocks:
+ minItems: 26
+ maxItems: 26
+
+ clock-names:
+ items:
+ - const: camnoc_axi
+ - const: cpas_ahb
+ - const: cphy_rx_src
+ - const: csiphy0
+ - const: csiphy0_timer
+ - const: csiphy1
+ - const: csiphy1_timer
+ - const: csiphy2
+ - const: csiphy2_timer
+ - const: gcc_axi_hf
+ - const: slow_ahb_src
+ - const: soc_ahb
+ - const: vfe0
+ - const: vfe0_axi
+ - const: vfe0_cphy_rx
+ - const: vfe0_csid
+ - const: vfe0_src
+ - const: vfe1
+ - const: vfe1_axi
+ - const: vfe1_cphy_rx
+ - const: vfe1_csid
+ - const: vfe1_src
+ - const: vfe_lite
+ - const: vfe_lite_cphy_rx
+ - const: vfe_lite_csid
+ - const: vfe_lite_src
+
+ interrupts:
+ minItems: 9
+ maxItems: 9
+
+ interrupt-names:
+ items:
+ - const: csid0
+ - const: csid1
+ - const: csid_lite
+ - const: csiphy0
+ - const: csiphy1
+ - const: csiphy2
+ - const: vfe0
+ - const: vfe1
+ - const: vfe_lite
+
+ iommus:
+ minItems: 3
+ maxItems: 3
+
+ interconnects:
+ minItems: 2
+ maxItems: 2
+
+ interconnect-names:
+ items:
+ - const: ahb
+ - const: hf_0_mnoc
+
+ power-domains:
+ items:
+ - description: IFE0 GDSC - Image Front End, Global Distributed Switch Controller.
+ - description: IFE1 GDSC - Image Front End, Global Distributed Switch Controller.
+ - description: Titan GDSC - Titan ISP Block, Global Distributed Switch Controller.
+
+ power-domain-names:
+ items:
+ - const: ife0
+ - const: ife1
+ - const: top
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ description:
+ CSI input ports.
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description:
+ Input port for receiving CSI data.
+
+ properties:
+ endpoint:
+ $ref: video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ clock-lanes:
+ maxItems: 1
+
+ data-lanes:
+ minItems: 1
+ maxItems: 4
+
+ bus-type:
+ enum:
+ - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
+ - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
+
+ required:
+ - clock-lanes
+ - data-lanes
+
+ port@1:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description:
+ Input port for receiving CSI data.
+
+ properties:
+ endpoint:
+ $ref: video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ clock-lanes:
+ maxItems: 1
+
+ data-lanes:
+ minItems: 1
+ maxItems: 4
+
+ bus-type:
+ enum:
+ - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
+ - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
+
+ required:
+ - clock-lanes
+ - data-lanes
+
+ port@2:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description:
+ Input port for receiving CSI data.
+
+ properties:
+ endpoint:
+ $ref: video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ clock-lanes:
+ maxItems: 1
+
+ data-lanes:
+ minItems: 1
+ maxItems: 4
+
+ bus-type:
+ enum:
+ - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
+ - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
+
+ required:
+ - clock-lanes
+ - data-lanes
+
+ reg:
+ minItems: 9
+ maxItems: 9
+
+ reg-names:
+ items:
+ - const: csid0
+ - const: csid1
+ - const: csid_lite
+ - const: csiphy0
+ - const: csiphy1
+ - const: csiphy2
+ - const: vfe0
+ - const: vfe1
+ - const: vfe_lite
+
+ vdda-phy-supply:
+ description:
+ Phandle to a regulator supply to PHY core block.
+
+ vdda-pll-supply:
+ description:
+ Phandle to 1.8V regulator supply to PHY refclk pll block.
+
+required:
+ - clock-names
+ - clocks
+ - compatible
+ - interconnects
+ - interconnect-names
+ - interrupts
+ - interrupt-names
+ - iommus
+ - power-domains
+ - reg
+ - reg-names
+ - vdda-phy-supply
+ - vdda-pll-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/qcom,rpmh.h>
+ #include <dt-bindings/clock/qcom,qcs615-camcc.h>
+ #include <dt-bindings/clock/qcom,qcs615-gcc.h>
+ #include <dt-bindings/interconnect/qcom,icc.h>
+ #include <dt-bindings/interconnect/qcom,qcs615-rpmh.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ camss: camss@acb3000 {
+ compatible = "qcom,qcs615-camss";
+
+ reg = <0x0 0x0acb3000 0x0 0x1000>,
+ <0x0 0x0acba000 0x0 0x1000>,
+ <0x0 0x0acc8000 0x0 0x1000>,
+ <0x0 0x0ac65000 0x0 0x1000>,
+ <0x0 0x0ac66000 0x0 0x1000>,
+ <0x0 0x0ac67000 0x0 0x1000>,
+ <0x0 0x0acaf000 0x0 0x4000>,
+ <0x0 0x0acb6000 0x0 0x4000>,
+ <0x0 0x0acc4000 0x0 0x4000>;
+ reg-names = "csid0",
+ "csid1",
+ "csid_lite",
+ "csiphy0",
+ "csiphy1",
+ "csiphy2",
+ "vfe0",
+ "vfe1",
+ "vfe_lite";
+
+ clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>,
+ <&camcc CAM_CC_CPAS_AHB_CLK>,
+ <&camcc CAM_CC_CPHY_RX_CLK_SRC>,
+ <&camcc CAM_CC_CSIPHY0_CLK>,
+ <&camcc CAM_CC_CSI0PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY1_CLK>,
+ <&camcc CAM_CC_CSI1PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY2_CLK>,
+ <&camcc CAM_CC_CSI2PHYTIMER_CLK>,
+ <&gcc GCC_CAMERA_HF_AXI_CLK>,
+ <&camcc CAM_CC_SLOW_AHB_CLK_SRC>,
+ <&camcc CAM_CC_SOC_AHB_CLK>,
+ <&camcc CAM_CC_IFE_0_CLK>,
+ <&camcc CAM_CC_IFE_0_AXI_CLK>,
+ <&camcc CAM_CC_IFE_0_CPHY_RX_CLK>,
+ <&camcc CAM_CC_IFE_0_CSID_CLK>,
+ <&camcc CAM_CC_IFE_0_CLK_SRC>,
+ <&camcc CAM_CC_IFE_1_CLK>,
+ <&camcc CAM_CC_IFE_1_AXI_CLK>,
+ <&camcc CAM_CC_IFE_1_CPHY_RX_CLK>,
+ <&camcc CAM_CC_IFE_1_CSID_CLK>,
+ <&camcc CAM_CC_IFE_1_CLK_SRC>,
+ <&camcc CAM_CC_IFE_LITE_CLK>,
+ <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>,
+ <&camcc CAM_CC_IFE_LITE_CSID_CLK>,
+ <&camcc CAM_CC_IFE_LITE_CLK_SRC>;
+
+ clock-names = "camnoc_axi",
+ "cpas_ahb",
+ "cphy_rx_src",
+ "csiphy0",
+ "csiphy0_timer",
+ "csiphy1",
+ "csiphy1_timer",
+ "csiphy2",
+ "csiphy2_timer",
+ "gcc_axi_hf",
+ "slow_ahb_src",
+ "soc_ahb",
+ "vfe0",
+ "vfe0_axi",
+ "vfe0_cphy_rx",
+ "vfe0_csid",
+ "vfe0_src",
+ "vfe1",
+ "vfe1_axi",
+ "vfe1_cphy_rx",
+ "vfe1_csid",
+ "vfe1_src",
+ "vfe_lite",
+ "vfe_lite_cphy_rx",
+ "vfe_lite_csid",
+ "vfe_lite_src";
+
+
+ interconnects = <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_CAMERA_CFG 0>,
+ <&mmss_noc MASTER_CAMNOC_HF0 0 &mc_virt SLAVE_EBI1 0>;
+ interconnect-names = "ahb",
+ "hf_0_mnoc";
+
+ interrupts = <GIC_SPI 464 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 466 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "csid0",
+ "csid1",
+ "csid_lite",
+ "csiphy0",
+ "csiphy1",
+ "csiphy2",
+ "vfe0",
+ "vfe1",
+ "vfe_lite";
+
+ iommus = <&apps_smmu 0x820 0x40>,
+ <&apps_smmu 0x840 0x0>,
+ <&apps_smmu 0x860 0x40>;
+
+ power-domains = <&camcc IFE_0_GDSC>,
+ <&camcc IFE_1_GDSC>,
+ <&camcc TITAN_TOP_GDSC>;
+
+ vdda-phy-supply = <&vreg_l5a_0p88>;
+ vdda-pll-supply = <&vreg_l12a_1p2>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+ };
--
2.34.1
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/3] media: qcom: camss: csiphy: Add 14nm CSIPHY 2ph DPHY v2.0.0 init sequence
2025-05-18 6:33 [PATCH 0/3] media: qcom: camss: Add qcs615 support Wenmeng Liu
2025-05-18 6:33 ` [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding Wenmeng Liu
@ 2025-05-18 6:33 ` Wenmeng Liu
2025-05-18 7:56 ` Dmitry Baryshkov
2025-05-18 6:33 ` [PATCH 3/3] media: qcom: camss: Add qcs615 camss support Wenmeng Liu
2 siblings, 1 reply; 24+ messages in thread
From: Wenmeng Liu @ 2025-05-18 6:33 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Wenmeng Liu
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel
Add a PHY configuration sequence and PHY resource for the qcs615 which
uses a Qualcomm Gen 2 version 2.0.0 CSI-2 PHY.
Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
---
.../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 80 ++++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
index f732a76de93e3e7b787d9553bf7f31e6c0596c58..3f3d875b8a74ee8f6585bebd29629bdb16eadb28 100644
--- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
+++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
@@ -64,6 +64,86 @@ struct csiphy_lane_regs {
u32 csiphy_param_type;
};
+/* GEN2 2.0 2PH DPHY mode */
+static const struct
+csiphy_lane_regs lane_regs_qcs615[] = {
+ {0x0030, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x002C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0034, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0028, 0x04, 0x00, CSIPHY_DNP_PARAMS},
+ {0x003C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x001C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0000, 0xD7, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0004, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0020, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0008, 0x04, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
+ {0x000C, 0xFF, 0x00, CSIPHY_DNP_PARAMS},
+ {0x0010, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0038, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0060, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0064, 0x3F, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0730, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x072C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0734, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0728, 0x04, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x073C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x071C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0700, 0xC0, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0704, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0720, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0708, 0x04, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
+ {0x070C, 0xFF, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0710, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0738, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0760, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0764, 0x3F, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0230, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x022C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0234, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0228, 0x04, 0x00, CSIPHY_DNP_PARAMS},
+ {0x023C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x021C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0200, 0xD7, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0204, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0220, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0208, 0x04, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
+ {0x020C, 0xFF, 0x00, CSIPHY_DNP_PARAMS},
+ {0x0210, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0238, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0260, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0264, 0x3F, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0430, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x042C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0434, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0428, 0x04, 0x00, CSIPHY_DNP_PARAMS},
+ {0x043C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x041C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0400, 0xD7, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0404, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0420, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0408, 0x04, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
+ {0x040C, 0xFF, 0x00, CSIPHY_DNP_PARAMS},
+ {0x0410, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0438, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0460, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0464, 0x3F, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0630, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x062C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0634, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0628, 0x04, 0x00, CSIPHY_DNP_PARAMS},
+ {0x063C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x061C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0600, 0xD7, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0604, 0x08, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0620, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0608, 0x04, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
+ {0x060C, 0xFF, 0x00, CSIPHY_DNP_PARAMS},
+ {0x0610, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0638, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0660, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
+ {0x0664, 0x3F, 0x00, CSIPHY_DEFAULT_PARAMS},
+};
+
/* GEN2 1.0 2PH */
static const struct
csiphy_lane_regs lane_regs_sdm845[] = {
--
2.34.1
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 3/3] media: qcom: camss: Add qcs615 camss support
2025-05-18 6:33 [PATCH 0/3] media: qcom: camss: Add qcs615 support Wenmeng Liu
2025-05-18 6:33 ` [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding Wenmeng Liu
2025-05-18 6:33 ` [PATCH 2/3] media: qcom: camss: csiphy: Add 14nm CSIPHY 2ph DPHY v2.0.0 init sequence Wenmeng Liu
@ 2025-05-18 6:33 ` Wenmeng Liu
2025-05-18 8:00 ` Dmitry Baryshkov
2 siblings, 1 reply; 24+ messages in thread
From: Wenmeng Liu @ 2025-05-18 6:33 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Wenmeng Liu
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel
Populate CAMSS with qcs615 specific hooks.
Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
---
.../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 5 +
drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
drivers/media/platform/qcom/camss/camss.c | 196 +++++++++++++++++++++
drivers/media/platform/qcom/camss/camss.h | 1 +
4 files changed, 204 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
index 3f3d875b8a74ee8f6585bebd29629bdb16eadb28..3b58b938ad419b6d482314e23b4f51aae5f8a59e 100644
--- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
+++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
@@ -824,6 +824,7 @@ static bool csiphy_is_gen2(u32 version)
bool ret = false;
switch (version) {
+ case CAMSS_615:
case CAMSS_7280:
case CAMSS_8250:
case CAMSS_8280XP:
@@ -905,6 +906,10 @@ static int csiphy_init(struct csiphy_device *csiphy)
regs->offset = 0x800;
switch (csiphy->camss->res->version) {
+ case CAMSS_615:
+ regs->lane_regs = &lane_regs_qcs615[0];
+ regs->lane_array_size = ARRAY_SIZE(lane_regs_qcs615);
+ break;
case CAMSS_845:
regs->lane_regs = &lane_regs_sdm845[0];
regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845);
diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
index 4bca6c3abaff9b898ea879674a3ff8f3592d3139..145b27cde8b6f76d44893b5c1bd9211a81b10ff5 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe.c
@@ -339,6 +339,7 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code,
return sink_code;
}
break;
+ case CAMSS_615:
case CAMSS_660:
case CAMSS_7280:
case CAMSS_8x96:
@@ -1969,6 +1970,7 @@ static int vfe_bpl_align(struct vfe_device *vfe)
int ret = 8;
switch (vfe->camss->res->version) {
+ case CAMSS_615:
case CAMSS_7280:
case CAMSS_8250:
case CAMSS_8280XP:
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 06f42875702f02f9d8d83d06ddaa972eacb593f8..29c5c3a9554e8a25eadc2c2df8108d99c65708c6 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -515,6 +515,187 @@ static const struct camss_subdev_resources vfe_res_8x96[] = {
}
};
+static const struct camss_subdev_resources csiphy_res_615[] = {
+ /* CSIPHY0 */
+ {
+ .regulators = { "vdda-phy", "vdda-pll" },
+ .clock = { "csiphy0", "csiphy0_timer" },
+ .clock_rate = { { 269333333, 384000000 },
+ { 269333333 } },
+ .reg = { "csiphy0" },
+ .interrupt = { "csiphy0" },
+ .csiphy = {
+ .id = 0,
+ .hw_ops = &csiphy_ops_3ph_1_0,
+ .formats = &csiphy_formats_sdm845
+ }
+ },
+ /* CSIPHY1 */
+ {
+ .regulators = { "vdda-phy", "vdda-pll" },
+ .clock = { "csiphy1", "csiphy1_timer" },
+ .clock_rate = { { 269333333, 384000000 },
+ { 269333333 } },
+ .reg = { "csiphy1" },
+ .interrupt = { "csiphy1" },
+ .csiphy = {
+ .id = 1,
+ .hw_ops = &csiphy_ops_3ph_1_0,
+ .formats = &csiphy_formats_sdm845
+ }
+ },
+ /* CSIPHY2 */
+ {
+ .regulators = { "vdda-phy", "vdda-pll" },
+ .clock = { "csiphy2", "csiphy2_timer" },
+ .clock_rate = { { 269333333, 384000000 },
+ { 269333333 } },
+ .reg = { "csiphy2" },
+ .interrupt = { "csiphy2" },
+ .csiphy = {
+ .id = 2,
+ .hw_ops = &csiphy_ops_3ph_1_0,
+ .formats = &csiphy_formats_sdm845
+ }
+ },
+};
+
+static const struct camss_subdev_resources csid_res_615[] = {
+ /* CSID0 */
+ {
+ .regulators = {},
+ .clock = { "cphy_rx_src", "vfe0_cphy_rx", "vfe0_csid" },
+ .clock_rate = { { 269333333, 384000000 },
+ { 269333333, 384000000 },
+ { 320000000, 540000000 } },
+ .reg = { "csid0" },
+ .interrupt = { "csid0" },
+ .csid = {
+ .is_lite = false,
+ .hw_ops = &csid_ops_gen2,
+ .parent_dev_ops = &vfe_parent_dev_ops,
+ .formats = &csid_formats_gen2
+ }
+ },
+ /* CSID1 */
+ {
+ .regulators = {},
+ .clock = { "cphy_rx_src", "vfe1_cphy_rx", "vfe1_csid" },
+ .clock_rate = { { 269333333, 384000000 },
+ { 269333333, 384000000 },
+ { 320000000, 540000000 } },
+ .reg = { "csid1" },
+ .interrupt = { "csid1" },
+ .csid = {
+ .is_lite = false,
+ .hw_ops = &csid_ops_gen2,
+ .parent_dev_ops = &vfe_parent_dev_ops,
+ .formats = &csid_formats_gen2
+ }
+ },
+ /* CSID2 */
+ {
+ .regulators = {},
+ .clock = { "cphy_rx_src", "vfe_lite_cphy_rx", "vfe_lite_csid" },
+ .clock_rate = { { 269333333, 384000000 },
+ { 269333333, 384000000 },
+ { 320000000, 540000000 } },
+ .reg = { "csid_lite" },
+ .interrupt = { "csid_lite" },
+ .csid = {
+ .is_lite = true,
+ .hw_ops = &csid_ops_gen2,
+ .parent_dev_ops = &vfe_parent_dev_ops,
+ .formats = &csid_formats_gen2
+ }
+ },
+};
+
+static const struct camss_subdev_resources vfe_res_615[] = {
+ /* VFE0 */
+ {
+ .regulators = {},
+ .clock = { "gcc_axi_hf", "camnoc_axi", "cpas_ahb", "slow_ahb_src",
+ "soc_ahb", "vfe0", "vfe0_axi"},
+ .clock_rate = { { 0 },
+ { 0 },
+ { 80000000 },
+ { 80000000 },
+ { 37500000, 40000000 },
+ { 360000000, 432000000, 540000000, 600000000 },
+ { 265000000, 426000000 } },
+ .reg = { "vfe0" },
+ .interrupt = { "vfe0" },
+ .vfe = {
+ .line_num = 3,
+ .is_lite = false,
+ .has_pd = true,
+ .pd_name = "ife0",
+ .hw_ops = &vfe_ops_170,
+ .formats_rdi = &vfe_formats_rdi_845,
+ .formats_pix = &vfe_formats_pix_845
+ }
+ },
+ /* VFE1 */
+ {
+ .regulators = {},
+ .clock = { "gcc_axi_hf", "camnoc_axi", "cpas_ahb", "slow_ahb_src",
+ "soc_ahb", "vfe1", "vfe1_axi"},
+ .clock_rate = { { 0 },
+ { 0 },
+ { 80000000 },
+ { 80000000 },
+ { 37500000, 40000000 },
+ { 360000000, 432000000, 540000000, 600000000 },
+ { 265000000, 426000000 } },
+ .reg = { "vfe1" },
+ .interrupt = { "vfe1" },
+ .vfe = {
+ .line_num = 3,
+ .is_lite = false,
+ .has_pd = true,
+ .pd_name = "ife1",
+ .hw_ops = &vfe_ops_170,
+ .formats_rdi = &vfe_formats_rdi_845,
+ .formats_pix = &vfe_formats_pix_845
+ }
+ },
+ /* VFE2 */
+ {
+ .regulators = {},
+ .clock = { "gcc_axi_hf", "camnoc_axi", "cpas_ahb", "slow_ahb_src",
+ "soc_ahb", "vfe_lite" },
+ .clock_rate = { { 0 },
+ { 0 },
+ { 80000000 },
+ { 80000000 },
+ { 37500000, 40000000 },
+ { 360000000, 432000000, 540000000, 600000000 } },
+ .reg = { "vfe_lite" },
+ .interrupt = { "vfe_lite" },
+ .vfe = {
+ .line_num = 4,
+ .is_lite = true,
+ .hw_ops = &vfe_ops_170,
+ .formats_rdi = &vfe_formats_rdi_845,
+ .formats_pix = &vfe_formats_pix_845
+ }
+ },
+};
+
+static const struct resources_icc icc_res_qcs615[] = {
+ {
+ .name = "ahb",
+ .icc_bw_tbl.avg = 38400,
+ .icc_bw_tbl.peak = 76800,
+ },
+ {
+ .name = "hf_0_mnoc",
+ .icc_bw_tbl.avg = 2097152,
+ .icc_bw_tbl.peak = 2097152,
+ },
+};
+
static const struct camss_subdev_resources csiphy_res_660[] = {
/* CSIPHY0 */
{
@@ -3753,6 +3934,20 @@ static const struct camss_resources msm8996_resources = {
.link_entities = camss_link_entities
};
+static const struct camss_resources qcs615_resources = {
+ .version = CAMSS_615,
+ .pd_name = "top",
+ .csiphy_res = csiphy_res_615,
+ .csid_res = csid_res_615,
+ .vfe_res = vfe_res_615,
+ .icc_res = icc_res_qcs615,
+ .icc_path_num = ARRAY_SIZE(icc_res_qcs615),
+ .csiphy_num = ARRAY_SIZE(csiphy_res_615),
+ .csid_num = ARRAY_SIZE(csid_res_615),
+ .vfe_num = ARRAY_SIZE(vfe_res_615),
+ .link_entities = camss_link_entities
+};
+
static const struct camss_resources sdm660_resources = {
.version = CAMSS_660,
.csiphy_res = csiphy_res_660,
@@ -3865,6 +4060,7 @@ static const struct of_device_id camss_dt_match[] = {
{ .compatible = "qcom,msm8916-camss", .data = &msm8916_resources },
{ .compatible = "qcom,msm8953-camss", .data = &msm8953_resources },
{ .compatible = "qcom,msm8996-camss", .data = &msm8996_resources },
+ { .compatible = "qcom,qcs615-camss", .data = &qcs615_resources },
{ .compatible = "qcom,sc7280-camss", .data = &sc7280_resources },
{ .compatible = "qcom,sc8280xp-camss", .data = &sc8280xp_resources },
{ .compatible = "qcom,sdm660-camss", .data = &sdm660_resources },
diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
index 63c0afee154a02194820016ccf554620d6521c8b..04e2359fccd5f61b27692caadf2855a1fde31ed9 100644
--- a/drivers/media/platform/qcom/camss/camss.h
+++ b/drivers/media/platform/qcom/camss/camss.h
@@ -77,6 +77,7 @@ enum pm_domain {
};
enum camss_version {
+ CAMSS_615,
CAMSS_660,
CAMSS_7280,
CAMSS_8x16,
--
2.34.1
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 6:33 ` [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding Wenmeng Liu
@ 2025-05-18 7:25 ` Rob Herring (Arm)
2025-05-18 8:26 ` Rob Herring (Arm)
` (15 more replies)
2025-05-18 7:53 ` Dmitry Baryshkov
1 sibling, 16 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-18 7:25 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 6:33 ` [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding Wenmeng Liu
2025-05-18 7:25 ` Rob Herring (Arm)
@ 2025-05-18 7:53 ` Dmitry Baryshkov
1 sibling, 0 replies; 24+ messages in thread
From: Dmitry Baryshkov @ 2025-05-18 7:53 UTC (permalink / raw)
To: Wenmeng Liu
Cc: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, linux-media, devicetree,
linux-kernel
On Sun, May 18, 2025 at 02:33:07PM +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,qcs615-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcs615-camss.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..9a87243f88d4b739cc29033509878ae706d3017f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,qcs615-camss.yaml
> @@ -0,0 +1,356 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/qcom,qcs615-camss.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm QCS615 Camera Subsystem (CAMSS)
> +
[...]
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmh.h>
> + #include <dt-bindings/clock/qcom,qcs615-camcc.h>
> + #include <dt-bindings/clock/qcom,qcs615-gcc.h>
Could you please update internal guidelines: when adding support for new
hardware, don't use bindings for clock controllers, use ephemeral clocks
instead. See below.
> + #include <dt-bindings/interconnect/qcom,icc.h>
> + #include <dt-bindings/interconnect/qcom,qcs615-rpmh.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/qcom-rpmpd.h>
> +
> +
> + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>,
> + <&camcc CAM_CC_CPAS_AHB_CLK>,
So this can become <&camcc_camnoc_axi_clk>, <&camnoc_cpas_ahb_clk>, etc.
> + <&camcc CAM_CC_CPHY_RX_CLK_SRC>,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/3] media: qcom: camss: csiphy: Add 14nm CSIPHY 2ph DPHY v2.0.0 init sequence
2025-05-18 6:33 ` [PATCH 2/3] media: qcom: camss: csiphy: Add 14nm CSIPHY 2ph DPHY v2.0.0 init sequence Wenmeng Liu
@ 2025-05-18 7:56 ` Dmitry Baryshkov
0 siblings, 0 replies; 24+ messages in thread
From: Dmitry Baryshkov @ 2025-05-18 7:56 UTC (permalink / raw)
To: Wenmeng Liu
Cc: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, linux-media, devicetree,
linux-kernel
On Sun, May 18, 2025 at 02:33:08PM +0800, Wenmeng Liu wrote:
> Add a PHY configuration sequence and PHY resource for the qcs615 which
> uses a Qualcomm Gen 2 version 2.0.0 CSI-2 PHY.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 80 ++++++++++++++++++++++
> 1 file changed, 80 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> index f732a76de93e3e7b787d9553bf7f31e6c0596c58..3f3d875b8a74ee8f6585bebd29629bdb16eadb28 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> @@ -64,6 +64,86 @@ struct csiphy_lane_regs {
> u32 csiphy_param_type;
> };
>
> +/* GEN2 2.0 2PH DPHY mode */
> +static const struct
> +csiphy_lane_regs lane_regs_qcs615[] = {
You are adding an object without no references. Most likely it will
trigger "unused" warning. Please also reference it from csiphy_init() in
the same commit.
> + {0x0030, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x002C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
Lowercase hex.
> + {0x0034, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0028, 0x04, 0x00, CSIPHY_DNP_PARAMS},
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 3/3] media: qcom: camss: Add qcs615 camss support
2025-05-18 6:33 ` [PATCH 3/3] media: qcom: camss: Add qcs615 camss support Wenmeng Liu
@ 2025-05-18 8:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 24+ messages in thread
From: Dmitry Baryshkov @ 2025-05-18 8:00 UTC (permalink / raw)
To: Wenmeng Liu
Cc: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, linux-media, devicetree,
linux-kernel
On Sun, May 18, 2025 at 02:33:09PM +0800, Wenmeng Liu wrote:
> Populate CAMSS with qcs615 specific hooks.
QCS615
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 5 +
> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
> drivers/media/platform/qcom/camss/camss.c | 196 +++++++++++++++++++++
> drivers/media/platform/qcom/camss/camss.h | 1 +
> 4 files changed, 204 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> index 3f3d875b8a74ee8f6585bebd29629bdb16eadb28..3b58b938ad419b6d482314e23b4f51aae5f8a59e 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> @@ -824,6 +824,7 @@ static bool csiphy_is_gen2(u32 version)
> bool ret = false;
>
> switch (version) {
> + case CAMSS_615:
> case CAMSS_7280:
> case CAMSS_8250:
> case CAMSS_8280XP:
> @@ -905,6 +906,10 @@ static int csiphy_init(struct csiphy_device *csiphy)
> regs->offset = 0x800;
>
> switch (csiphy->camss->res->version) {
> + case CAMSS_615:
> + regs->lane_regs = &lane_regs_qcs615[0];
> + regs->lane_array_size = ARRAY_SIZE(lane_regs_qcs615);
> + break;
> case CAMSS_845:
> regs->lane_regs = &lane_regs_sdm845[0];
> regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845);
This definitely should be a part of the previous commit.
> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
> index 63c0afee154a02194820016ccf554620d6521c8b..04e2359fccd5f61b27692caadf2855a1fde31ed9 100644
> --- a/drivers/media/platform/qcom/camss/camss.h
> +++ b/drivers/media/platform/qcom/camss/camss.h
> @@ -77,6 +77,7 @@ enum pm_domain {
> };
>
> enum camss_version {
> + CAMSS_615,
> CAMSS_660,
> CAMSS_7280,
> CAMSS_8x16,
And, as a dependency, this chunk.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
@ 2025-05-18 8:26 ` Rob Herring (Arm)
2025-05-18 9:26 ` Rob Herring (Arm)
` (14 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-18 8:26 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
2025-05-18 8:26 ` Rob Herring (Arm)
@ 2025-05-18 9:26 ` Rob Herring (Arm)
2025-05-18 19:29 ` Rob Herring (Arm)
` (13 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-18 9:26 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
2025-05-18 8:26 ` Rob Herring (Arm)
2025-05-18 9:26 ` Rob Herring (Arm)
@ 2025-05-18 19:29 ` Rob Herring (Arm)
2025-05-19 0:00 ` Rob Herring (Arm)
` (12 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-18 19:29 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (2 preceding siblings ...)
2025-05-18 19:29 ` Rob Herring (Arm)
@ 2025-05-19 0:00 ` Rob Herring (Arm)
2025-05-19 0:31 ` Rob Herring (Arm)
` (11 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 0:00 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (3 preceding siblings ...)
2025-05-19 0:00 ` Rob Herring (Arm)
@ 2025-05-19 0:31 ` Rob Herring (Arm)
2025-05-19 3:16 ` Rob Herring (Arm)
` (10 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 0:31 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (4 preceding siblings ...)
2025-05-19 0:31 ` Rob Herring (Arm)
@ 2025-05-19 3:16 ` Rob Herring (Arm)
2025-05-19 4:32 ` Rob Herring (Arm)
` (9 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 3:16 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (5 preceding siblings ...)
2025-05-19 3:16 ` Rob Herring (Arm)
@ 2025-05-19 4:32 ` Rob Herring (Arm)
2025-05-19 6:32 ` Rob Herring (Arm)
` (8 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 4:32 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (6 preceding siblings ...)
2025-05-19 4:32 ` Rob Herring (Arm)
@ 2025-05-19 6:32 ` Rob Herring (Arm)
2025-05-19 7:18 ` Rob Herring (Arm)
` (7 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 6:32 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (7 preceding siblings ...)
2025-05-19 6:32 ` Rob Herring (Arm)
@ 2025-05-19 7:18 ` Rob Herring (Arm)
2025-05-19 8:18 ` Rob Herring (Arm)
` (6 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 7:18 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (8 preceding siblings ...)
2025-05-19 7:18 ` Rob Herring (Arm)
@ 2025-05-19 8:18 ` Rob Herring (Arm)
2025-05-19 9:18 ` Rob Herring (Arm)
` (5 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 8:18 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (9 preceding siblings ...)
2025-05-19 8:18 ` Rob Herring (Arm)
@ 2025-05-19 9:18 ` Rob Herring (Arm)
2025-05-19 9:34 ` Rob Herring (Arm)
` (4 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 9:18 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (10 preceding siblings ...)
2025-05-19 9:18 ` Rob Herring (Arm)
@ 2025-05-19 9:34 ` Rob Herring (Arm)
2025-05-19 9:49 ` Rob Herring (Arm)
` (3 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 9:34 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (11 preceding siblings ...)
2025-05-19 9:34 ` Rob Herring (Arm)
@ 2025-05-19 9:49 ` Rob Herring (Arm)
2025-05-19 10:34 ` Rob Herring (Arm)
` (2 subsequent siblings)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 9:49 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (12 preceding siblings ...)
2025-05-19 9:49 ` Rob Herring (Arm)
@ 2025-05-19 10:34 ` Rob Herring (Arm)
2025-05-19 11:19 ` Rob Herring (Arm)
2025-05-19 11:35 ` Rob Herring (Arm)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 10:34 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (13 preceding siblings ...)
2025-05-19 10:34 ` Rob Herring (Arm)
@ 2025-05-19 11:19 ` Rob Herring (Arm)
2025-05-19 11:35 ` Rob Herring (Arm)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 11:19 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding
2025-05-18 7:25 ` Rob Herring (Arm)
` (14 preceding siblings ...)
2025-05-19 11:19 ` Rob Herring (Arm)
@ 2025-05-19 11:35 ` Rob Herring (Arm)
15 siblings, 0 replies; 24+ messages in thread
From: Rob Herring (Arm) @ 2025-05-19 11:35 UTC (permalink / raw)
To: Wenmeng Liu
Cc: linux-media, Robert Foss, Conor Dooley, devicetree,
Krzysztof Kozlowski, linux-arm-msm, Bryan O'Donoghue,
Todor Tomov, linux-kernel, Mauro Carvalho Chehab
On Sun, 18 May 2025 14:33:07 +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../bindings/media/qcom,qcs615-camss.yaml | 356 +++++++++++++++++++++
> 1 file changed, 356 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-camcc.h: No such file or directory
25 | #include <dt-bindings/clock/qcom,qcs615-camcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/media/qcom,qcs615-camss.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250518-qcs615_camss-v1-1-12723e26ea3e@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2025-05-19 11:35 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-18 6:33 [PATCH 0/3] media: qcom: camss: Add qcs615 support Wenmeng Liu
2025-05-18 6:33 ` [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding Wenmeng Liu
2025-05-18 7:25 ` Rob Herring (Arm)
2025-05-18 8:26 ` Rob Herring (Arm)
2025-05-18 9:26 ` Rob Herring (Arm)
2025-05-18 19:29 ` Rob Herring (Arm)
2025-05-19 0:00 ` Rob Herring (Arm)
2025-05-19 0:31 ` Rob Herring (Arm)
2025-05-19 3:16 ` Rob Herring (Arm)
2025-05-19 4:32 ` Rob Herring (Arm)
2025-05-19 6:32 ` Rob Herring (Arm)
2025-05-19 7:18 ` Rob Herring (Arm)
2025-05-19 8:18 ` Rob Herring (Arm)
2025-05-19 9:18 ` Rob Herring (Arm)
2025-05-19 9:34 ` Rob Herring (Arm)
2025-05-19 9:49 ` Rob Herring (Arm)
2025-05-19 10:34 ` Rob Herring (Arm)
2025-05-19 11:19 ` Rob Herring (Arm)
2025-05-19 11:35 ` Rob Herring (Arm)
2025-05-18 7:53 ` Dmitry Baryshkov
2025-05-18 6:33 ` [PATCH 2/3] media: qcom: camss: csiphy: Add 14nm CSIPHY 2ph DPHY v2.0.0 init sequence Wenmeng Liu
2025-05-18 7:56 ` Dmitry Baryshkov
2025-05-18 6:33 ` [PATCH 3/3] media: qcom: camss: Add qcs615 camss support Wenmeng Liu
2025-05-18 8:00 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®