* [PATCH] spi: loongson: Fix build warnings about export.h
@ 2025-06-08 14:29 Huacai Chen
2025-06-09 0:40 ` Masahiro Yamada
2025-06-09 13:40 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Huacai Chen @ 2025-06-08 14:29 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild, Mark Brown, Yinbo Zhu, Huacai Chen
Cc: linux-spi, linux-kernel, Xuerui Wang, Jiaxun Yang, Huacai Chen
After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1"), we get some build
warnings with W=1:
drivers/spi/spi-loongson-core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
So fix these build warnings for SPI/Loongson.
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
drivers/spi/spi-loongson-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-loongson-core.c b/drivers/spi/spi-loongson-core.c
index 4fec226456d1..b46f072a0387 100644
--- a/drivers/spi/spi-loongson-core.c
+++ b/drivers/spi/spi-loongson-core.c
@@ -5,6 +5,7 @@
#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/err.h>
+#include <linux/export.h>
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/io.h>
--
2.47.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: loongson: Fix build warnings about export.h
2025-06-08 14:29 [PATCH] spi: loongson: Fix build warnings about export.h Huacai Chen
@ 2025-06-09 0:40 ` Masahiro Yamada
2025-06-09 13:40 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2025-06-09 0:40 UTC (permalink / raw)
To: Huacai Chen
Cc: linux-kbuild, Mark Brown, Yinbo Zhu, Huacai Chen, linux-spi,
linux-kernel, Xuerui Wang, Jiaxun Yang
On Sun, Jun 8, 2025 at 11:29 PM Huacai Chen <chenhuacai@loongson.cn> wrote:
>
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
>
> drivers/spi/spi-loongson-core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> So fix these build warnings for SPI/Loongson.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Thank you for your contribution.
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: loongson: Fix build warnings about export.h
2025-06-08 14:29 [PATCH] spi: loongson: Fix build warnings about export.h Huacai Chen
2025-06-09 0:40 ` Masahiro Yamada
@ 2025-06-09 13:40 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2025-06-09 13:40 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild, Yinbo Zhu, Huacai Chen, Huacai Chen
Cc: linux-spi, linux-kernel, Xuerui Wang, Jiaxun Yang
On Sun, 08 Jun 2025 22:29:39 +0800, Huacai Chen wrote:
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
>
> drivers/spi/spi-loongson-core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: loongson: Fix build warnings about export.h
commit: 1dd630088332b5b310f3dd7eaacae9f3c4465651
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-09 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-08 14:29 [PATCH] spi: loongson: Fix build warnings about export.h Huacai Chen
2025-06-09 0:40 ` Masahiro Yamada
2025-06-09 13:40 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®