* [PATCH 2/2] ARM: dts: BCM5301X: Add support for Buffalo WXR-1750DHP
2025-06-25 15:43 [PATCH 1/2] dt-bindings: arm: bcm: Add support for Buffalo WXR-1750DHP Taishi Shimizu
@ 2025-06-25 15:43 ` Taishi Shimizu
2025-07-08 8:34 ` Krzysztof Kozlowski
2025-06-25 21:16 ` [PATCH 1/2] dt-bindings: arm: bcm: " Rob Herring (Arm)
2025-07-08 8:35 ` Krzysztof Kozlowski
2 siblings, 1 reply; 6+ messages in thread
From: Taishi Shimizu @ 2025-06-25 15:43 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Hauke Mehrtens,
Rafal Milecki, Florian Fainelli
Cc: linux-arm-kernel, devicetree, linux-kernel,
Broadcom internal kernel review list, Linus Walleij,
Stefan Wahren, Taishi Shimizu
Add initial device tree support for the Buffalo WXR-1750DHP, a consumer Wi-Fi
router based on the Broadcom BCM4708A0 SoC.
Hardware specifications:
* Processor: Broadcom BCM4708A0 dual-core @ 800 MHz
* RAM: DDR3 256 MB
* Ethernet Switch: Broadcom BCM53011 integrated via SRAB
* NAND Flash: 128 MB (8-bit ECC)
* SPI Flash: None
* Ports: 4 LAN Ports, 1 WAN Port
* USB: 1x USB 3.0 Type-A port
Signed-off-by: Taishi Shimizu <s.taishi14142@gmail.com>
---
arch/arm/boot/dts/broadcom/Makefile | 1 +
.../broadcom/bcm4708-buffalo-wxr-1750dhp.dts | 134 ++++++++++++++++++
2 files changed, 135 insertions(+)
create mode 100644 arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dts
diff --git a/arch/arm/boot/dts/broadcom/Makefile b/arch/arm/boot/dts/broadcom/Makefile
index 71062ff9adbe..2552e11b5e31 100644
--- a/arch/arm/boot/dts/broadcom/Makefile
+++ b/arch/arm/boot/dts/broadcom/Makefile
@@ -51,6 +51,7 @@ dtb-$(CONFIG_ARCH_BCMBCA) += \
dtb-$(CONFIG_ARCH_BCM_5301X) += \
bcm4708-asus-rt-ac56u.dtb \
bcm4708-asus-rt-ac68u.dtb \
+ bcm4708-buffalo-wxr-1750dhp.dtb \
bcm4708-buffalo-wzr-1750dhp.dtb \
bcm4708-buffalo-wzr-1166dhp.dtb \
bcm4708-buffalo-wzr-1166dhp2.dtb \
diff --git a/arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dts b/arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dts
new file mode 100644
index 000000000000..43a4a8e58b40
--- /dev/null
+++ b/arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dts
@@ -0,0 +1,134 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Author: Taishi Shimizu <s.taishi14142@gmail.com>
+ */
+
+/dts-v1/;
+
+#include "bcm4708.dtsi"
+#include "bcm5301x-nand-cs0-bch8.dtsi"
+
+/ {
+ compatible = "buffalo,wxr-1750dhp", "brcm,bcm4708";
+ model = "Buffalo WXR-1750DHP";
+
+ chosen {
+ bootargs = "console=ttyS0,115200";
+ };
+
+ memory@0 {
+ reg = <0x00000000 0x08000000>,
+ <0x88000000 0x08000000>;
+ device_type = "memory";
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ button-aoss {
+ label = "AOSS";
+ linux,code = <KEY_WPS_BUTTON>;
+ gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
+ };
+
+ /* GPIO 8 and 9 are a tri-state switch button with
+ * ROUTER / AP / WB.
+ */
+ button-bridge {
+ label = "WB";
+ linux,code = <BTN_2>;
+ linux,input-type = <EV_SW>;
+ gpios = <&chipcommon 8 GPIO_ACTIVE_HIGH>;
+ };
+
+ /* GPIO 3 is a switch button with AUTO / MANUAL. */
+ button-manual {
+ label = "MANUAL";
+ linux,code = <BTN_0>;
+ linux,input-type = <EV_SW>;
+ gpios = <&chipcommon 3 GPIO_ACTIVE_HIGH>;
+ };
+
+ button-restart {
+ label = "Reset";
+ linux,code = <KEY_RESTART>;
+ gpios = <&chipcommon 11 GPIO_ACTIVE_LOW>;
+ };
+
+ button-router {
+ label = "ROUTER";
+ linux,code = <BTN_1>;
+ linux,input-type = <EV_SW>;
+ gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ led-power0 {
+ label = "bcm53xx:white:power";
+ linux,default-trigger = "default-on";
+ gpios = <&chipcommon 5 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-power1 {
+ label = "bcm53xx:amber:power";
+ gpios = <&chipcommon 6 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-router0 {
+ label = "bcm53xx:amber:router";
+ gpios = <&chipcommon 14 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-router1 {
+ label = "bcm53xx:white:router";
+ gpios = <&chipcommon 15 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-usb {
+ label = "bcm53xx:green:usb";
+ gpios = <&chipcommon 4 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-wan {
+ label = "bcm53xx:white:wan";
+ gpios = <&chipcommon 7 GPIO_ACTIVE_HIGH>;
+ };
+ };
+};
+
+&srab {
+ status = "okay";
+
+ ports {
+ port@0 {
+ label = "wan";
+ };
+
+ port@1 {
+ label = "lan4";
+ };
+
+ port@2 {
+ label = "lan3";
+ };
+
+ port@3 {
+ label = "lan2";
+ };
+
+ port@4 {
+ label = "lan1";
+ };
+ };
+};
+
+&usb3 {
+ vcc-gpio = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
+};
+
+&usb3_phy {
+ status = "okay";
+};
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ARM: dts: BCM5301X: Add support for Buffalo WXR-1750DHP
2025-06-25 15:43 ` [PATCH 2/2] ARM: dts: BCM5301X: " Taishi Shimizu
@ 2025-07-08 8:34 ` Krzysztof Kozlowski
2025-07-10 8:49 ` Taishi Shimizu
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-08 8:34 UTC (permalink / raw)
To: Taishi Shimizu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Hauke Mehrtens,
Rafal Milecki, Florian Fainelli, linux-arm-kernel, devicetree,
linux-kernel, Broadcom internal kernel review list,
Linus Walleij, Stefan Wahren
On Thu, Jun 26, 2025 at 12:43:15AM +0900, Taishi Shimizu wrote:
> +
> +#include "bcm4708.dtsi"
> +#include "bcm5301x-nand-cs0-bch8.dtsi"
> +
> +/ {
> + compatible = "buffalo,wxr-1750dhp", "brcm,bcm4708";
> + model = "Buffalo WXR-1750DHP";
> +
> + chosen {
> + bootargs = "console=ttyS0,115200";
Please use stdout path property.
> + };
> +
> + memory@0 {
> + reg = <0x00000000 0x08000000>,
> + <0x88000000 0x08000000>;
> + device_type = "memory";
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + button-aoss {
> + label = "AOSS";
> + linux,code = <KEY_WPS_BUTTON>;
> + gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* GPIO 8 and 9 are a tri-state switch button with
> + * ROUTER / AP / WB.
> + */
> + button-bridge {
> + label = "WB";
> + linux,code = <BTN_2>;
> + linux,input-type = <EV_SW>;
> + gpios = <&chipcommon 8 GPIO_ACTIVE_HIGH>;
> + };
> +
> + /* GPIO 3 is a switch button with AUTO / MANUAL. */
> + button-manual {
> + label = "MANUAL";
> + linux,code = <BTN_0>;
> + linux,input-type = <EV_SW>;
> + gpios = <&chipcommon 3 GPIO_ACTIVE_HIGH>;
> + };
> +
> + button-restart {
> + label = "Reset";
> + linux,code = <KEY_RESTART>;
> + gpios = <&chipcommon 11 GPIO_ACTIVE_LOW>;
> + };
> +
> + button-router {
> + label = "ROUTER";
> + linux,code = <BTN_1>;
> + linux,input-type = <EV_SW>;
> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led-power0 {
> + label = "bcm53xx:white:power";
You should use rather color and function properties.
> + linux,default-trigger = "default-on";
> + gpios = <&chipcommon 5 GPIO_ACTIVE_HIGH>;
> + };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ARM: dts: BCM5301X: Add support for Buffalo WXR-1750DHP
2025-07-08 8:34 ` Krzysztof Kozlowski
@ 2025-07-10 8:49 ` Taishi Shimizu
0 siblings, 0 replies; 6+ messages in thread
From: Taishi Shimizu @ 2025-07-10 8:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Taishi Shimizu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Hauke Mehrtens, Rafal Milecki, Florian Fainelli,
linux-arm-kernel, devicetree, linux-kernel,
bcm-kernel-feedback-list, Linus Walleij, Stefan Wahren
On Tue, Jul 8, 2025 at 10:34 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Thu, Jun 26, 2025 at 12:43:15AM +0900, Taishi Shimizu wrote:
> > + chosen {
> > + bootargs = "console=ttyS0,115200";
>
> Please use stdout path property.
Thanks for the review. Since `stdout-path` is already defined in
`bcm4708.dtsi`, I removed the `chosen` node from the board DTS.
> + leds {
> + compatible = "gpio-leds";
> +
> > + led-power0 {
> > + label = "bcm53xx:white:power";
>
> You should use rather color and function properties.
I replaced all `label` properties in the LED definitions with `color` and
`function` properties as appropriate.
I'll send v2 accordingly. Thanks!
Best regards,
Taishi Shimizu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: bcm: Add support for Buffalo WXR-1750DHP
2025-06-25 15:43 [PATCH 1/2] dt-bindings: arm: bcm: Add support for Buffalo WXR-1750DHP Taishi Shimizu
2025-06-25 15:43 ` [PATCH 2/2] ARM: dts: BCM5301X: " Taishi Shimizu
@ 2025-06-25 21:16 ` Rob Herring (Arm)
2025-07-08 8:35 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-06-25 21:16 UTC (permalink / raw)
To: Taishi Shimizu
Cc: Rafal Milecki, linux-kernel, Conor Dooley, Stefan Wahren,
Florian Fainelli, Hauke Mehrtens, linux-arm-kernel,
Broadcom internal kernel review list, Linus Walleij,
Krzysztof Kozlowski, devicetree
On Thu, 26 Jun 2025 00:43:14 +0900, Taishi Shimizu wrote:
> Add Buffalo WXR-1750DHP under BCM4708 based boards.
>
> Signed-off-by: Taishi Shimizu <s.taishi14142@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250625 (exact match)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/broadcom/' for 20250625154315.114139-1-s.taishi14142@gmail.com:
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: /axi@18000000: failed to match any schema with compatible: ['brcm,bus-axi']
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@12000: 'device_type' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@12000: 'ranges' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@13000: 'device_type' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@13000: 'ranges' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@14000: 'device_type' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: pcie@14000: 'ranges' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@18007000 (brcm,bcm53011-srab): ports:port@5: 'phy-mode' is a required property
from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@18007000 (brcm,bcm53011-srab): ports:port@5: 'oneOf' conditional failed, one must be fixed:
'fixed-link' is a required property
'phy-handle' is a required property
'managed' is a required property
from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@18007000 (brcm,bcm53011-srab): ports:port@7: 'phy-mode' is a required property
from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@18007000 (brcm,bcm53011-srab): ports:port@7: 'oneOf' conditional failed, one must be fixed:
'fixed-link' is a required property
'phy-handle' is a required property
'managed' is a required property
from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@18007000 (brcm,bcm53011-srab): ports:port@8: 'phy-mode' is a required property
from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
arch/arm/boot/dts/broadcom/bcm4708-buffalo-wxr-1750dhp.dtb: ethernet-switch@18007000 (brcm,bcm53011-srab): Unevaluated properties are not allowed ('ports' was unexpected)
from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] dt-bindings: arm: bcm: Add support for Buffalo WXR-1750DHP
2025-06-25 15:43 [PATCH 1/2] dt-bindings: arm: bcm: Add support for Buffalo WXR-1750DHP Taishi Shimizu
2025-06-25 15:43 ` [PATCH 2/2] ARM: dts: BCM5301X: " Taishi Shimizu
2025-06-25 21:16 ` [PATCH 1/2] dt-bindings: arm: bcm: " Rob Herring (Arm)
@ 2025-07-08 8:35 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-08 8:35 UTC (permalink / raw)
To: Taishi Shimizu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Hauke Mehrtens,
Rafal Milecki, Florian Fainelli, linux-arm-kernel, devicetree,
linux-kernel, Broadcom internal kernel review list,
Linus Walleij, Stefan Wahren
On Thu, Jun 26, 2025 at 12:43:14AM +0900, Taishi Shimizu wrote:
> Add Buffalo WXR-1750DHP under BCM4708 based boards.
>
> Signed-off-by: Taishi Shimizu <s.taishi14142@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
<form letter>
This is an automated instruction, just in case, because many review
tags are being ignored. If you know the process, just skip it entirely
(please do not feel offended by me posting it here - no bad intentions
intended, no patronizing, I just want to avoid wasted efforts). If you
do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here ('b4 trailers -u ...').
However, there's no need to repost patches *only* to add the tags. The
upstream maintainer will do that for tags received on the version they
apply.
https://elixir.bootlin.com/linux/v6.15/source/Documentation/process/submitting-patches.rst#L591
</form letter>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread