* [PATCH 2/2] drivers/panel: raydium-rm67200: Make reset-gpio optional
2025-06-16 7:05 [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200 Andy Yan
@ 2025-06-16 7:05 ` Andy Yan
2025-06-19 13:34 ` Sebastian Reichel
2025-06-19 13:12 ` [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200 Sebastian Reichel
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Andy Yan @ 2025-06-16 7:05 UTC (permalink / raw)
To: neil.armstrong
Cc: conor+dt, quic_jesszhan, krzk+dt, robh, sebastian.reichel,
tzimmermann, devicetree, dri-devel, linux-kernel, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
Although the datasheet of the panel module describes that it has a
reset pin, in the actual hardware design, we often use an RC circuit
to control the reset, and rarely use GPIO to control the reset. This
is the way it is done on our numerous development boards (such as
RK3568/RK3576 EVB).
So make the reset-gpio optional.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
drivers/gpu/drm/panel/panel-raydium-rm67200.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-raydium-rm67200.c b/drivers/gpu/drm/panel/panel-raydium-rm67200.c
index 205273163cb97..add6099ae8a64 100644
--- a/drivers/gpu/drm/panel/panel-raydium-rm67200.c
+++ b/drivers/gpu/drm/panel/panel-raydium-rm67200.c
@@ -36,12 +36,14 @@ static inline struct raydium_rm67200 *to_raydium_rm67200(struct drm_panel *panel
static void raydium_rm67200_reset(struct raydium_rm67200 *ctx)
{
- gpiod_set_value_cansleep(ctx->reset_gpio, 0);
- msleep(60);
- gpiod_set_value_cansleep(ctx->reset_gpio, 1);
- msleep(60);
- gpiod_set_value_cansleep(ctx->reset_gpio, 0);
- msleep(60);
+ if (ctx->reset_gpio) {
+ gpiod_set_value_cansleep(ctx->reset_gpio, 0);
+ msleep(60);
+ gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+ msleep(60);
+ gpiod_set_value_cansleep(ctx->reset_gpio, 0);
+ msleep(60);
+ }
}
static void raydium_rm67200_write(struct mipi_dsi_multi_context *ctx,
@@ -412,7 +414,7 @@ static int raydium_rm67200_probe(struct mipi_dsi_device *dsi)
if (ret < 0)
return ret;
- ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
+ ctx->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(ctx->reset_gpio))
return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
"Failed to get reset-gpios\n");
--
2.43.0
base-commit: 8c98c2c9ebeaa472e742d664b714aed5ab7c6f53
branch: rk356x_rk3588_rk3576_dsi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] drivers/panel: raydium-rm67200: Make reset-gpio optional
2025-06-16 7:05 ` [PATCH 2/2] drivers/panel: raydium-rm67200: Make reset-gpio optional Andy Yan
@ 2025-06-19 13:34 ` Sebastian Reichel
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2025-06-19 13:34 UTC (permalink / raw)
To: Andy Yan
Cc: neil.armstrong, conor+dt, quic_jesszhan, krzk+dt, robh,
tzimmermann, devicetree, dri-devel, linux-kernel, Andy Yan
[-- Attachment #1: Type: text/plain, Size: 2263 bytes --]
Hi,
On Mon, Jun 16, 2025 at 03:05:17PM +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> Although the datasheet of the panel module describes that it has a
> reset pin, in the actual hardware design, we often use an RC circuit
> to control the reset, and rarely use GPIO to control the reset. This
> is the way it is done on our numerous development boards (such as
> RK3568/RK3576 EVB).
>
> So make the reset-gpio optional.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Greetings,
-- Sebastian
>
> drivers/gpu/drm/panel/panel-raydium-rm67200.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-raydium-rm67200.c b/drivers/gpu/drm/panel/panel-raydium-rm67200.c
> index 205273163cb97..add6099ae8a64 100644
> --- a/drivers/gpu/drm/panel/panel-raydium-rm67200.c
> +++ b/drivers/gpu/drm/panel/panel-raydium-rm67200.c
> @@ -36,12 +36,14 @@ static inline struct raydium_rm67200 *to_raydium_rm67200(struct drm_panel *panel
>
> static void raydium_rm67200_reset(struct raydium_rm67200 *ctx)
> {
> - gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> - msleep(60);
> - gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> - msleep(60);
> - gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> - msleep(60);
> + if (ctx->reset_gpio) {
> + gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> + msleep(60);
> + gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> + msleep(60);
> + gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> + msleep(60);
> + }
> }
>
> static void raydium_rm67200_write(struct mipi_dsi_multi_context *ctx,
> @@ -412,7 +414,7 @@ static int raydium_rm67200_probe(struct mipi_dsi_device *dsi)
> if (ret < 0)
> return ret;
>
> - ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> + ctx->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> if (IS_ERR(ctx->reset_gpio))
> return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
> "Failed to get reset-gpios\n");
> --
> 2.43.0
>
> base-commit: 8c98c2c9ebeaa472e742d664b714aed5ab7c6f53
> branch: rk356x_rk3588_rk3576_dsi
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200
2025-06-16 7:05 [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200 Andy Yan
2025-06-16 7:05 ` [PATCH 2/2] drivers/panel: raydium-rm67200: Make reset-gpio optional Andy Yan
@ 2025-06-19 13:12 ` Sebastian Reichel
2025-06-26 23:53 ` Rob Herring (Arm)
2025-06-30 15:41 ` Neil Armstrong
3 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2025-06-19 13:12 UTC (permalink / raw)
To: Andy Yan
Cc: neil.armstrong, conor+dt, quic_jesszhan, krzk+dt, robh,
tzimmermann, devicetree, dri-devel, linux-kernel, Andy Yan
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
Hi,
On Mon, Jun 16, 2025 at 03:05:16PM +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> Although the datasheet of the panel module describes that it has a
> reset pin, in the actual hardware design, we often use an RC circuit
> to control the reset, and rarely use GPIO to control the reset. This
> is the way it is done on our numerous development boards (such as RK3568,
> RK3576 EVB).
> So make the reset-gpio optional.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Greetings,
-- Sebastian
>
> .../devicetree/bindings/display/panel/raydium,rm67200.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67200.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm67200.yaml
> index 54c9c0ef45ecc..97b7fbe05c077 100644
> --- a/Documentation/devicetree/bindings/display/panel/raydium,rm67200.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67200.yaml
> @@ -42,7 +42,6 @@ required:
> - compatible
> - port
> - reg
> - - reset-gpios
>
> additionalProperties: false
>
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200
2025-06-16 7:05 [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200 Andy Yan
2025-06-16 7:05 ` [PATCH 2/2] drivers/panel: raydium-rm67200: Make reset-gpio optional Andy Yan
2025-06-19 13:12 ` [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200 Sebastian Reichel
@ 2025-06-26 23:53 ` Rob Herring (Arm)
2025-06-30 15:41 ` Neil Armstrong
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-06-26 23:53 UTC (permalink / raw)
To: Andy Yan
Cc: linux-kernel, krzk+dt, neil.armstrong, conor+dt,
sebastian.reichel, quic_jesszhan, devicetree, tzimmermann,
dri-devel, Andy Yan
On Mon, 16 Jun 2025 15:05:16 +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> Although the datasheet of the panel module describes that it has a
> reset pin, in the actual hardware design, we often use an RC circuit
> to control the reset, and rarely use GPIO to control the reset. This
> is the way it is done on our numerous development boards (such as RK3568,
> RK3576 EVB).
> So make the reset-gpio optional.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
> .../devicetree/bindings/display/panel/raydium,rm67200.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200
2025-06-16 7:05 [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200 Andy Yan
` (2 preceding siblings ...)
2025-06-26 23:53 ` Rob Herring (Arm)
@ 2025-06-30 15:41 ` Neil Armstrong
3 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2025-06-30 15:41 UTC (permalink / raw)
To: Andy Yan
Cc: conor+dt, quic_jesszhan, krzk+dt, robh, sebastian.reichel,
tzimmermann, devicetree, dri-devel, linux-kernel, Andy Yan
Hi,
On Mon, 16 Jun 2025 15:05:16 +0800, Andy Yan wrote:
> Although the datasheet of the panel module describes that it has a
> reset pin, in the actual hardware design, we often use an RC circuit
> to control the reset, and rarely use GPIO to control the reset. This
> is the way it is done on our numerous development boards (such as RK3568,
> RK3576 EVB).
> So make the reset-gpio optional.
>
> [...]
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)
[1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/7513437b42d3ea682967e8fab113e20e558ecbc8
[2/2] drivers/panel: raydium-rm67200: Make reset-gpio optional
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/941461216c8d96b2c8b91233ba71483e011f78a3
--
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread