mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Weißschuh" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: thomas.weissschuh@linutronix.de,
	Thomas Gleixner <tglx@linutronix.de>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/vdso] selftests: vDSO: chacha: Correctly skip test if necessary
Date: Tue, 01 Jul 2025 13:59:20 -0000	[thread overview]
Message-ID: <175137836029.406.15841768497290312533.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250611-selftests-vdso-fixes-v3-1-e62e37a6bcf5@linutronix.de>

The following commit has been merged into the timers/vdso branch of tip:

Commit-ID:     2c0a4428f5d6005ff0db12057cc35273593fc040
Gitweb:        https://git.kernel.org/tip/2c0a4428f5d6005ff0db12057cc35273593fc040
Author:        Thomas Weißschuh <thomas.weissschuh@linutronix.de>
AuthorDate:    Wed, 11 Jun 2025 12:33:51 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 01 Jul 2025 15:50:41 +02:00

selftests: vDSO: chacha: Correctly skip test if necessary

According to kselftest.h ksft_exit_skip() is not meant to be called when
a plan has already been printed.

Use the recommended function ksft_test_result_skip().

This fixes a bug, where the TAP output would be invalid when skipping:

	TAP version 13
	1..1
	ok 2 # SKIP Not implemented on architecture

The SKIP line should start with "ok 1" as the plan only contains one test.

Fixes: 3b5992eaf730 ("selftests: vDSO: unconditionally build chacha test")
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Link: https://lore.kernel.org/all/20250611-selftests-vdso-fixes-v3-1-e62e37a6bcf5@linutronix.de

---
 tools/testing/selftests/vDSO/vdso_test_chacha.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/vDSO/vdso_test_chacha.c b/tools/testing/selftests/vDSO/vdso_test_chacha.c
index 8757f73..0aad682 100644
--- a/tools/testing/selftests/vDSO/vdso_test_chacha.c
+++ b/tools/testing/selftests/vDSO/vdso_test_chacha.c
@@ -76,7 +76,8 @@ static void reference_chacha20_blocks(uint8_t *dst_bytes, const uint32_t *key, u
 
 void __weak __arch_chacha20_blocks_nostack(uint8_t *dst_bytes, const uint32_t *key, uint32_t *counter, size_t nblocks)
 {
-	ksft_exit_skip("Not implemented on architecture\n");
+	ksft_test_result_skip("Not implemented on architecture\n");
+	ksft_finished();
 }
 
 int main(int argc, char *argv[])

  reply	other threads:[~2025-07-01 13:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 10:33 [PATCH v3 0/9] selftests: vDSO: Some cleanups and (warning) fixes Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 1/9] selftests: vDSO: chacha: Correctly skip test if necessary Thomas Weißschuh
2025-07-01 13:59   ` tip-bot2 for Thomas Weißschuh [this message]
2025-06-11 10:33 ` [PATCH v3 2/9] selftests: vDSO: clock_getres: Drop unused include of err.h Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 3/9] selftests: vDSO: vdso_test_getrandom: Drop unused include of linux/compiler.h Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 4/9] selftests: vDSO: vdso_test_getrandom: Avoid -Wunused Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 5/9] selftests: vDSO: vdso_config: Avoid -Wunused-variables Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 6/9] selftests: vDSO: enable -Wall Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] selftests: vDSO: Enable -Wall tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 7/9] selftests: vDSO: vdso_test_correctness: Fix -Wstrict-prototypes Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 8/9] selftests: vDSO: vdso_test_getrandom: Always print TAP header Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 9/9] selftests: vDSO: vdso_standalone_test_x86: Replace source file with symlink Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175137836029.406.15841768497290312533.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=usama.anjum@collabora.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®