mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	 Vincenzo Frascino <vincenzo.frascino@arm.com>,
	 Shuah Khan <shuah@kernel.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Shuah Khan" <skhan@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	"Muhammad Usama Anjum" <usama.anjum@collabora.com>,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Subject: [PATCH v3 5/9] selftests: vDSO: vdso_config: Avoid -Wunused-variables
Date: Wed, 11 Jun 2025 12:33:55 +0200	[thread overview]
Message-ID: <20250611-selftests-vdso-fixes-v3-5-e62e37a6bcf5@linutronix.de> (raw)
In-Reply-To: <20250611-selftests-vdso-fixes-v3-0-e62e37a6bcf5@linutronix.de>

Not all users of this header make use of all its variables.
For example vdso_test_correctness.c does not use "versions":

In file included from vdso_test_correctness.c:22:
vdso_config.h:61:20: warning: ‘versions’ defined but not used [-Wunused-variable]
   61 | static const char *versions[7] = {
      |                    ^~~~~~~~

Avoid those warnings through attribute((unused)).

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 tools/testing/selftests/vDSO/vdso_config.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/vDSO/vdso_config.h b/tools/testing/selftests/vDSO/vdso_config.h
index 722260f9756198956f0dfccced907284b6851e76..5fdd0f36233742bc47ae79f23d2cfae5a0f56dee 100644
--- a/tools/testing/selftests/vDSO/vdso_config.h
+++ b/tools/testing/selftests/vDSO/vdso_config.h
@@ -58,6 +58,7 @@
 #define VDSO_NAMES		1
 #endif
 
+__attribute__((unused))
 static const char *versions[7] = {
 	"LINUX_2.6",
 	"LINUX_2.6.15",
@@ -68,6 +69,7 @@ static const char *versions[7] = {
 	"LINUX_5.10"
 };
 
+__attribute__((unused))
 static const char *names[2][7] = {
 	{
 		"__kernel_gettimeofday",

-- 
2.49.0


  parent reply	other threads:[~2025-06-11 10:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 10:33 [PATCH v3 0/9] selftests: vDSO: Some cleanups and (warning) fixes Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 1/9] selftests: vDSO: chacha: Correctly skip test if necessary Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 2/9] selftests: vDSO: clock_getres: Drop unused include of err.h Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 3/9] selftests: vDSO: vdso_test_getrandom: Drop unused include of linux/compiler.h Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 4/9] selftests: vDSO: vdso_test_getrandom: Avoid -Wunused Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` Thomas Weißschuh [this message]
2025-07-01 13:59   ` [tip: timers/vdso] selftests: vDSO: vdso_config: Avoid -Wunused-variables tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 6/9] selftests: vDSO: enable -Wall Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] selftests: vDSO: Enable -Wall tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 7/9] selftests: vDSO: vdso_test_correctness: Fix -Wstrict-prototypes Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 8/9] selftests: vDSO: vdso_test_getrandom: Always print TAP header Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-06-11 10:33 ` [PATCH v3 9/9] selftests: vDSO: vdso_standalone_test_x86: Replace source file with symlink Thomas Weißschuh
2025-07-01 13:59   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250611-selftests-vdso-fixes-v3-5-e62e37a6bcf5@linutronix.de \
    --to=thomas.weissschuh@linutronix.de \
    --cc=Jason@zx2c4.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tglx@linutronix.de \
    --cc=usama.anjum@collabora.com \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®